From: Rob Herring <robh@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Harigovindan P <harigovi@codeaurora.org>,
devicetree@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>,
"Kristian H. Kristensen" <hoegsberg@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 02/15] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180
Date: Fri, 31 Jan 2020 10:38:46 -0600 [thread overview]
Message-ID: <CAL_Jsq+eKYm2Z9_2U3-FjvNc1ku690Qypuba=w_h_1wq4zJb-A@mail.gmail.com> (raw)
In-Reply-To: <20200130131220.v3.2.I0c4bbb0f75a0880cd4bd90d8b267271e2375e0d0@changeid>
On Thu, Jan 30, 2020 at 3:12 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> The qcom,dispcc bindings had a few problems with them:
>
> 1. They didn't specify all the clocks that dispcc is a client of.
> Specifically on sc7180 there are two clocks from the DSI PHY and
> two from the DP PHY. On sdm845 there are actually two DSI PHYs
> (each of which has two clocks) and an extra clock from the gcc.
> These all need to be specified.
>
> 2. The sdm845.dtsi has existed for quite some time without specifying
> the clocks. The Linux driver was relying on global names to match
> things up. While we should transition things, it should be noted
> in the bindings.
>
> 3. The names used the bindings for "xo" and "gpll0" didn't match the
> names that QC used for these clocks internally and this was causing
> confusion / difficulty with their code generation tools. Switched
> to the internal names to simplify everyone's lives. It's not quite
> as clean in a purist sense but it should avoid headaches. This
> officially changes the binding, but that seems OK in this case.
>
> Also note that I updated the example.
>
> Fixes: 5d28e44ba630 ("dt-bindings: clock: Add YAML schemas for the QCOM DISPCC clock bindings")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Changes in v3:
> - Added include file to description.
> - Discovered / added new gcc input clock on sdm845.
> - Split sc7180 and sdm845 into two files.
> - Switched names to internal QC names rather than logical ones.
> - Updated commit description.
>
> Changes in v2:
> - Patch ("dt-bindings: clock: Fix qcom,dispcc...") new for v2.
>
> .../bindings/clock/qcom,dispcc.yaml | 67 -------------
> .../bindings/clock/qcom,sc7180-dispcc.yaml | 84 ++++++++++++++++
> .../bindings/clock/qcom,sdm845-dispcc.yaml | 99 +++++++++++++++++++
> 3 files changed, 183 insertions(+), 67 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
Other than the same $id problem,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-01-31 16:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 21:12 [PATCH v3 00/15] clk: qcom: Fix parenting for dispcc/gpucc/videocc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 01/15] clk: qcom: rcg2: Don't crash if our parent can't be found; return an error Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 02/15] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180 Douglas Anderson
2020-01-31 16:38 ` Rob Herring [this message]
2020-01-30 21:12 ` [PATCH v3 03/15] arm64: dts: qcom: sdm845: Add the missing clocks on the dispcc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 04/15] clk: qcom: Get rid of fallback global names for dispcc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 05/15] clk: qcom: Get rid of the test clock " Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 06/15] clk: qcom: Use ARRAY_SIZE in dispcc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 07/15] dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998 Douglas Anderson
2020-01-31 16:43 ` Rob Herring
2020-01-31 16:48 ` Doug Anderson
[not found] ` <20200203162954.DE0AD2086A@mail.kernel.org>
2020-02-03 18:35 ` Doug Anderson
2020-01-30 21:12 ` [PATCH v3 08/15] arm64: dts: qcom: sdm845: Add missing clocks / fix names on the gpucc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 09/15] clk: qcom: Get rid of the test clock for gpucc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 10/15] clk: qcom: Use ARRAY_SIZE in gpucc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 11/15] dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180 Douglas Anderson
2020-01-31 16:36 ` Rob Herring
2020-01-30 21:12 ` [PATCH v3 12/15] clk: qcom: Get rid of the test clock for videocc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 13/15] clk: qcom: Use ARRAY_SIZE in videocc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 14/15] arm64: dts: qcom: sdm845: Add the missing clock on the videocc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 15/15] arm64: dts: sc7180: Add clock controller nodes Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+eKYm2Z9_2U3-FjvNc1ku690Qypuba=w_h_1wq4zJb-A@mail.gmail.com' \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=harigovi@codeaurora.org \
--cc=hoegsberg@chromium.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jhugo@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).