From: Doug Anderson <dianders@chromium.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Harigovindan P <harigovi@codeaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>,
"Kristian H. Kristensen" <hoegsberg@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 07/15] dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998
Date: Fri, 31 Jan 2020 08:48:37 -0800 [thread overview]
Message-ID: <CAD=FV=X=vAM7HZmA7pCm707rb8u+ogEqPUu_F_ueiS9GwbVwuw@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLj8WbP=oXAovyVFOc-58eFr5xS5EJK=kpAK-eT7_TyNw@mail.gmail.com>
Hi,
On Fri, Jan 31, 2020 at 8:43 AM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jan 30, 2020 at 3:12 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > The qcom,gpucc bindings had a few problems with them:
> >
> > 1. When things were converted to yaml the name of the "gpll0 main"
> > clock got changed from "gpll0" to "gpll0_main". Change it back for
> > msm8998.
> >
> > 2. Apparently there is a push not to use purist aliases for clocks but
> > instead to just use the internal Qualcomm names. For sdm845 and
> > sc7180 (where the drivers haven't already been changed) move in
> > this direction.
> >
> > Things were also getting complicated harder to deal with by jamming
> > several SoCs into one file. Splitting simplifies things.
> >
> > Fixes: 5c6f3a36b913 ("dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Added pointer to inlude file in description.
> > - Everyone but msm8998 now uses internal QC names.
> > - Fixed typo grpahics => graphics
> > - Split bindings into 3 files.
> >
> > Changes in v2:
> > - Patch ("dt-bindings: clock: Fix qcom,gpucc...") new for v2.
> >
> > .../devicetree/bindings/clock/qcom,gpucc.yaml | 72 -------------------
> > .../bindings/clock/qcom,msm8998-gpucc.yaml | 66 +++++++++++++++++
> > .../bindings/clock/qcom,sc7180-gpucc.yaml | 72 +++++++++++++++++++
> > .../bindings/clock/qcom,sdm845-gpucc.yaml | 72 +++++++++++++++++++
> > 4 files changed, 210 insertions(+), 72 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,msm8998-gpucc.yaml
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sdm845-gpucc.yaml
>
> I'm not seeing any differences in sdm845 and sc7180. Do those really
> need to be separate? It doesn't have to be all combined or all
> separate.
They are the same, other than pointing to a different #include file.
I debated whether to put them in one file (arbitrarily named after one
SoC or the other) or to put them in individual files. I got the
impression from Stephen that he'd prefer them to be separate files
even in the case that they were 99% identical, but I certainly could
have misunderstood.
I'll do whatever you guys agree to. If you want them in one file I'll
probably name it "qcom,sdm845-gpucc.yaml" just because that SoC is
earlier, unless someone tells me otherwise.
-Doug
next prev parent reply other threads:[~2020-01-31 16:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 21:12 [PATCH v3 00/15] clk: qcom: Fix parenting for dispcc/gpucc/videocc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 01/15] clk: qcom: rcg2: Don't crash if our parent can't be found; return an error Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 02/15] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180 Douglas Anderson
2020-01-31 16:38 ` Rob Herring
2020-01-30 21:12 ` [PATCH v3 03/15] arm64: dts: qcom: sdm845: Add the missing clocks on the dispcc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 04/15] clk: qcom: Get rid of fallback global names for dispcc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 05/15] clk: qcom: Get rid of the test clock " Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 06/15] clk: qcom: Use ARRAY_SIZE in dispcc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 07/15] dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998 Douglas Anderson
2020-01-31 16:43 ` Rob Herring
2020-01-31 16:48 ` Doug Anderson [this message]
[not found] ` <20200203162954.DE0AD2086A@mail.kernel.org>
2020-02-03 18:35 ` Doug Anderson
2020-01-30 21:12 ` [PATCH v3 08/15] arm64: dts: qcom: sdm845: Add missing clocks / fix names on the gpucc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 09/15] clk: qcom: Get rid of the test clock for gpucc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 10/15] clk: qcom: Use ARRAY_SIZE in gpucc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 11/15] dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180 Douglas Anderson
2020-01-31 16:36 ` Rob Herring
2020-01-30 21:12 ` [PATCH v3 12/15] clk: qcom: Get rid of the test clock for videocc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 13/15] clk: qcom: Use ARRAY_SIZE in videocc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 14/15] arm64: dts: qcom: sdm845: Add the missing clock on the videocc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 15/15] arm64: dts: sc7180: Add clock controller nodes Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X=vAM7HZmA7pCm707rb8u+ogEqPUu_F_ueiS9GwbVwuw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=harigovi@codeaurora.org \
--cc=hoegsberg@chromium.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jhugo@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).