From: Amit Pundir <amit.pundir@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Rob Clark <robdclark@chromium.org>,
freedreno <freedreno@lists.freedesktop.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>,
David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Akhil P Oommen <akhilpo@codeaurora.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sean Paul <sean@poorly.run>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm: Disable frequency clamping on a630
Date: Tue, 7 Sep 2021 13:55:22 +0530 [thread overview]
Message-ID: <CAMi1Hd20xd0Lrp0MuKo=HdDPKeNC_DW08iFoF5wseCH5eB=FzQ@mail.gmail.com> (raw)
In-Reply-To: <CAF6AEGugB5QinhyOxvAiG_V40=mXS20nnqxgk71xe_fmm1iZsw@mail.gmail.com>
On Tue, 7 Sept 2021 at 07:11, Rob Clark <robdclark@gmail.com> wrote:
>
> One thing I thought of, which would be worth ruling out, is whether
> this issue only occurs with freq changes immediately after resuming
> the GPU, vs freq changes in general. Could you try the below patch.
> And if it "fixes" the issue, then try reducing the delay until you
> start seeing GPU hangs again.
It doesn't fix the crash and I can still reproduce it
https://pastebin.com/raw/bxK4mAhB
>
> ----------
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index 40c9fef457a4..278b85207ea3 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1513,6 +1513,8 @@ static int a6xx_pm_resume(struct msm_gpu *gpu)
> if (ret)
> return ret;
>
> + msleep(5);
> +
> msm_devfreq_resume(gpu);
>
> a6xx_llc_activate(a6xx_gpu);
> ----------
>
> BR,
> -R
next prev parent reply other threads:[~2021-09-07 8:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 18:39 [PATCH] drm/msm: Disable frequency clamping on a630 Rob Clark
2021-07-29 20:06 ` Caleb Connolly
2021-07-29 20:24 ` Rob Clark
2021-07-29 20:28 ` Caleb Connolly
2021-07-29 20:53 ` Rob Clark
2021-08-07 19:21 ` Caleb Connolly
2021-08-07 20:04 ` Rob Clark
2021-08-08 14:32 ` Caleb Connolly
2021-08-08 16:52 ` Rob Clark
2021-08-09 14:51 ` Akhil P Oommen
2021-08-09 16:12 ` Rob Clark
2021-08-09 16:18 ` Caleb Connolly
2021-08-09 17:26 ` Akhil P Oommen
2021-08-09 17:58 ` Rob Clark
2021-08-09 20:35 ` Caleb Connolly
2021-08-09 21:08 ` Rob Clark
2021-09-07 15:43 ` Bjorn Andersson
2021-09-08 2:21 ` Bjorn Andersson
2021-09-08 13:49 ` Caleb Connolly
2021-09-09 12:17 ` Amit Pundir
2021-09-09 16:12 ` Amit Pundir
2021-09-09 19:49 ` Akhil P Oommen
2021-09-09 20:54 ` Rob Clark
2021-09-10 17:22 ` Rob Clark
2021-09-10 17:18 ` Rob Clark
2021-09-10 17:34 ` Caleb Connolly
2021-09-13 6:15 ` Akhil P Oommen
2021-09-03 19:39 ` John Stultz
2021-09-03 20:29 ` Rob Clark
2021-09-06 8:01 ` Amit Pundir
2021-09-06 16:28 ` Rob Clark
2021-09-06 19:58 ` Amit Pundir
2021-09-06 20:50 ` Rob Clark
2021-09-06 21:27 ` Rob Clark
2021-09-07 8:18 ` Amit Pundir
2021-09-07 1:45 ` Rob Clark
2021-09-07 8:25 ` Amit Pundir [this message]
2021-09-07 14:25 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMi1Hd20xd0Lrp0MuKo=HdDPKeNC_DW08iFoF5wseCH5eB=FzQ@mail.gmail.com' \
--to=amit.pundir@linaro.org \
--cc=airlied@linux.ie \
--cc=akhilpo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=jonathan@marek.ca \
--cc=jordan@cosmicpenguin.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).