* Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)
[not found] ` <20230320082146.4117022-1-geert@linux-m68k.org>
@ 2023-03-21 5:38 ` Randy Dunlap
2023-03-21 7:34 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-03-21 5:38 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-kernel
Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, linux-arm-msm, dri-devel
Hi--
On 3/20/23 01:21, Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v6.3-rc3[1] compared to v6.2[2].
>
> Summarized:
> - build errors: +9/-14
> - build warnings: +4/-1447
>
> JFYI, when comparing v6.3-rc3[1] to v6.3-rc2[3], the summaries are:
> - build errors: +0/-1
> - build warnings: +0/-0
>
> Happy fixing! ;-)
>
> Thanks to the linux-next team for providing the build service.
>
> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/e8d018dd0257f744ca50a729e3d042cf2ec9da65/ (all 152 configs)
> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/c9c3395d5e3dcc6daee66c6908354d47bf98cb0c/ (all 152 configs)
> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/eeac8ede17557680855031c6f305ece2378af326/ (all 152 configs)
>
>
> *** ERRORS ***
>
> 9 error regressions:
> + /kisskb/src/drivers/gpu/drm/msm/msm_mdss.c: error: case label does not reduce to an integer constant: => 300:2, 299:2, 296:2
Are these due to the sign bit being set after a shift?
It looks that way since it is only reported for such values.
From the reports on the build server, it only happens when building with gcc5.
I don't have the ability to build with gcc5 or I would test it.
@Rob and other drm/msm people, what do you think about this?
(or is this already fixed somewhere but not yet in linux-next?)
Thanks.
-----
diff -- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
@@ -19,9 +19,9 @@
*/
#define MAX_BLOCKS 12
-#define DPU_HW_VER(MAJOR, MINOR, STEP) (((MAJOR & 0xF) << 28) |\
- ((MINOR & 0xFFF) << 16) |\
- (STEP & 0xFFFF))
+#define DPU_HW_VER(MAJOR, MINOR, STEP) ((((__u32)MAJOR & 0xF) << 28) |\
+ (((__u32)MINOR & 0xFFF) << 16) |\
+ ((__u32)STEP & 0xFFFF))
#define DPU_HW_MAJOR(rev) ((rev) >> 28)
#define DPU_HW_MINOR(rev) (((rev) >> 16) & 0xFFF)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)
2023-03-21 5:38 ` Build regressions/improvements in v6.3-rc3 (drm/msm/) Randy Dunlap
@ 2023-03-21 7:34 ` Geert Uytterhoeven
2023-03-21 15:10 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-03-21 7:34 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
linux-arm-msm, dri-devel
Hi Randy,
On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 3/20/23 01:21, Geert Uytterhoeven wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v6.3-rc3[1] compared to v6.2[2].
> >
> > Summarized:
> > - build errors: +9/-14
> > - build warnings: +4/-1447
> >
> > JFYI, when comparing v6.3-rc3[1] to v6.3-rc2[3], the summaries are:
> > - build errors: +0/-1
> > - build warnings: +0/-0
> >
> > Happy fixing! ;-)
> >
> > Thanks to the linux-next team for providing the build service.
> >
> > [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/e8d018dd0257f744ca50a729e3d042cf2ec9da65/ (all 152 configs)
> > [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/c9c3395d5e3dcc6daee66c6908354d47bf98cb0c/ (all 152 configs)
> > [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/eeac8ede17557680855031c6f305ece2378af326/ (all 152 configs)
> >
> >
> > *** ERRORS ***
> >
> > 9 error regressions:
>
> > + /kisskb/src/drivers/gpu/drm/msm/msm_mdss.c: error: case label does not reduce to an integer constant: => 300:2, 299:2, 296:2
>
>
> Are these due to the sign bit being set after a shift?
> It looks that way since it is only reported for such values.
Yep.
> From the reports on the build server, it only happens when building with gcc5.
> I don't have the ability to build with gcc5 or I would test it.
I deliberately installed gcc-5.5.0-nolibc/aarch64-linux to reproduce it
(gcc5 on x86 didn't reproduce).
> @Rob and other drm/msm people, what do you think about this?
> (or is this already fixed somewhere but not yet in linux-next?)
Thanks, I posted a similar fix two weeks ago:
https://lore.kernel.org/all/20230306090633.65918-1-geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)
2023-03-21 7:34 ` Geert Uytterhoeven
@ 2023-03-21 15:10 ` Randy Dunlap
2023-03-21 15:33 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-03-21 15:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-kernel, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
linux-arm-msm, dri-devel
Hiya,
On 3/21/23 00:34, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 3/20/23 01:21, Geert Uytterhoeven wrote:
>>> Below is the list of build error/warning regressions/improvements in
>>> v6.3-rc3[1] compared to v6.2[2].
>>>
>>> Summarized:
>>> - build errors: +9/-14
>>> - build warnings: +4/-1447
>>>
>>> JFYI, when comparing v6.3-rc3[1] to v6.3-rc2[3], the summaries are:
>>> - build errors: +0/-1
>>> - build warnings: +0/-0
>>>
>>> Happy fixing! ;-)
>>>
>>> Thanks to the linux-next team for providing the build service.
>>>
>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/e8d018dd0257f744ca50a729e3d042cf2ec9da65/ (all 152 configs)
>>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/c9c3395d5e3dcc6daee66c6908354d47bf98cb0c/ (all 152 configs)
>>> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/eeac8ede17557680855031c6f305ece2378af326/ (all 152 configs)
>>>
>>>
>>> *** ERRORS ***
>>>
>>> 9 error regressions:
>>
>>> + /kisskb/src/drivers/gpu/drm/msm/msm_mdss.c: error: case label does not reduce to an integer constant: => 300:2, 299:2, 296:2
>>
>>
>> Are these due to the sign bit being set after a shift?
>> It looks that way since it is only reported for such values.
>
> Yep.
>
>> From the reports on the build server, it only happens when building with gcc5.
>> I don't have the ability to build with gcc5 or I would test it.
>
> I deliberately installed gcc-5.5.0-nolibc/aarch64-linux to reproduce it
> (gcc5 on x86 didn't reproduce).
Yes, I installed that same compiler. When I tried to use it, I got:
/opt/crosstool/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc: unknown C compiler
scripts/Kconfig.include:44: Sorry, this C compiler is not supported.
and I didn't try to track down what that means or what is causing it...
>> @Rob and other drm/msm people, what do you think about this?
>> (or is this already fixed somewhere but not yet in linux-next?)
>
> Thanks, I posted a similar fix two weeks ago:
> https://lore.kernel.org/all/20230306090633.65918-1-geert+renesas@glider.be
OK, I replied to that one.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)
2023-03-21 15:10 ` Randy Dunlap
@ 2023-03-21 15:33 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-03-21 15:33 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
linux-arm-msm, dri-devel
Hi Randy,
On Tue, Mar 21, 2023 at 4:10 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 3/21/23 00:34, Geert Uytterhoeven wrote:
> > On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >> On 3/20/23 01:21, Geert Uytterhoeven wrote:
> >>> Below is the list of build error/warning regressions/improvements in
> >>> v6.3-rc3[1] compared to v6.2[2].
> >>>
> >>> Summarized:
> >>> - build errors: +9/-14
> >>> - build warnings: +4/-1447
> >>>
> >>> JFYI, when comparing v6.3-rc3[1] to v6.3-rc2[3], the summaries are:
> >>> - build errors: +0/-1
> >>> - build warnings: +0/-0
> >>>
> >>> Happy fixing! ;-)
> >>>
> >>> Thanks to the linux-next team for providing the build service.
> >>>
> >>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/e8d018dd0257f744ca50a729e3d042cf2ec9da65/ (all 152 configs)
> >>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/c9c3395d5e3dcc6daee66c6908354d47bf98cb0c/ (all 152 configs)
> >>> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/eeac8ede17557680855031c6f305ece2378af326/ (all 152 configs)
> >>>
> >>>
> >>> *** ERRORS ***
> >>>
> >>> 9 error regressions:
> >>
> >>> + /kisskb/src/drivers/gpu/drm/msm/msm_mdss.c: error: case label does not reduce to an integer constant: => 300:2, 299:2, 296:2
> >>
> >>
> >> Are these due to the sign bit being set after a shift?
> >> It looks that way since it is only reported for such values.
> >
> > Yep.
> >
> >> From the reports on the build server, it only happens when building with gcc5.
> >> I don't have the ability to build with gcc5 or I would test it.
> >
> > I deliberately installed gcc-5.5.0-nolibc/aarch64-linux to reproduce it
> > (gcc5 on x86 didn't reproduce).
>
> Yes, I installed that same compiler. When I tried to use it, I got:
>
> /opt/crosstool/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc: unknown C compiler
> scripts/Kconfig.include:44: Sorry, this C compiler is not supported.
I didn't run into that. I used
make ARCH=arm64
CROSS_COMPILE=/opt/cross/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-
drivers/gpu/drm/msm/msm_mdss.o
I did have to disable CONFIG_GCC_PLUGINS, else it couldn't find
<gmp.h>.
> >> @Rob and other drm/msm people, what do you think about this?
> >> (or is this already fixed somewhere but not yet in linux-next?)
> >
> > Thanks, I posted a similar fix two weeks ago:
> > https://lore.kernel.org/all/20230306090633.65918-1-geert+renesas@glider.be
>
> OK, I replied to that one.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-21 15:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAHk-=wiPd8R8-zSqTOtJ9KYeZLBByHug7ny3rgP-ZqzpP_KELg@mail.gmail.com>
[not found] ` <20230320082146.4117022-1-geert@linux-m68k.org>
2023-03-21 5:38 ` Build regressions/improvements in v6.3-rc3 (drm/msm/) Randy Dunlap
2023-03-21 7:34 ` Geert Uytterhoeven
2023-03-21 15:10 ` Randy Dunlap
2023-03-21 15:33 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).