From: John Stultz <john.stultz@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH v2 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node
Date: Mon, 7 Oct 2019 10:44:02 -0700 [thread overview]
Message-ID: <CANcMJZBWsfwWmHbGCG+KG4n1kpmytw_8O4uA8HEVv8ysBxiQgw@mail.gmail.com> (raw)
In-Reply-To: <20190724044906.12007-2-vkoul@kernel.org>
On Tue, Jul 23, 2019 at 9:51 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> We get a warning about missing unit name for soc node, so add it.
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 601cfb078bd5..e81f4a6d08ce 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -620,7 +620,7 @@
> method = "smc";
> };
>
> - soc: soc {
> + soc: soc@0 {
> #address-cells = <2>;
> #size-cells = <2>;
> ranges = <0 0 0 0 0x10 0>;
So Amit Pundir noted that this patch is causing 5.4-rc to no longer
boot on db845 w/ AOSP, due to it changing the userland sysfs paths
from "/devices/platform/soc/1a00000.mdss" to
"/devices/platform/soc@0/1a00000.mdss"
Is there a better solution here that might not break userspace?
thanks
-john
next prev parent reply other threads:[~2019-10-07 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:49 [PATCH v2 0/5] arm64: dts: qcom: sdm845: Fix DTS warnings Vinod Koul
2019-07-24 4:49 ` [PATCH v2 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node Vinod Koul
2019-07-24 5:00 ` Amit Kucheria
2019-10-07 17:44 ` John Stultz [this message]
2019-10-07 17:57 ` Rob Herring
2019-07-24 4:49 ` [PATCH v2 2/5] arm64: dts: qcom: sdm845: remove unnecessary properties for dsi nodes Vinod Koul
2019-07-24 5:01 ` Amit Kucheria
2019-07-24 4:49 ` [PATCH v2 3/5] arm64: dts: qcom: sdm845: remove unit name for thermal trip points Vinod Koul
2019-07-24 5:20 ` Amit Kucheria
2019-07-24 4:49 ` [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name Vinod Koul
2019-07-24 5:21 ` Amit Kucheria
2019-07-24 14:11 ` Stephen Boyd
2019-07-24 4:49 ` [PATCH v2 5/5] arm64: dts: qcom: sdm845-cheza: " Vinod Koul
2019-07-24 5:21 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANcMJZBWsfwWmHbGCG+KG4n1kpmytw_8O4uA8HEVv8ysBxiQgw@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).