From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8998-mtp: Add alias for blsp1_uart3
Date: Tue, 19 Nov 2019 08:37:58 -0700 [thread overview]
Message-ID: <CAOCk7NrvmVFu5PgQsaDJO69kpMAzWdV9DCiGrtQyQRFf6xX5Nw@mail.gmail.com> (raw)
In-Reply-To: <20191119011823.379100-1-bjorn.andersson@linaro.org>
On Mon, Nov 18, 2019 at 6:18 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> The msm_serial driver has a predefined set of uart ports defined, which
> is allocated either by reading aliases or if no match is found a simple
> counter, starting at index 0. But there's no logic in place to prevent
> these two allocation mechanism from colliding. As a result either none
> or all of the active msm_serial instances must be listed as aliases.
>
> Define blsp1_uart3 as "serial1" to mitigate this problem.
>
> Fixes: 4cffb9f2c700 ("arm64: dts: qcom: msm8998-mtp: Enable bluetooth")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Seems good to me.
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
>
> Changes since v1:
> - Rewrote commit message
>
> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> index 5f101a20a20a..e08fcb426bbf 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> @@ -9,6 +9,7 @@
> / {
> aliases {
> serial0 = &blsp2_uart1;
> + serial1 = &blsp1_uart3;
> };
>
> chosen {
> --
> 2.23.0
>
prev parent reply other threads:[~2019-11-19 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 1:18 [PATCH v2] arm64: dts: qcom: msm8998-mtp: Add alias for blsp1_uart3 Bjorn Andersson
2019-11-19 15:37 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7NrvmVFu5PgQsaDJO69kpMAzWdV9DCiGrtQyQRFf6xX5Nw@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).