linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/3] Cleanup dtbs_check warnings for tsens
@ 2020-02-25  7:31 Amit Kucheria
  2020-02-25  7:31 ` [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens Amit Kucheria
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-02-25  7:31 UTC (permalink / raw)
  To: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson,
	sivaa, Andy Gross, Zhang Rui
  Cc: Amit Kucheria, devicetree, linux-pm

Make dtbs_check pass for tsens bits. I'm working on another series to
cleanup other DT warnings for QC platforms.

Amit Kucheria (3):
  dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens
  dt-bindings: thermal: tsens: Make dtbs_check pass for msm8916 tsens
  dt-bindings: thermal: tsens: Make dtbs_check pass for msm8996 tsens

 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
 arch/arm64/boot/dts/qcom/msm8916.dtsi                     | 2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi                     | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens
  2020-02-25  7:31 [PATCH v1 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria
@ 2020-02-25  7:31 ` Amit Kucheria
  2020-02-25 10:16   ` Vinod Koul
  2020-02-25  7:31 ` [PATCH v1 2/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8916 tsens Amit Kucheria
  2020-02-25  7:31 ` [PATCH v1 3/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8996 tsens Amit Kucheria
  2 siblings, 1 reply; 6+ messages in thread
From: Amit Kucheria @ 2020-02-25  7:31 UTC (permalink / raw)
  To: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson,
	sivaa, Andy Gross, Zhang Rui
  Cc: Amit Kucheria, linux-pm, devicetree

Fixes the following warnings:
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens',
'qcom,tsens-v2'] is not valid under any of the given schemas (Possible
causes of the failure):
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
['qcom,msm8976-tsens', 'qcom,qcs404-tsens']
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens']
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected

builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c265000: compatible: ['qcom,sc7180-tsens',
'qcom,tsens-v2'] is not valid under any of the given schemas (Possible
causes of the failure):
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of
['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of
['qcom,msm8976-tsens', 'qcom,qcs404-tsens']
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of
['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens']
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c265000: compatible:1: 'qcom,tsens-v0_1' was expected
builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
thermal-sensor@c265000: compatible:1: 'qcom,tsens-v1' was expected

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index eef13b9446a8..13e294328932 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -39,6 +39,7 @@ properties:
               - qcom,msm8996-tsens
               - qcom,msm8998-tsens
               - qcom,sdm845-tsens
+              - qcom,sc7180-tsens
           - const: qcom,tsens-v2
 
   reg:
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v1 2/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8916 tsens
  2020-02-25  7:31 [PATCH v1 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria
  2020-02-25  7:31 ` [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens Amit Kucheria
@ 2020-02-25  7:31 ` Amit Kucheria
  2020-02-25  7:31 ` [PATCH v1 3/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8996 tsens Amit Kucheria
  2 siblings, 0 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-02-25  7:31 UTC (permalink / raw)
  To: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson,
	sivaa, Andy Gross, Zhang Rui
  Cc: devicetree

/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml:
thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is not valid
under any of the given schemas (Possible causes of the failure):
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml:
thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is too short
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml:
thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of
['qcom,msm8976-tsens', 'qcom,qcs404-tsens']
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml:
thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of
['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens']

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 9f31064f2374..1748ea3f4b4f 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -860,7 +860,7 @@
 		};
 
 		tsens: thermal-sensor@4a9000 {
-			compatible = "qcom,msm8916-tsens";
+			compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1";
 			reg = <0x4a9000 0x1000>, /* TM */
 			      <0x4a8000 0x1000>; /* SROT */
 			nvmem-cells = <&tsens_caldata>, <&tsens_calsel>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v1 3/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8996 tsens
  2020-02-25  7:31 [PATCH v1 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria
  2020-02-25  7:31 ` [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens Amit Kucheria
  2020-02-25  7:31 ` [PATCH v1 2/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8916 tsens Amit Kucheria
@ 2020-02-25  7:31 ` Amit Kucheria
  2 siblings, 0 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-02-25  7:31 UTC (permalink / raw)
  To: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson,
	sivaa, Andy Gross, Zhang Rui
  Cc: devicetree

/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid
under any of the given schemas (Possible causes of the failure):
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of
['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of
['qcom,msm8976-tsens', 'qcom,qcs404-tsens']

/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid
under any of the given schemas (Possible causes of the failure):
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of
['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
/home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml:
thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of
['qcom,msm8976-tsens', 'qcom,qcs404-tsens']

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 7ae082ea14ea..f157cd4f53b4 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -446,7 +446,7 @@
 		};
 
 		tsens0: thermal-sensor@4a9000 {
-			compatible = "qcom,msm8996-tsens";
+			compatible = "qcom,msm8996-tsens", "qcom,tsens-v2";
 			reg = <0x004a9000 0x1000>, /* TM */
 			      <0x004a8000 0x1000>; /* SROT */
 			#qcom,sensors = <13>;
@@ -457,7 +457,7 @@
 		};
 
 		tsens1: thermal-sensor@4ad000 {
-			compatible = "qcom,msm8996-tsens";
+			compatible = "qcom,msm8996-tsens", "qcom,tsens-v2";
 			reg = <0x004ad000 0x1000>, /* TM */
 			      <0x004ac000 0x1000>; /* SROT */
 			#qcom,sensors = <8>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens
  2020-02-25  7:31 ` [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens Amit Kucheria
@ 2020-02-25 10:16   ` Vinod Koul
  2020-02-25 12:06     ` Amit Kucheria
  0 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2020-02-25 10:16 UTC (permalink / raw)
  To: Amit Kucheria
  Cc: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson,
	sivaa, Andy Gross, Zhang Rui, Amit Kucheria, linux-pm,
	devicetree

On 25-02-20, 13:01, Amit Kucheria wrote:
> Fixes the following warnings:
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens',
> 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible
> causes of the failure):
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
> ['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
> ['qcom,msm8976-tsens', 'qcom,qcs404-tsens']
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
> ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens']
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected

I think the patch title should be "add qcom,sc7180-tsens to  qcom-tsens.yaml"

and it would be great to see explanation on how adding it fixes these
warns.

Relooking at series I think this applies to rest of the series too :)

Thanks


> 
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c265000: compatible: ['qcom,sc7180-tsens',
> 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible
> causes of the failure):
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of
> ['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of
> ['qcom,msm8976-tsens', 'qcom,qcs404-tsens']
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of
> ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens']
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c265000: compatible:1: 'qcom,tsens-v0_1' was expected
> builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> thermal-sensor@c265000: compatible:1: 'qcom,tsens-v1' was expected
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index eef13b9446a8..13e294328932 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -39,6 +39,7 @@ properties:
>                - qcom,msm8996-tsens
>                - qcom,msm8998-tsens
>                - qcom,sdm845-tsens
> +              - qcom,sc7180-tsens
>            - const: qcom,tsens-v2
>  
>    reg:
> -- 
> 2.20.1

-- 
~Vinod

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens
  2020-02-25 10:16   ` Vinod Koul
@ 2020-02-25 12:06     ` Amit Kucheria
  0 siblings, 0 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-02-25 12:06 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Linux Kernel Mailing List, linux-arm-msm, Daniel Lezcano,
	Bjorn Andersson, sivaa, Andy Gross, Zhang Rui, Amit Kucheria,
	Linux PM list, DTML

On Tue, Feb 25, 2020 at 3:46 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 25-02-20, 13:01, Amit Kucheria wrote:
> > Fixes the following warnings:
> > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> > thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens',
> > 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible
> > causes of the failure):
> > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
> > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens']
> > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
> > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens']
> > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of
> > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens']
> > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected
> > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml:
> > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected
>
> I think the patch title should be "add qcom,sc7180-tsens to  qcom-tsens.yaml"
>
> and it would be great to see explanation on how adding it fixes these
> warns.

Agreed. I'll send out a new version with the commit messages fixed.

> Relooking at series I think this applies to rest of the series too :)
>

Thanks for the review.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-25 12:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25  7:31 [PATCH v1 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria
2020-02-25  7:31 ` [PATCH v1 1/3] dt-bindings: thermal: tsens: Make dtbs_check pass for sc7180 tsens Amit Kucheria
2020-02-25 10:16   ` Vinod Koul
2020-02-25 12:06     ` Amit Kucheria
2020-02-25  7:31 ` [PATCH v1 2/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8916 tsens Amit Kucheria
2020-02-25  7:31 ` [PATCH v1 3/3] dt-bindings: thermal: tsens: Make dtbs_check pass for msm8996 tsens Amit Kucheria

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).