Re: [PATCH v5 00/11] Add simple NVMEM Framework via regmap.

[Pantelis Antoniou <pantelis.antoniou@konsulko.com>]

Hi Srinivas,

> On May 21, 2015, at 19:42 , Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote:
> 
> Thankyou all for providing inputs and comments on previous versions of this patchset.
> Here is the v5 of the patchset addressing all the issues raised as
> part of previous versions review.
> 

> 

[snip]

I tried to use the updated patchset with my at24 & beaglebone capemanager patches.

I have a big problem with the removal of the raw of_* access APIs.

Take for instance the case where you have multiple slot accessing different EEPROMs.

> slots {
> 	slot@0 {
> 		eeprom = <&cape0_data>;
> 	};
> 
> 	slot@1 {
> 		eeprom = <&cape1_data>;
> 	};
> };

In that case there is no per-device node mapping; it’s a per-sub node.

For now I’m exporting the of_* accessors again, please consider exposing the of_* API again.

> -- 
> 1.9.1
> 

Regards

— Pantelis