* Re: [PATCH v5 0/5] msm8996 CPU scaling support
@ 2021-02-03 10:15 Yassine Oudjana
0 siblings, 0 replies; 3+ messages in thread
From: Yassine Oudjana @ 2021-02-03 10:15 UTC (permalink / raw)
To: loic.poulain
Cc: amit.kucheria, bjorn.andersson, linux-arm-msm, linux-clk, sboyd
Hi,
Any recent progress on this?
Testing it on Xiaomi MI Note 2 (msm8996pro), It freezes during boot
and/or crashes and reboots most of the time. When it doesn't do that it
works well, until I stress all 4 CPUs, which makes it crash. Maybe
msm8996pro needs some extra work?
Setting s11 to 470000-1140000uV, 980000-980000uV, or 1140000,1140000uV
doesn't change anything.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 0/5] msm8996 CPU scaling support
2020-07-03 8:49 Loic Poulain
@ 2020-07-03 19:33 ` Bjorn Andersson
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-07-03 19:33 UTC (permalink / raw)
To: Loic Poulain; +Cc: sboyd, linux-arm-msm, linux-clk, amit.kucheria
On Fri 03 Jul 01:49 PDT 2020, Loic Poulain wrote:
> This series is a new tentative for adding MSM8996 CPU scaling support
> based on the previous Ilia's series, with some of the latest comments
> addressed.
>
> This series has been tested with dragonboard-820c and cpufreq-bench.
> The CPU opps are limited to maximum nominal frequencies (no turbo).
>
On the board where I usually see issues when we test CPUfreq I see a
sudden reboot right before getting a login prompt.
I did however conclude that disabling CPU2 and CPU3, so presumably
I'm running low on juice when we drive them to highest frequency.
I will do some more digging into this and see what's going on. With just
CPU0 and 1 enabled this seems to work really well though.
Regards,
Bjorn
> v2:
> - Converted dt bindings to YAML
> - Various fixes from Stephen inputs
> - Removed useless wmb barrier, MODULE_ALIAS
> - Use helpers like struct_size() and devm_platform_ioremap_resource()
> - Coding style fixes + comments
> - Kconfig: remove useless depends
> - Added Co-developed-by tag
>
> v3:
> - Added Ilia and Rajendra s-o-b and contribution description
>
> v4:
> - Rebasing on master
> - Removing obsolete cooling-min-level and cooling-max-level props
> - Align cpu trip nodes names with other boards
> - Fix trip types to passive for cpufreq
>
> v5:
> - Fix reported 0-DAY CI issues, read_cpuid_mpidr usage requires ARM64 conf
> - Fix cpu_crit node labels
> - Dedicated patch for speedbin node name change
> - Added patch description for dtsi patch
>
> Ilia Lin (2):
> soc: qcom: Separate kryo l2 accessors from PMU driver
> dt-bindings: clk: qcom: Add bindings for CPU clock for msm8996
>
> Loic Poulain (3):
> clk: qcom: Add CPU clock driver for msm8996
> arch: arm64: dts: msm8996: Rename speedbin node
> arch: arm64: dts: msm8996: Add CPU opps and thermal
>
> .../bindings/clock/qcom,msm8996-apcc.yaml | 56 +++
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 310 +++++++++++-
> drivers/clk/qcom/Kconfig | 9 +
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/clk-alpha-pll.h | 6 +
> drivers/clk/qcom/clk-cpu-8996.c | 538 +++++++++++++++++++++
> drivers/perf/Kconfig | 1 +
> drivers/perf/qcom_l2_pmu.c | 90 +---
> drivers/soc/qcom/Kconfig | 4 +
> drivers/soc/qcom/Makefile | 1 +
> drivers/soc/qcom/kryo-l2-accessors.c | 57 +++
> include/soc/qcom/kryo-l2-accessors.h | 12 +
> 12 files changed, 1012 insertions(+), 73 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml
> create mode 100644 drivers/clk/qcom/clk-cpu-8996.c
> create mode 100644 drivers/soc/qcom/kryo-l2-accessors.c
> create mode 100644 include/soc/qcom/kryo-l2-accessors.h
>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v5 0/5] msm8996 CPU scaling support
@ 2020-07-03 8:49 Loic Poulain
2020-07-03 19:33 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Loic Poulain @ 2020-07-03 8:49 UTC (permalink / raw)
To: sboyd, bjorn.andersson
Cc: linux-arm-msm, linux-clk, amit.kucheria, Loic Poulain
This series is a new tentative for adding MSM8996 CPU scaling support
based on the previous Ilia's series, with some of the latest comments
addressed.
This series has been tested with dragonboard-820c and cpufreq-bench.
The CPU opps are limited to maximum nominal frequencies (no turbo).
v2:
- Converted dt bindings to YAML
- Various fixes from Stephen inputs
- Removed useless wmb barrier, MODULE_ALIAS
- Use helpers like struct_size() and devm_platform_ioremap_resource()
- Coding style fixes + comments
- Kconfig: remove useless depends
- Added Co-developed-by tag
v3:
- Added Ilia and Rajendra s-o-b and contribution description
v4:
- Rebasing on master
- Removing obsolete cooling-min-level and cooling-max-level props
- Align cpu trip nodes names with other boards
- Fix trip types to passive for cpufreq
v5:
- Fix reported 0-DAY CI issues, read_cpuid_mpidr usage requires ARM64 conf
- Fix cpu_crit node labels
- Dedicated patch for speedbin node name change
- Added patch description for dtsi patch
Ilia Lin (2):
soc: qcom: Separate kryo l2 accessors from PMU driver
dt-bindings: clk: qcom: Add bindings for CPU clock for msm8996
Loic Poulain (3):
clk: qcom: Add CPU clock driver for msm8996
arch: arm64: dts: msm8996: Rename speedbin node
arch: arm64: dts: msm8996: Add CPU opps and thermal
.../bindings/clock/qcom,msm8996-apcc.yaml | 56 +++
arch/arm64/boot/dts/qcom/msm8996.dtsi | 310 +++++++++++-
drivers/clk/qcom/Kconfig | 9 +
drivers/clk/qcom/Makefile | 1 +
drivers/clk/qcom/clk-alpha-pll.h | 6 +
drivers/clk/qcom/clk-cpu-8996.c | 538 +++++++++++++++++++++
drivers/perf/Kconfig | 1 +
drivers/perf/qcom_l2_pmu.c | 90 +---
drivers/soc/qcom/Kconfig | 4 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/kryo-l2-accessors.c | 57 +++
include/soc/qcom/kryo-l2-accessors.h | 12 +
12 files changed, 1012 insertions(+), 73 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml
create mode 100644 drivers/clk/qcom/clk-cpu-8996.c
create mode 100644 drivers/soc/qcom/kryo-l2-accessors.c
create mode 100644 include/soc/qcom/kryo-l2-accessors.h
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-03 10:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 10:15 [PATCH v5 0/5] msm8996 CPU scaling support Yassine Oudjana
-- strict thread matches above, loose matches on Subject: below --
2020-07-03 8:49 Loic Poulain
2020-07-03 19:33 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).