From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Wolfram Sang <wsa@kernel.org>, Caleb Connolly <caleb@connolly.tech>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Akash Asthana <akashast@codeaurora.org>,
Mukesh Savaliya <msavaliy@codeaurora.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices
Date: Wed, 2 Dec 2020 10:36:20 -0600 [thread overview]
Message-ID: <X8fChCDbfLfdNoZL@builder.lan> (raw)
In-Reply-To: <20201202153949.GI874@kunai>
On Wed 02 Dec 09:39 CST 2020, Wolfram Sang wrote:
>
> > >> - if (!of_machine_is_compatible("lenovo,yoga-c630"))
> > >> + if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> > >> + !of_machine_is_compatible("oneplus,oneplus6"))
> > > This hack seems to have been working around two separate issues. First
> > > with iommu active the GENI wrappers needs to have their stream mapping
> > > configured. Secondly there was a bug in the transaction setup that was
> > > recently fixed by Doug Anderson.
> > >
> > > So can you please give the following patch a go? I've yet to test it on
> > > the Lenovo machine, but I think it allows us to remove the quirk.
> > >
> > > https://lore.kernel.org/lkml/20201122034149.626045-1-bjorn.andersson@linaro.org/T/#u
>
> Please don't top-post. I fixed it this time.
>
> > It looks like I still have the same issue even with this patch applied.
>
> So we still need your patch, am I reading correctly?
>
With Doug's recent fixes in the DMA handling and the introduction of
proper iommu configuration, which Caleb tested [1], I think we're good
without this on the OnePlus. Caleb, please confirm.
If I understood Caleb's report he saw exactly the same problem that Lee
Jones did that lead to the workaround for the Lenovo Yoga C630, and with
the two changes the i2c-hid keyboard came up nicely on my Yoga. So I
posted [2].
[1] https://lore.kernel.org/linux-arm-msm/3ba39a64-122b-ebe9-04b3-3a23478334a4@connolly.tech/
[2] https://lore.kernel.org/linux-arm-msm/20201124185743.401946-1-bjorn.andersson@linaro.org/
Regards,
Bjorn
next prev parent reply other threads:[~2020-12-02 16:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 16:21 Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
2020-11-12 16:21 ` [PATCH 1/5] drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices Caleb Connolly
2020-11-14 19:58 ` Sam Ravnborg
2020-11-12 16:21 ` [PATCH 2/5] dt-bindings: panel-simple-dsi: add samsung panels for OnePlus 6/T Caleb Connolly
2020-11-14 19:59 ` Sam Ravnborg
2020-11-12 16:21 ` [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices Caleb Connolly
2020-11-16 22:01 ` Pavel Machek
2020-11-16 23:49 ` Caleb Connolly
2020-11-21 17:44 ` Pavel Machek
2020-11-21 4:28 ` Bjorn Andersson
2020-11-12 16:21 ` [PATCH 4/5] dt-bindings: add vendor bindings for OnePlus Caleb Connolly
2020-11-16 14:47 ` Rob Herring
2020-11-16 14:53 ` Rob Herring
2020-11-12 16:22 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices Caleb Connolly
2020-11-17 11:47 ` Akash Asthana
2020-11-22 3:47 ` Bjorn Andersson
2020-11-22 17:59 ` Caleb Connolly
2020-12-02 15:39 ` Wolfram Sang
2020-12-02 16:36 ` Bjorn Andersson [this message]
2020-12-02 20:21 ` Wolfram Sang
2020-11-12 16:28 ` Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8fChCDbfLfdNoZL@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=caleb@connolly.tech \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@codeaurora.org \
--cc=phone-devel@vger.kernel.org \
--cc=wsa@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).