From: Caleb Connolly <caleb@connolly.tech>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices
Date: Mon, 16 Nov 2020 23:49:32 +0000 [thread overview]
Message-ID: <a20145ef-31a1-a72d-2d60-87a5282ace87@connolly.tech> (raw)
In-Reply-To: <20201116220153.GA1003@bug>
On 2020-11-16 22:01, Pavel Machek wrote:
> Hi!
>
>> Add initial support for the OnePlus 6 (enchilada) and 6T (fajita) based
>> on the sdm845-mtp DT. Support includes:
>>
>> * Display panels and Adreno 630
>> * Touch screen support with synaptics rmi4
>> * All remoteprocs start correctly
>> * WLAN / Bluetooth
>> * Volume / power buttons and OnePlus Tri-State switch are functional
>> The tri-state switch is a 3 state mute slider on the side of the phone * USB
>> support, currently forced to peripheral as type C detection isn't functional.
> I have similar switches on my joystick... but I don't believe modelling it as 3 separate
> keys with "macro" keysym is the right way to go.
Hi! I agree that this is a bit of a weird way to model the switch, do
you have any ideas for a better solution?
I'm happy to drop this from the patch for now and come up with a better
method down the line.
Regards,
Caleb
>> + state-top {
>> + label = "Tri-state key top";
>> + linux,code = <KEY_MACRO1>;
>> + interrupt-parent = <&tlmm>;
>> + interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
>> + debounce-interval = <500>;
>> + linux,can-disable;
>> + };
>> +
>> + state-middle {
>> + label = "Tri-state key middle";
>> + linux,code = <KEY_MACRO2>;
>> + interrupt-parent = <&tlmm>;
>> + interrupts = <52 IRQ_TYPE_EDGE_FALLING>;
>> + debounce-interval = <500>;
>> + linux,can-disable;
>> + };
>> +
>> + state-bottom {
>> + label = "Tri-state key bottom";
>> + linux,code = <KEY_MACRO3>;
>> + interrupt-parent = <&tlmm>;
>> + interrupts = <126 IRQ_TYPE_EDGE_FALLING>;
>> + debounce-interval = <500>;
>> + linux,can-disable;
>> + };
> Best regards,
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-11-16 23:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 16:21 Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
2020-11-12 16:21 ` [PATCH 1/5] drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices Caleb Connolly
2020-11-14 19:58 ` Sam Ravnborg
2020-11-12 16:21 ` [PATCH 2/5] dt-bindings: panel-simple-dsi: add samsung panels for OnePlus 6/T Caleb Connolly
2020-11-14 19:59 ` Sam Ravnborg
2020-11-12 16:21 ` [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices Caleb Connolly
2020-11-16 22:01 ` Pavel Machek
2020-11-16 23:49 ` Caleb Connolly [this message]
2020-11-21 17:44 ` Pavel Machek
2020-11-21 4:28 ` Bjorn Andersson
2020-11-12 16:21 ` [PATCH 4/5] dt-bindings: add vendor bindings for OnePlus Caleb Connolly
2020-11-16 14:47 ` Rob Herring
2020-11-16 14:53 ` Rob Herring
2020-11-12 16:22 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices Caleb Connolly
2020-11-17 11:47 ` Akash Asthana
2020-11-22 3:47 ` Bjorn Andersson
2020-11-22 17:59 ` Caleb Connolly
2020-12-02 15:39 ` Wolfram Sang
2020-12-02 16:36 ` Bjorn Andersson
2020-12-02 20:21 ` Wolfram Sang
2020-11-12 16:28 ` Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
-- strict thread matches above, loose matches on Subject: below --
2020-10-07 17:48 Caleb Connolly
2020-10-07 17:49 ` [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices Caleb Connolly
2020-10-07 17:19 Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
2020-10-07 17:20 ` [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20145ef-31a1-a72d-2d60-87a5282ace87@connolly.tech \
--to=caleb@connolly.tech \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=bjorn.andersson@linaro.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).