linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: qcom: add URS Host support for sdm845 ACPI boot
Date: Fri, 15 Jan 2021 08:12:48 -0600	[thread overview]
Message-ID: <YAGi4N26BUdTeIPA@builder.lan> (raw)
In-Reply-To: <87mtxa1gb9.fsf@kernel.org>

On Fri 15 Jan 07:27 CST 2021, Felipe Balbi wrote:

> Hi,
> 
> Shawn Guo <shawn.guo@linaro.org> writes:
> > For sdm845 ACPI boot, the URS (USB Role Switch) node in ACPI DSDT table
> > holds the memory resource, while interrupt resources reside in the child
> > nodes USB0 and UFN0.  It adds USB0 host support by probing URS node,
> > creating platform device for USB0 node, and then retrieve interrupt
> > resources from USB0 platform device.
> 
> just so I understand this: the interrupt was listed under a separate
> device altogether?
> 

Correct, this seems to be the standard structure for a role-switching
usb controller, as shown under "ACPI System configuration" at
https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/usb-dual-role-driver-stack-architecture

Regards,
Bjorn

> Nothing wrong with the patch itself, but just curious.
> 
> -- 
> balbi



  reply	other threads:[~2021-01-15 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  3:50 [PATCH v2] usb: dwc3: qcom: add URS Host support for sdm845 ACPI boot Shawn Guo
2021-01-15  4:02 ` Bjorn Andersson
2021-01-15 13:27 ` Felipe Balbi
2021-01-15 14:12   ` Bjorn Andersson [this message]
2021-01-18 11:28 ` Felipe Balbi
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAGi4N26BUdTeIPA@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=balbi@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).