From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sdm845: fix number of pins in 'gpio-ranges'
Date: Thu, 11 Mar 2021 17:17:20 -0600 [thread overview]
Message-ID: <YEqlANAhGJWZdLVA@builder.lan> (raw)
In-Reply-To: <20210311230924.GX17424@dragon>
On Thu 11 Mar 17:09 CST 2021, Shawn Guo wrote:
> On Thu, Mar 11, 2021 at 10:53:49AM -0600, Bjorn Andersson wrote:
> > On Wed 10 Mar 19:19 CST 2021, Shawn Guo wrote:
> > > Yes, DT stops working because of the mismatch between
> > > msm_pinctrl_soc_data.ngpio and gpio-ranges.
> > >
> >
> > So what you're saying is that when Linus merged the .set_config patch
> > yesterday he broke storage on every single Qualcomm device?
>
> Better than that. Only the ones that have mismatching between
> msm_pinctrl_soc_data.ngpio and gpio-ranges. More specifically, the ones
> that the series are fixing.
>
> I didn't realize this break when I was working on the .set_config change
> for ACPI. It was a surprise when I tested DT later. You can ask Linus
> to drop .set_config patch, if you do not like this break. But I think
> the mismatch issue still needs to be resolved in some way.
>
We're exposing the UFS as a gpio and I think that these patches
therefore are correct, so I've picked them up.
But I don't think we should break backwards compatibility will all
existing DTBs...
Regards,
Bjorn
next prev parent reply other threads:[~2021-03-11 23:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 3:31 [PATCH 0/4] Fix number of pins in 'gpio-ranges' Shawn Guo
2021-03-03 3:31 ` [PATCH 1/4] arm64: dts: qcom: sdm845: fix " Shawn Guo
2021-03-05 21:43 ` Bjorn Andersson
2021-03-06 1:28 ` Shawn Guo
2021-03-06 1:56 ` Bjorn Andersson
2021-03-06 8:00 ` Shawn Guo
2021-03-10 18:22 ` Bjorn Andersson
2021-03-11 1:19 ` Shawn Guo
2021-03-11 16:53 ` Bjorn Andersson
2021-03-11 23:09 ` Shawn Guo
2021-03-11 23:17 ` Bjorn Andersson [this message]
2021-03-15 16:11 ` Linus Walleij
2021-03-03 3:31 ` [PATCH 2/4] arm64: dts: qcom: sm8150: " Shawn Guo
2021-03-03 3:31 ` [PATCH 3/4] arm64: dts: qcom: sm8250: " Shawn Guo
2021-03-03 3:31 ` [PATCH 4/4] arm64: dts: qcom: sm8350: " Shawn Guo
2021-03-11 23:40 ` [PATCH 0/4] Fix " patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEqlANAhGJWZdLVA@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).