From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: Add PMI8996 DTSI file
Date: Mon, 31 May 2021 10:20:46 -0500 [thread overview]
Message-ID: <YLT+zsYBEAcLh+k7@builder.lan> (raw)
In-Reply-To: <20210527170409.667255-1-konrad.dybcio@somainline.org>
On Thu 27 May 12:04 CDT 2021, Konrad Dybcio wrote:
> PMI8996 is *almost* the same hardware as PMI8994, say for some annoyances:
>
> - Boards equipped with PMI8996 now have to include pmic-id (which wasn't the case before)
> - Different qpnp-ibb-discharge-resistor value (will be addressed after LABIBB is introduced)
> - Different inhibit-derating-ua value (will be addressed after BCL is introduced)
> - Different ramp_up_step value (will be addressed after [if?] QPNP Flash LED is introduced)
>
If I am to support a device that has a pmi8996, I will go
#include "pmi8996.dtsi"
and wonder why it didn't work.
But, I do see the validity in your argumentation in the previous
revision so I won't object. But I really would like you to describe in
the commit message why this is different from what people would expect
to find.
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> arch/arm64/boot/dts/qcom/pmi8996.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pmi8996.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8996.dtsi b/arch/arm64/boot/dts/qcom/pmi8996.dtsi
> new file mode 100644
> index 000000000000..31b47209e261
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmi8996.dtsi
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: GPL-2.0
And BSD please :)
Regards,
Bjorn
> +/*
> + * Copyright (c) 2021, Konrad Dybcio <konrad.dybcio@somainline.org>
> + */
> +
> + /*
> + * PMI8996 is a slight modification of PMI8994 with
> + * some notable changes, like being the first PMIC
> + * whose the bootloader has to check to continue booting
> + * and a change to a LABIBB parameter.
> + */
> +
> +/ {
> + qcom,pmic-id = <0x20009 0x10013 0 0>;
> +};
> --
> 2.31.1
>
prev parent reply other threads:[~2021-05-31 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 17:04 [PATCH v2 1/3] arm64: dts: qcom: Add PMI8996 DTSI file Konrad Dybcio
2021-05-27 17:04 ` [PATCH v2 2/3] arm64: dts: qcom: Add MSM8996v3.0 " Konrad Dybcio
2021-05-27 17:04 ` [PATCH v2 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance/XZ/XZs Konrad Dybcio
2021-05-31 15:16 ` Bjorn Andersson
2021-05-31 15:20 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLT+zsYBEAcLh+k7@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).