From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance/XZ/XZs
Date: Mon, 31 May 2021 10:16:47 -0500 [thread overview]
Message-ID: <YLT934Geo4KOY7XU@builder.lan> (raw)
In-Reply-To: <20210527170409.667255-3-konrad.dybcio@somainline.org>
On Thu 27 May 12:04 CDT 2021, Konrad Dybcio wrote:
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
[..]
> +&pm8994_gpios {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pm8994_gpios_defaults>;
> + gpio-line-names =
> + "NC",
> + "VOL_DOWN_N",
> + "VOL_UP_N",
> + "SNAPSHOT_N",
> + "FOCUS_N",
> + "NC",
> + "NFC_VEN",
> + "NC",
> + "NC",
> + "NC",
> + "NC",
> + "NC",
> + "EAR_EN",
> + "NC",
> + "PM_DIVCLK1",
> + "PMI_CLK",
> + "NC",
> + "WL_SLEEP_CLK",
> + "NC",
> + "PMIC_SPON",
> + "UIM_BATT_ALARM",
> + "PMK_SLEEP_CLK";
> +
> + /*
> + * We don't yet know for sure which GPIOs are of our interest, but what
> + * we do know is that if a vendor sets the pins to a non-default state, there's
> + * probably a reason for it, and just to be on the safe side, we follow suit.
> + */
> + pm8994_gpios_defaults: pm8994-gpios-default-state {
> + pm8994_gpio1_n: pm8994-gpio1-nc {
Is there a reason for keeping pm8994_gpios_defaults? I presume you won't
be able to select it, because the associated pins are already busy?
> + pins = "gpio1";
> + function = PMIC_GPIO_FUNC_NORMAL;
> + drive-push-pull;
> + bias-high-impedance;
> + };
> +
[..]
> +&pmi8994_gpios {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pmi8994_gpios_defaults>;
> +
> + gpio-line-names =
> + "VIB_LDO_EN",
> + "NC",
> + "NC",
> + "NC",
> + "NC",
> + "NC",
> + "NC",
> + "NC",
> + "USB_SWITCH_SEL",
> + "NC";
> +
> + pmi8994_gpios_defaults: pmi8994-gpios-default-state {
> + pmi8994_vib_ldo_en: vib-ldo-en-gpio {
Ditto.
> + pins = "gpio1";
> + function = PMIC_GPIO_FUNC_NORMAL;
> + drive-push-pull;
> + output-low;
> + bias-disable;
> + power-source = <PM8994_GPIO_S4>;
> + };
Regards,
Bjorn
next prev parent reply other threads:[~2021-05-31 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 17:04 [PATCH v2 1/3] arm64: dts: qcom: Add PMI8996 DTSI file Konrad Dybcio
2021-05-27 17:04 ` [PATCH v2 2/3] arm64: dts: qcom: Add MSM8996v3.0 " Konrad Dybcio
2021-05-27 17:04 ` [PATCH v2 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance/XZ/XZs Konrad Dybcio
2021-05-31 15:16 ` Bjorn Andersson [this message]
2021-05-31 15:20 ` [PATCH v2 1/3] arm64: dts: qcom: Add PMI8996 DTSI file Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLT934Geo4KOY7XU@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).