* [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion
@ 2021-06-16 17:42 Sibi Sankar
2021-06-16 20:26 ` Bjorn Andersson
2021-06-18 4:18 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Sibi Sankar @ 2021-06-16 17:42 UTC (permalink / raw)
To: bjorn.andersson, jassisinghbrar, manivannan.sadhasivam
Cc: agross, rananta, vnkgutta, linux-kernel, linux-arm-msm,
Sibi Sankar, stable
Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by
setting the channel private data to NULL on mbox shutdown.
Err Logs:
remoteproc: MBA booted without debug policy, loading mpss
remoteproc: glink-edge: failed to acquire IPC channel
remoteproc: failed to probe subdevices for remoteproc: -16
Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC")
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Cc: stable@vger.kernel.org
---
drivers/mailbox/qcom-ipcc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
index 2d13c72944c6..584700cd1585 100644
--- a/drivers/mailbox/qcom-ipcc.c
+++ b/drivers/mailbox/qcom-ipcc.c
@@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data)
return 0;
}
+static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan)
+{
+ chan->con_priv = NULL;
+}
+
static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox,
const struct of_phandle_args *ph)
{
@@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox,
static const struct mbox_chan_ops ipcc_mbox_chan_ops = {
.send_data = qcom_ipcc_mbox_send_data,
+ .shutdown = qcom_ipcc_mbox_shutdown,
};
static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion
2021-06-16 17:42 [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion Sibi Sankar
@ 2021-06-16 20:26 ` Bjorn Andersson
2021-06-18 4:18 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-06-16 20:26 UTC (permalink / raw)
To: Sibi Sankar
Cc: jassisinghbrar, manivannan.sadhasivam, agross, rananta, vnkgutta,
linux-kernel, linux-arm-msm, stable
On Wed 16 Jun 12:42 CDT 2021, Sibi Sankar wrote:
> Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by
> setting the channel private data to NULL on mbox shutdown.
>
> Err Logs:
> remoteproc: MBA booted without debug policy, loading mpss
> remoteproc: glink-edge: failed to acquire IPC channel
> remoteproc: failed to probe subdevices for remoteproc: -16
>
> Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC")
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Cc: stable@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/mailbox/qcom-ipcc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
> index 2d13c72944c6..584700cd1585 100644
> --- a/drivers/mailbox/qcom-ipcc.c
> +++ b/drivers/mailbox/qcom-ipcc.c
> @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data)
> return 0;
> }
>
> +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan)
> +{
> + chan->con_priv = NULL;
> +}
> +
> static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox,
> const struct of_phandle_args *ph)
> {
> @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox,
>
> static const struct mbox_chan_ops ipcc_mbox_chan_ops = {
> .send_data = qcom_ipcc_mbox_send_data,
> + .shutdown = qcom_ipcc_mbox_shutdown,
> };
>
> static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion
2021-06-16 17:42 [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion Sibi Sankar
2021-06-16 20:26 ` Bjorn Andersson
@ 2021-06-18 4:18 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-06-18 4:18 UTC (permalink / raw)
To: Sibi Sankar
Cc: bjorn.andersson, jassisinghbrar, agross, rananta, vnkgutta,
linux-kernel, linux-arm-msm, stable
On Wed, Jun 16, 2021 at 11:12:58PM +0530, Sibi Sankar wrote:
> Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by
> setting the channel private data to NULL on mbox shutdown.
>
> Err Logs:
> remoteproc: MBA booted without debug policy, loading mpss
> remoteproc: glink-edge: failed to acquire IPC channel
> remoteproc: failed to probe subdevices for remoteproc: -16
>
> Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC")
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> Cc: stable@vger.kernel.org
> ---
> drivers/mailbox/qcom-ipcc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
> index 2d13c72944c6..584700cd1585 100644
> --- a/drivers/mailbox/qcom-ipcc.c
> +++ b/drivers/mailbox/qcom-ipcc.c
> @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data)
> return 0;
> }
>
> +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan)
> +{
> + chan->con_priv = NULL;
> +}
> +
> static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox,
> const struct of_phandle_args *ph)
> {
> @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox,
>
> static const struct mbox_chan_ops ipcc_mbox_chan_ops = {
> .send_data = qcom_ipcc_mbox_send_data,
> + .shutdown = qcom_ipcc_mbox_shutdown,
> };
>
> static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-18 4:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 17:42 [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion Sibi Sankar
2021-06-16 20:26 ` Bjorn Andersson
2021-06-18 4:18 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).