linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A
@ 2021-06-25  4:50 Judy Hsiao
  2021-06-25 15:26 ` Matthias Kaehlcke
  2021-07-21 15:27 ` Doug Anderson
  0 siblings, 2 replies; 4+ messages in thread
From: Judy Hsiao @ 2021-06-25  4:50 UTC (permalink / raw)
  To: Andy Gross
  Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, dgreid,
	cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
	linux-arm-msm, devicetree, linux-kernel, Judy Hsiao

Use max98360a dts node to correctly describe the hardware.

Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 77ae7561d436..38f1fababc33 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -247,8 +247,8 @@ pen_insert: pen-insert {
 		};
 	};
 
-	max98357a: audio-codec-0 {
-		compatible = "maxim,max98357a";
+	max98360a: audio-codec-0 {
+		compatible = "maxim,max98360a";
 		pinctrl-names = "default";
 		pinctrl-0 = <&amp_en>;
 		sdmode-gpios = <&tlmm 23 GPIO_ACTIVE_HIGH>;
@@ -311,7 +311,7 @@ cpu {
 			};
 
 			sound_multimedia1_codec: codec {
-				sound-dai = <&max98357a>;
+				sound-dai = <&max98360a>;
 			};
 		};
 	};
-- 
2.32.0.93.g670b81a890-goog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A
  2021-06-25  4:50 [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A Judy Hsiao
@ 2021-06-25 15:26 ` Matthias Kaehlcke
  2021-07-21 15:27 ` Doug Anderson
  1 sibling, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2021-06-25 15:26 UTC (permalink / raw)
  To: Judy Hsiao
  Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
	dianders, dgreid, cychiang, judyhsiao, tzungbi, swboyd,
	linux-arm-kernel, linux-arm-msm, devicetree, linux-kernel

On Fri, Jun 25, 2021 at 12:50:10PM +0800, Judy Hsiao wrote:
> Use max98360a dts node to correctly describe the hardware.
> 
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>

Confirmed that this matches the schematics. Apparently 'max98357a' was
used initially because 'max98360a' wasn't supported yet in the kernel
that was used for development and ships on trogdor devices (v5.4).

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A
  2021-06-25  4:50 [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A Judy Hsiao
  2021-06-25 15:26 ` Matthias Kaehlcke
@ 2021-07-21 15:27 ` Doug Anderson
  2021-07-21 16:09   ` Bjorn Andersson
  1 sibling, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2021-07-21 15:27 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Rob Herring, Srini Kandagatla, Dylan Reid,
	Jimmy Cheng-Yi Chiang, Judy Hsiao, Tzung-Bi Shih, Stephen Boyd,
	Linux ARM, linux-arm-msm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
	Judy Hsiao

Hi Bjorn,

On Thu, Jun 24, 2021 at 9:50 PM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> Use max98360a dts node to correctly describe the hardware.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I noticed that you landed several dts changes recently (thanks!) but I
didn't see this one. Was there a problem with it, or did it just slip
through the cracks?

Thanks!

-Doug

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A
  2021-07-21 15:27 ` Doug Anderson
@ 2021-07-21 16:09   ` Bjorn Andersson
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-07-21 16:09 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Andy Gross, Rob Herring, Srini Kandagatla, Dylan Reid,
	Jimmy Cheng-Yi Chiang, Judy Hsiao, Tzung-Bi Shih, Stephen Boyd,
	Linux ARM, linux-arm-msm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
	Judy Hsiao

On Wed 21 Jul 10:27 CDT 2021, Doug Anderson wrote:

> Hi Bjorn,
> 
> On Thu, Jun 24, 2021 at 9:50 PM Judy Hsiao <judyhsiao@chromium.org> wrote:
> >
> > Use max98360a dts node to correctly describe the hardware.
> >
> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> I noticed that you landed several dts changes recently (thanks!) but I
> didn't see this one. Was there a problem with it, or did it just slip
> through the cracks?
> 

No problem, it just sat there nicely waiting in the backlog. It's now
applied and pushed out.

Thanks,
Bjorn

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-21 16:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25  4:50 [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A Judy Hsiao
2021-06-25 15:26 ` Matthias Kaehlcke
2021-07-21 15:27 ` Doug Anderson
2021-07-21 16:09   ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).