From: Rob Herring <robh@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Aleksander Morgado <aleksander@aleksander.es>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Subject: Re: [PATCH net-next v2 3/4] dt-bindings: net: Add schema for Qualcomm BAM-DMUX
Date: Mon, 18 Oct 2021 15:22:25 -0500 [thread overview]
Message-ID: <YW3XgaiT2jBv4D+L@robh.at.kernel.org> (raw)
In-Reply-To: <20211011141733.3999-4-stephan@gerhold.net>
On Mon, Oct 11, 2021 at 04:17:35PM +0200, Stephan Gerhold wrote:
> The BAM Data Multiplexer provides access to the network data channels of
> modems integrated into many older Qualcomm SoCs, e.g. Qualcomm MSM8916 or
> MSM8974. It is built using a simple protocol layer on top of a DMA engine
> (Qualcomm BAM) and bidirectional interrupts to coordinate power control.
>
> The device tree node combines the incoming interrupt with the outgoing
> interrupts (smem-states) as well as the two DMA channels, which allows
> the BAM-DMUX driver to request all necessary resources.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> Changes since RFC: None.
> ---
> .../bindings/net/qcom,bam-dmux.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
> new file mode 100644
> index 000000000000..33e125e70cb4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/qcom,bam-dmux.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm BAM Data Multiplexer
> +
> +maintainers:
> + - Stephan Gerhold <stephan@gerhold.net>
> +
> +description: |
> + The BAM Data Multiplexer provides access to the network data channels
> + of modems integrated into many older Qualcomm SoCs, e.g. Qualcomm MSM8916
> + or MSM8974. It is built using a simple protocol layer on top of a DMA engine
> + (Qualcomm BAM DMA) and bidirectional interrupts to coordinate power control.
> +
> +properties:
> + compatible:
> + const: qcom,bam-dmux
Is this block the same on every SoC? It needs to be SoC specific.
> +
> + interrupts:
> + description:
> + Interrupts used by the modem to signal the AP.
> + Both interrupts must be declared as IRQ_TYPE_EDGE_BOTH.
> + items:
> + - description: Power control
> + - description: Power control acknowledgment
> +
> + interrupt-names:
> + items:
> + - const: pc
> + - const: pc-ack
> +
> + qcom,smem-states:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: State bits used by the AP to signal the modem.
> + items:
> + - description: Power control
> + - description: Power control acknowledgment
> +
> + qcom,smem-state-names:
> + description: Names for the state bits used by the AP to signal the modem.
> + items:
> + - const: pc
> + - const: pc-ack
> +
> + dmas:
> + items:
> + - description: TX DMA channel phandle
> + - description: RX DMA channel phandle
> +
> + dma-names:
> + items:
> + - const: tx
> + - const: rx
> +
> +required:
> + - compatible
> + - interrupts
> + - interrupt-names
> + - qcom,smem-states
> + - qcom,smem-state-names
> + - dmas
> + - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + mpss: remoteproc {
> + bam-dmux {
> + compatible = "qcom,bam-dmux";
> +
> + interrupt-parent = <&modem_smsm>;
> + interrupts = <1 IRQ_TYPE_EDGE_BOTH>, <11 IRQ_TYPE_EDGE_BOTH>;
> + interrupt-names = "pc", "pc-ack";
> +
> + qcom,smem-states = <&apps_smsm 1>, <&apps_smsm 11>;
> + qcom,smem-state-names = "pc", "pc-ack";
> +
> + dmas = <&bam_dmux_dma 4>, <&bam_dmux_dma 5>;
> + dma-names = "tx", "rx";
> + };
> + };
> --
> 2.33.0
>
>
next prev parent reply other threads:[~2021-10-18 20:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 14:17 [PATCH net-next v2 0/4] net: wwan: Add Qualcomm BAM-DMUX WWAN network driver Stephan Gerhold
2021-10-11 14:17 ` [PATCH net-next v2 1/4] dt-bindings: dmaengine: bam_dma: Add "powered remotely" mode Stephan Gerhold
2021-10-18 6:17 ` Vinod Koul
2021-10-18 10:29 ` Stephan Gerhold
2021-10-18 11:34 ` Bhupesh Sharma
2021-10-18 12:56 ` Stephan Gerhold
2021-10-18 16:41 ` Bhupesh Sharma
2021-10-11 14:17 ` [PATCH net-next v2 2/4] dmaengine: qcom: " Stephan Gerhold
2021-10-11 17:39 ` Bjorn Andersson
2021-10-11 18:06 ` Stephan Gerhold
2021-10-11 14:17 ` [PATCH net-next v2 3/4] dt-bindings: net: Add schema for Qualcomm BAM-DMUX Stephan Gerhold
2021-10-18 20:22 ` Rob Herring [this message]
2021-10-19 7:03 ` Stephan Gerhold
2021-10-19 13:19 ` Rob Herring
2021-10-19 13:31 ` Stephan Gerhold
2021-10-11 14:17 ` [PATCH net-next v2 4/4] net: wwan: Add Qualcomm BAM-DMUX WWAN network driver Stephan Gerhold
2021-10-11 14:51 ` Stephan Gerhold
2021-10-12 7:55 ` Loic Poulain
2021-10-12 8:43 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW3XgaiT2jBv4D+L@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=aleksander@aleksander.es \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).