From: Vinod Koul <vkoul@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jonathan Marek <jonathan@marek.ca>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC
Date: Tue, 19 Oct 2021 19:37:51 +0530 [thread overview]
Message-ID: <YW7RNz/9vd/XS0+O@matsya> (raw)
In-Reply-To: <c9c77691-f6e8-576c-7e2d-a87295b13ba7@linaro.org>
On 14-10-21, 17:40, Dmitry Baryshkov wrote:
> On 07/10/2021 10:08, Vinod Koul wrote:
> > +static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc,
> > + struct msm_display_dsc_config *dsc, u32 mode)
> > +{
> > + struct dpu_hw_blk_reg_map *c = &hw_dsc->hw;
> > + u32 data, lsb, bpp;
> > + u32 initial_lines = dsc->initial_lines;
> > + bool is_cmd_mode = !(mode & BIT(2));
>
> DSC_MODE_VIDEO
Updated
> > +static void dpu_hw_dsc_config_thresh(struct dpu_hw_dsc *hw_dsc,
> > + struct msm_display_dsc_config *dsc)
>
> I thought that it might make sense to pass just drm_dsc_rc_range_parameters
> here, but it's a matter of personal preference. I won't insist on doing
> that.
This is called from encoder, so prefer not to have encoder invoke
dsc->drm->rc_range_params
So will keep this.
--
~Vinod
next prev parent reply other threads:[~2021-10-19 14:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 7:08 [PATCH v2 00/11] drm/msm: Add Display Stream Compression Support Vinod Koul
2021-10-07 7:08 ` [PATCH v2 01/11] drm/msm/dsi: add support for dsc data Vinod Koul
2021-10-25 14:43 ` Dmitry Baryshkov
2021-10-07 7:08 ` [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC Vinod Koul
2021-10-14 14:40 ` Dmitry Baryshkov
2021-10-19 14:07 ` Vinod Koul [this message]
2021-10-07 7:08 ` [PATCH v2 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul
2021-10-14 13:30 ` Dmitry Baryshkov
2021-10-07 7:08 ` [PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM Vinod Koul
2021-10-14 14:11 ` Dmitry Baryshkov
2021-10-19 15:30 ` Vinod Koul
2021-10-19 15:52 ` Dmitry Baryshkov
2021-10-19 16:25 ` Vinod Koul
2021-10-07 7:08 ` [PATCH v2 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Vinod Koul
2021-10-14 13:33 ` Dmitry Baryshkov
2021-10-07 7:08 ` [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d Vinod Koul
2021-10-14 13:41 ` Dmitry Baryshkov
2021-10-14 13:50 ` Dmitry Baryshkov
2021-10-20 6:57 ` Vinod Koul
2021-10-25 14:40 ` Dmitry Baryshkov
2021-10-25 16:10 ` Vinod Koul
2021-10-25 18:33 ` Dmitry Baryshkov
2021-10-07 7:08 ` [PATCH v2 07/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl Vinod Koul
2021-10-14 14:06 ` Dmitry Baryshkov
2021-10-20 9:19 ` Vinod Koul
2021-10-07 7:08 ` [PATCH v2 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder Vinod Koul
2021-10-25 14:44 ` Dmitry Baryshkov
2021-10-07 7:08 ` [PATCH v2 09/11] drm/msm/disp/dpu1: Add support for DSC in topology Vinod Koul
2021-10-14 14:13 ` Dmitry Baryshkov
2021-10-25 14:37 ` Dmitry Baryshkov
2021-10-25 16:11 ` Vinod Koul
2021-10-07 7:08 ` [PATCH v2 10/11] drm/msm/dsi: Add support for DSC configuration Vinod Koul
2021-10-14 23:18 ` Dmitry Baryshkov
2021-10-20 11:53 ` Vinod Koul
2021-10-07 7:09 ` [PATCH v2 11/11] drm/msm/dsi: Pass DSC params to drm_panel Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW7RNz/9vd/XS0+O@matsya \
--to=vkoul@kernel.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).