From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
rdunlap@infradead.org, gregkh@linuxfoundation.org,
bjorn.andersson@linaro.org, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
wcheng@codeaurora.org
Subject: Re: [RESEND PATCH v2 4/7] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema
Date: Thu, 28 Oct 2021 15:39:13 -0500 [thread overview]
Message-ID: <YXsKcWB9ctkmawju@robh.at.kernel.org> (raw)
In-Reply-To: <20211028164941.831918-5-bryan.odonoghue@linaro.org>
On Thu, Oct 28, 2021 at 05:49:38PM +0100, Bryan O'Donoghue wrote:
> Add a YAML binding for the power-delivery PHY silicon interface inside
> Qualcomm's pm8150b hardware block.
>
> The pdphy driver operates with a type-c driver inside of a high level
> single TCPM device to provide overall TCPM functionality.
Same comments for this one...
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/usb/qcom,pmic-pdphy.yaml | 115 ++++++++++++++++++
> 1 file changed, 115 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml
> new file mode 100644
> index 0000000000000..9110f6203b87f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml
> @@ -0,0 +1,115 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/qcom,pmic-pdphy.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm PMIC based USB PDPHY driver
> +
> +maintainers:
> + - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> +
> +description: |
> + Qualcomm PMIC Power Delivery PHY driver
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pm8150b-pdphy
> +
> + reg:
> + maxItems: 1
> + description: PDPHY base address
> +
> + interrupts:
> + items:
> + - description: Sig TX - transmitted reset signal
> + - description: Sig RX - received reset signal
> + - description: TX completion
> + - description: RX completion
> + - description: TX fail
> + - description: TX discgard
> + - description: RX discgard
> + - description: Fast Role Swap event
> +
> + interrupt-names:
> + items:
> + - const: pmic-pdphy-sig-tx
> + - const: pmic-pdphy-sig-rx
> + - const: pmic-pdphy-msg-tx
> + - const: pmic-pdphy-msg-rx
> + - const: pmic-pdphy-msg-tx-failed
> + - const: pmic-pdphy-msg-tx-discarded
> + - const: pmic-pdphy-msg-rx-discarded
> + - const: pmic-pdphy-fr-swap
> +
> + ports:
> + description: Remote endpoint connections
> + $ref: /connector/usb-connector.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + description: Remote endpoints for the TCPM driver
> +
> + required:
> + - port@0
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/usb/typec/tcpm/qcom,pmic-usb-pdphy.h>
> +
> + pm8150b {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm8150b_pdphy: pdphy@1700 {
> + compatible = "qcom,pm8150b-pdphy";
> + reg = <0x1700>;
> + interrupts = <0x2 0x17 PMIC_PDPHY_SIG_TX_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_SIG_RX_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_MSG_TX_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_MSG_RX_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_MSG_TX_FAIL_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_MSG_TX_DISCARD_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_MSG_RX_DISCARD_IRQ
> + IRQ_TYPE_EDGE_RISING>,
> + <0x2 0x17 PMIC_PDPHY_FR_SWAP_IRQ
> + IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "pmic-pdphy-sig-tx",
> + "pmic-pdphy-sig-rx",
> + "pmic-pdphy-msg-tx",
> + "pmic-pdphy-msg-rx",
> + "pmic-pdphy-msg-tx-failed",
> + "pmic-pdphy-msg-tx-discarded",
> + "pmic-pdphy-msg-rx-discarded",
> + "pmic-pdphy-fr-swap";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + pmic_pdphy: endpoint {
> + remote-endpoint = <&pmic_tcpm_pdphy>;
> + };
> + };
> + };
> + };
> + };
> +...
> --
> 2.33.0
>
>
next prev parent reply other threads:[~2021-10-28 20:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 16:49 [RESEND PATCH v2 0/7] Add pm8150b TPCM driver Bryan O'Donoghue
2021-10-28 16:49 ` [RESEND PATCH v2 1/7] dt-bindings: usb: Add qcom,pmic-usb-typec dt-binding header Bryan O'Donoghue
2021-10-28 16:49 ` [RESEND PATCH v2 2/7] dt-bindings: usb: Add Qualcomm PMIC type C controller YAML schema Bryan O'Donoghue
2021-10-28 19:08 ` Rob Herring
2021-10-28 20:38 ` Rob Herring
2021-10-28 16:49 ` [RESEND PATCH v2 3/7] dt-bindings: usb: Add qcom,pmic-usb-pdphy dt-binding header Bryan O'Donoghue
2021-10-28 16:49 ` [RESEND PATCH v2 4/7] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema Bryan O'Donoghue
2021-10-28 19:08 ` Rob Herring
2021-10-28 20:39 ` Rob Herring [this message]
2021-10-28 16:49 ` [RESEND PATCH v2 5/7] dt-bindings: usb: Add Qualcomm PMIC TCPM " Bryan O'Donoghue
2021-10-28 20:43 ` Rob Herring
2021-10-28 21:46 ` Bryan O'Donoghue
2021-10-28 21:52 ` Bryan O'Donoghue
2021-10-28 16:49 ` [RESEND PATCH v2 6/7] usb: typec: qcom: Remove standalone qcom pm8150b typec driver Bryan O'Donoghue
2021-10-28 16:49 ` [RESEND PATCH v2 7/7] usb: typec: qcom: Add a pm8150b TCPM driver Bryan O'Donoghue
2021-10-29 16:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXsKcWB9ctkmawju@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).