[PATCH 1/4] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[PATCH 1/4] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Dominik Kobinski]

Add support for pm8226 SPMI GPIOs. The PMIC features
8 GPIOs, with no holes inbetween.

Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 5283d5e9e8bc..0f0102f38cbb 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1159,6 +1159,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmc8180c-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8226-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
-- 
2.34.0

[PATCH 2/4] dt-bindings: pinctrl: qcom: pmic-gpio: Document pm8226 compatible

[Dominik Kobinski]

Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 8952b4cc1262..293f480ad0b4 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -30,6 +30,7 @@ properties:
           - qcom,pm8058-gpio
           - qcom,pm8150-gpio
           - qcom,pm8150b-gpio
+          - qcom,pm8226-gpio
           - qcom,pm8350-gpio
           - qcom,pm8350b-gpio
           - qcom,pm8350c-gpio
-- 
2.34.0

[PATCH 3/4] dt-bindings: regulator: qcom: spmi-regulator: Document pm8226 compatible

[Dominik Kobinski]

Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
---
 .../devicetree/bindings/regulator/qcom,spmi-regulator.txt        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
index 2b544059e029..c2a39b121b1b 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
@@ -6,6 +6,7 @@ Qualcomm SPMI Regulators
 	Definition: must be one of:
 			"qcom,pm8004-regulators"
 			"qcom,pm8005-regulators"
+			"qcom,pm8226-regulators"
 			"qcom,pm8841-regulators"
 			"qcom,pm8916-regulators"
 			"qcom,pm8941-regulators"
-- 
2.34.0

[PATCH 4/4] regulator: qcom_spmi: Add pm8226 regulators

[Dominik Kobinski]

The PM8226 PMIC is very often seen on
MSM8x26 boards.

Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
---
 drivers/regulator/qcom_spmi-regulator.c | 39 +++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index 41424a3366d0..02bfce981150 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -1895,6 +1895,44 @@ static const struct spmi_regulator_data pm8941_regulators[] = {
 	{ }
 };
 
+static const struct spmi_regulator_data pm8226_regulators[] = {
+	{ "s1", 0x1400, "vdd_s1", },
+	{ "s2", 0x1700, "vdd_s2", },
+	{ "s3", 0x1a00, "vdd_s3", },
+	{ "s4", 0x1d00, "vdd_s4", },
+	{ "s5", 0x2000, "vdd_s5", },
+	{ "l1", 0x4000, "vdd_l1_l2_l4_l5", },
+	{ "l2", 0x4100, "vdd_l1_l2_l4_l5", },
+	{ "l3", 0x4200, "vdd_l3_l24_l26", },
+	{ "l4", 0x4300, "vdd_l1_l2_l4_l5", },
+	{ "l5", 0x4400, "vdd_l1_l2_l4_l5", },
+	{ "l6", 0x4500, "vdd_l6_l7_l8_l9_l27", },
+	{ "l7", 0x4600, "vdd_l6_l7_l8_l9_l27", },
+	{ "l8", 0x4700, "vdd_l6_l7_l8_l9_l27", },
+	{ "l9", 0x4800, "vdd_l6_l7_l8_l9_l27", },
+	{ "l10", 0x4900, "vdd_l10_l11_l13", },
+	{ "l11", 0x4a00, "vdd_l10_l11_l13", },
+	{ "l12", 0x4b00, "vdd_l12_l14", },
+	{ "l13", 0x4c00, "vdd_l10_l11_l13", },
+	{ "l14", 0x4d00, "vdd_l12_l14", },
+	{ "l15", 0x4e00, "vdd_l15_l16_l17_l18", },
+	{ "l16", 0x4f00, "vdd_l15_l16_l17_l18", },
+	{ "l17", 0x5000, "vdd_l15_l16_l17_l18", },
+	{ "l18", 0x5100, "vdd_l15_l16_l17_l18", },
+	{ "l19", 0x5200, "vdd_l19_l20_l21_l22_l23_l28", },
+	{ "l20", 0x5300, "vdd_l19_l20_l21_l22_l23_l28", },
+	{ "l21", 0x5400, "vdd_l19_l20_l21_l22_l23_l28", },
+	{ "l22", 0x5500, "vdd_l19_l20_l21_l22_l23_l28", },
+	{ "l23", 0x5600, "vdd_l19_l20_l21_l22_l23_l28", },
+	{ "l24", 0x5700, "vdd_l3_l24_l26", },
+	{ "l25", 0x5800, "vdd_l25", },
+	{ "l26", 0x5900, "vdd_l3_l24_l26", },
+	{ "l27", 0x5a00, "vdd_l6_l7_l8_l9_l27", },
+	{ "l28", 0x5b00, "vdd_l19_l20_l21_l22_l23_l28", },
+	{ "lvs1", 0x8000, "vdd_lvs1", },
+	{ }
+};
+
 static const struct spmi_regulator_data pm8841_regulators[] = {
 	{ "s1", 0x1400, "vdd_s1", },
 	{ "s2", 0x1700, "vdd_s2", NULL, 0x1c08 },
@@ -2095,6 +2133,7 @@ static const struct spmi_regulator_data pms405_regulators[] = {
 static const struct of_device_id qcom_spmi_regulator_match[] = {
 	{ .compatible = "qcom,pm8004-regulators", .data = &pm8004_regulators },
 	{ .compatible = "qcom,pm8005-regulators", .data = &pm8005_regulators },
+	{ .compatible = "qcom,pm8226-regulators", .data = &pm8226_regulators },
 	{ .compatible = "qcom,pm8841-regulators", .data = &pm8841_regulators },
 	{ .compatible = "qcom,pm8916-regulators", .data = &pm8916_regulators },
 	{ .compatible = "qcom,pm8941-regulators", .data = &pm8941_regulators },
-- 
2.34.0

Re: [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Bjorn Andersson]

On Tue 23 Nov 09:41 PST 2021, Dominik Kobinski wrote:

> Add support for pm8226 SPMI GPIOs. The PMIC features
> 8 GPIOs, with no holes inbetween.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 5283d5e9e8bc..0f0102f38cbb 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1159,6 +1159,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>  	/* pm8150l has 12 GPIOs with holes on 7 */
>  	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
>  	{ .compatible = "qcom,pmc8180c-gpio", .data = (void *) 12 },
> +	{ .compatible = "qcom,pm8226-gpio", .data = (void *) 8 },
>  	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
>  	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
>  	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
> -- 
> 2.34.0
> 

Re: [PATCH 4/4] regulator: qcom_spmi: Add pm8226 regulators

[Bjorn Andersson]

On Tue 23 Nov 10:11 PST 2021, Dominik Kobinski wrote:

> The PM8226 PMIC is very often seen on
> MSM8x26 boards.

The appropriate width of a commit message is 72 chars, so there's no
need to break this line.

> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
> ---
>  drivers/regulator/qcom_spmi-regulator.c | 39 +++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
> index 41424a3366d0..02bfce981150 100644
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -1895,6 +1895,44 @@ static const struct spmi_regulator_data pm8941_regulators[] = {
>  	{ }
>  };
>  
> +static const struct spmi_regulator_data pm8226_regulators[] = {
> +	{ "s1", 0x1400, "vdd_s1", },
> +	{ "s2", 0x1700, "vdd_s2", },
> +	{ "s3", 0x1a00, "vdd_s3", },
> +	{ "s4", 0x1d00, "vdd_s4", },
> +	{ "s5", 0x2000, "vdd_s5", },
> +	{ "l1", 0x4000, "vdd_l1_l2_l4_l5", },
> +	{ "l2", 0x4100, "vdd_l1_l2_l4_l5", },
> +	{ "l3", 0x4200, "vdd_l3_l24_l26", },
> +	{ "l4", 0x4300, "vdd_l1_l2_l4_l5", },
> +	{ "l5", 0x4400, "vdd_l1_l2_l4_l5", },
> +	{ "l6", 0x4500, "vdd_l6_l7_l8_l9_l27", },
> +	{ "l7", 0x4600, "vdd_l6_l7_l8_l9_l27", },
> +	{ "l8", 0x4700, "vdd_l6_l7_l8_l9_l27", },
> +	{ "l9", 0x4800, "vdd_l6_l7_l8_l9_l27", },
> +	{ "l10", 0x4900, "vdd_l10_l11_l13", },
> +	{ "l11", 0x4a00, "vdd_l10_l11_l13", },
> +	{ "l12", 0x4b00, "vdd_l12_l14", },
> +	{ "l13", 0x4c00, "vdd_l10_l11_l13", },
> +	{ "l14", 0x4d00, "vdd_l12_l14", },
> +	{ "l15", 0x4e00, "vdd_l15_l16_l17_l18", },
> +	{ "l16", 0x4f00, "vdd_l15_l16_l17_l18", },
> +	{ "l17", 0x5000, "vdd_l15_l16_l17_l18", },
> +	{ "l18", 0x5100, "vdd_l15_l16_l17_l18", },
> +	{ "l19", 0x5200, "vdd_l19_l20_l21_l22_l23_l28", },
> +	{ "l20", 0x5300, "vdd_l19_l20_l21_l22_l23_l28", },
> +	{ "l21", 0x5400, "vdd_l19_l20_l21_l22_l23_l28", },
> +	{ "l22", 0x5500, "vdd_l19_l20_l21_l22_l23_l28", },
> +	{ "l23", 0x5600, "vdd_l19_l20_l21_l22_l23_l28", },
> +	{ "l24", 0x5700, "vdd_l3_l24_l26", },
> +	{ "l25", 0x5800, "vdd_l25", },
> +	{ "l26", 0x5900, "vdd_l3_l24_l26", },
> +	{ "l27", 0x5a00, "vdd_l6_l7_l8_l9_l27", },
> +	{ "l28", 0x5b00, "vdd_l19_l20_l21_l22_l23_l28", },
> +	{ "lvs1", 0x8000, "vdd_lvs1", },
> +	{ }
> +};
> +
>  static const struct spmi_regulator_data pm8841_regulators[] = {
>  	{ "s1", 0x1400, "vdd_s1", },
>  	{ "s2", 0x1700, "vdd_s2", NULL, 0x1c08 },
> @@ -2095,6 +2133,7 @@ static const struct spmi_regulator_data pms405_regulators[] = {
>  static const struct of_device_id qcom_spmi_regulator_match[] = {
>  	{ .compatible = "qcom,pm8004-regulators", .data = &pm8004_regulators },
>  	{ .compatible = "qcom,pm8005-regulators", .data = &pm8005_regulators },
> +	{ .compatible = "qcom,pm8226-regulators", .data = &pm8226_regulators },
>  	{ .compatible = "qcom,pm8841-regulators", .data = &pm8841_regulators },
>  	{ .compatible = "qcom,pm8916-regulators", .data = &pm8916_regulators },
>  	{ .compatible = "qcom,pm8941-regulators", .data = &pm8941_regulators },
> -- 
> 2.34.0
> 

Re: (subset) [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Mark Brown]

On Tue, 23 Nov 2021 18:41:27 +0100, Dominik Kobinski wrote:
> Add support for pm8226 SPMI GPIOs. The PMIC features
> 8 GPIOs, with no holes inbetween.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[3/4] dt-bindings: regulator: qcom: spmi-regulator: Document pm8226 compatible
      commit: 76e95f331be09bac8764e971613439d294422d6e
[4/4] regulator: qcom_spmi: Add pm8226 regulators
      commit: f8843e5e2dc85dc6a546ec130d76be66e62abed6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark