* [PATCH] soundwire: qcom: remove redundant version number read
@ 2021-11-16 10:50 Srinivas Kandagatla
2021-11-23 11:17 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Kandagatla @ 2021-11-16 10:50 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, linux-arm-msm, alsa-devel,
linux-kernel, Srinivas Kandagatla
Controller version is already available in struct qcom_swrm_ctrl, Just make use
of it instead of reading this again.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/soundwire/qcom.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index a317bea2d42d..46995bb382eb 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1156,11 +1156,7 @@ static int qcom_swrm_get_port_config(struct qcom_swrm_ctrl *ctrl)
ret = of_property_read_u8_array(np, "qcom,ports-block-pack-mode",
bp_mode, nports);
if (ret) {
- u32 version;
-
- ctrl->reg_read(ctrl, SWRM_COMP_HW_VERSION, &version);
-
- if (version <= 0x01030000)
+ if (ctrl->version <= 0x01030000)
memset(bp_mode, SWR_INVALID_PARAM, QCOM_SDW_MAX_PORTS);
else
return ret;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soundwire: qcom: remove redundant version number read
2021-11-16 10:50 [PATCH] soundwire: qcom: remove redundant version number read Srinivas Kandagatla
@ 2021-11-23 11:17 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-11-23 11:17 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: yung-chuan.liao, pierre-louis.bossart, linux-arm-msm, alsa-devel,
linux-kernel
On 16-11-21, 10:50, Srinivas Kandagatla wrote:
> Controller version is already available in struct qcom_swrm_ctrl, Just make use
> of it instead of reading this again.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-23 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 10:50 [PATCH] soundwire: qcom: remove redundant version number read Srinivas Kandagatla
2021-11-23 11:17 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).