[PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1

[PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1

[Martin Botka]

Without this change eMMC runs at overclocked freq.
Swap the ops to not OC the eMMC.

Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
 drivers/clk/qcom/gcc-sm6125.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-sm6125.c b/drivers/clk/qcom/gcc-sm6125.c
index 543cfab7561f..431b55bb0d2f 100644
--- a/drivers/clk/qcom/gcc-sm6125.c
+++ b/drivers/clk/qcom/gcc-sm6125.c
@@ -1121,7 +1121,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
 		.name = "gcc_sdcc1_apps_clk_src",
 		.parent_data = gcc_parent_data_1,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_1),
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
@@ -1143,7 +1143,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
 		.name = "gcc_sdcc1_ice_core_clk_src",
 		.parent_data = gcc_parent_data_0,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_0),
-		.ops = &clk_rcg2_floor_ops,
+		.ops = &clk_rcg2_ops,
 	},
 };
 
-- 
2.34.0

Re: [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1

[Stephen Boyd]

Quoting Martin Botka (2021-11-30 13:20:15)
> Without this change eMMC runs at overclocked freq.
> Swap the ops to not OC the eMMC.
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---

Any Fixes tag?

>  drivers/clk/qcom/gcc-sm6125.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-sm6125.c b/drivers/clk/qcom/gcc-sm6125.c
> index 543cfab7561f..431b55bb0d2f 100644
> --- a/drivers/clk/qcom/gcc-sm6125.c
> +++ b/drivers/clk/qcom/gcc-sm6125.c
> @@ -1121,7 +1121,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
>                 .name = "gcc_sdcc1_apps_clk_src",
>                 .parent_data = gcc_parent_data_1,
>                 .num_parents = ARRAY_SIZE(gcc_parent_data_1),
> -               .ops = &clk_rcg2_ops,
> +               .ops = &clk_rcg2_floor_ops,
>         },
>  };
>  
> @@ -1143,7 +1143,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
>                 .name = "gcc_sdcc1_ice_core_clk_src",
>                 .parent_data = gcc_parent_data_0,
>                 .num_parents = ARRAY_SIZE(gcc_parent_data_0),
> -               .ops = &clk_rcg2_floor_ops,
> +               .ops = &clk_rcg2_ops,
>         },
>  };
>  
> -- 
> 2.34.0
>

Re: [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1

[Bjorn Andersson]

On Tue 30 Nov 15:20 CST 2021, Martin Botka wrote:

> Without this change eMMC runs at overclocked freq.
> Swap the ops to not OC the eMMC.
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>

Fixes: 4b8d6ae57cdf ("clk: qcom: Add SM6125 (TRINKET) GCC driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  drivers/clk/qcom/gcc-sm6125.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-sm6125.c b/drivers/clk/qcom/gcc-sm6125.c
> index 543cfab7561f..431b55bb0d2f 100644
> --- a/drivers/clk/qcom/gcc-sm6125.c
> +++ b/drivers/clk/qcom/gcc-sm6125.c
> @@ -1121,7 +1121,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
>  		.name = "gcc_sdcc1_apps_clk_src",
>  		.parent_data = gcc_parent_data_1,
>  		.num_parents = ARRAY_SIZE(gcc_parent_data_1),
> -		.ops = &clk_rcg2_ops,
> +		.ops = &clk_rcg2_floor_ops,
>  	},
>  };
>  
> @@ -1143,7 +1143,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
>  		.name = "gcc_sdcc1_ice_core_clk_src",
>  		.parent_data = gcc_parent_data_0,
>  		.num_parents = ARRAY_SIZE(gcc_parent_data_0),
> -		.ops = &clk_rcg2_floor_ops,
> +		.ops = &clk_rcg2_ops,
>  	},
>  };
>  
> -- 
> 2.34.0
> 

Re: [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1

[Stephen Boyd]

Quoting Martin Botka (2021-11-30 13:20:15)
> Without this change eMMC runs at overclocked freq.
> Swap the ops to not OC the eMMC.
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---

Applied to clk-fixes