* [PATCH v2] PCI: qcom: Add async probe support
@ 2023-03-20 6:46 Manivannan Sadhasivam
2023-03-21 10:01 ` Johan Hovold
2023-04-11 10:00 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-20 6:46 UTC (permalink / raw)
To: lpieralisi, kw
Cc: robh, andersson, konrad.dybcio, bhelgaas, linux-pci,
linux-arm-msm, linux-kernel, johan+linaro, steev,
Manivannan Sadhasivam
Qcom PCIe RC driver waits for the PHY link to be up during the probe. This
consumes several milliseconds during boot. So add async probe support so
that other drivers can load in parallel while this driver waits for the
link to be up.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Changes in v2:
* Rebased on top of v6.3-rc1
drivers/pci/controller/dwc/pcie-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index a232b04af048..4ca357be88e0 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1862,6 +1862,7 @@ static struct platform_driver qcom_pcie_driver = {
.name = "qcom-pcie",
.suppress_bind_attrs = true,
.of_match_table = qcom_pcie_match,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
};
builtin_platform_driver(qcom_pcie_driver);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI: qcom: Add async probe support
2023-03-20 6:46 [PATCH v2] PCI: qcom: Add async probe support Manivannan Sadhasivam
@ 2023-03-21 10:01 ` Johan Hovold
2023-04-11 10:00 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2023-03-21 10:01 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: lpieralisi, kw, robh, andersson, konrad.dybcio, bhelgaas,
linux-pci, linux-arm-msm, linux-kernel, johan+linaro, steev
On Mon, Mar 20, 2023 at 12:16:44PM +0530, Manivannan Sadhasivam wrote:
> Qcom PCIe RC driver waits for the PHY link to be up during the probe. This
> consumes several milliseconds during boot. So add async probe support so
> that other drivers can load in parallel while this driver waits for the
> link to be up.
You're not really "adding support" for async probe as much as you are
enabling it by default. Perhaps you can clarify that in the commit
summary and commit message (e.g. by rephrasing as "prefer async probe").
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>
> Changes in v2:
>
> * Rebased on top of v6.3-rc1
With an updated commit message:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Johan Hovold <johan+linaro@kernel.org>
> drivers/pci/controller/dwc/pcie-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index a232b04af048..4ca357be88e0 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1862,6 +1862,7 @@ static struct platform_driver qcom_pcie_driver = {
> .name = "qcom-pcie",
> .suppress_bind_attrs = true,
> .of_match_table = qcom_pcie_match,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> };
> builtin_platform_driver(qcom_pcie_driver);
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI: qcom: Add async probe support
2023-03-20 6:46 [PATCH v2] PCI: qcom: Add async probe support Manivannan Sadhasivam
2023-03-21 10:01 ` Johan Hovold
@ 2023-04-11 10:00 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2023-04-11 10:00 UTC (permalink / raw)
To: kw, Manivannan Sadhasivam
Cc: Lorenzo Pieralisi, robh, andersson, konrad.dybcio, bhelgaas,
linux-pci, linux-arm-msm, linux-kernel, johan+linaro, steev
On Mon, 20 Mar 2023 12:16:44 +0530, Manivannan Sadhasivam wrote:
> Qcom PCIe RC driver waits for the PHY link to be up during the probe. This
> consumes several milliseconds during boot. So add async probe support so
> that other drivers can load in parallel while this driver waits for the
> link to be up.
>
>
Applied to controller/qcom, thanks!
[1/1] PCI: qcom: Add async probe support
https://git.kernel.org/pci/pci/c/2dee743c8b4d
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-11 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 6:46 [PATCH v2] PCI: qcom: Add async probe support Manivannan Sadhasivam
2023-03-21 10:01 ` Johan Hovold
2023-04-11 10:00 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).