From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Vinod Koul <vkoul@kernel.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
DT <devicetree@vger.kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: sdm845: remove macro from unit name
Date: Mon, 22 Jul 2019 15:18:36 +0200 [thread overview]
Message-ID: <a100cb6e-78d0-8fde-131a-2b10f9f0819d@free.fr> (raw)
In-Reply-To: <20190722123422.4571-5-vkoul@kernel.org>
On 22/07/2019 14:34, Vinod Koul wrote:
> Unit name is supposed to be a number, using a macro with hex value is
> not recommended, so add the value in unit name.
>
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x"
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index 051a52df80f9..d76c8377c224 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -78,7 +78,7 @@
> #size-cells = <0>;
> #io-channel-cells = <1>;
>
> - adc-chan@ADC5_DIE_TEMP {
> + adc-chan@6{
You dropped the space before the {
;-)
next prev parent reply other threads:[~2019-07-22 13:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:34 [PATCH 0/5] arm64: dts: qcom: sdm845: Fix DTS warnings Vinod Koul
2019-07-22 12:34 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node Vinod Koul
2019-07-23 14:50 ` Stephen Boyd
2019-07-24 4:07 ` Vinod Koul
2019-07-22 12:34 ` [PATCH 2/5] arm64: dts: qcom: sdm845: remove unnecessary properties for dsi nodes Vinod Koul
2019-07-23 14:45 ` Stephen Boyd
2019-07-22 12:34 ` [PATCH 3/5] arm64: dts: qcom: sdm845: remove unit name for thermal trip points Vinod Koul
2019-07-23 14:47 ` Stephen Boyd
2019-07-22 12:34 ` [PATCH 4/5] arm64: dts: qcom: sdm845: remove macro from unit name Vinod Koul
2019-07-22 13:18 ` Marc Gonzalez [this message]
2019-07-22 13:48 ` Vinod Koul
2019-07-22 12:34 ` [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: " Vinod Koul
2019-07-23 5:08 ` Amit Kucheria
2019-07-23 5:14 ` Vinod Koul
2019-07-23 5:41 ` Bjorn Andersson
2019-07-23 14:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a100cb6e-78d0-8fde-131a-2b10f9f0819d@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).