Re: [PATCH v2 1/7] dt-bindings: pci/qcom,pcie: convert to YAML

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 22/04/2022 23:09, Dmitry Baryshkov wrote:
> Changes to the schema:
>  - Fixed the ordering of clock-names/reset-names according to
>    the dtsi files.
>  - Mark vdda-supply as required only for apq/ipq8064 (as it was marked
>    as generally required in the txt file).
> 

Thank you for your patch. There is something to discuss/improve.

(...)

> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    items:
> +      - const: "msi"

Skip quotes. You anyway later remove them in other patchset.

> +
> +  # Common definitions for clocks, clock-names and reset.
> +  # Platform constraints are described later.
> +  clocks:
> +    minItems: 3
> +    maxItems: 12
> +
> +  clock-names:
> +    minItems: 3
> +    maxItems: 12
> +
> +  resets:
> +    minItems: 1
> +    maxItems: 12
> +
> +  resets-names:
> +    minItems: 1
> +    maxItems: 12
> +
> +  vdda-supply:
> +    description: A phandle to the core analog power supply
> +
> +  vdda_phy-supply:
> +    description: A phandle to the core analog power supply for PHY
> +
> +  vdda_refclk-supply:
> +    description: A phandle to the core analog power supply for IC which generates reference clock
> +
> +  vddpe-3v3-supply:
> +    description: A phandle to the PCIe endpoint power supply
> +
> +  phys:
> +    maxItems: 1
> +
> +  phy-names:
> +    items:
> +      - const: "pciephy"

Skip quotes.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof