* [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
@ 2022-06-14 16:11 Taniya Das
2022-06-14 16:51 ` Matthias Kaehlcke
2022-06-30 18:44 ` kernel test robot
0 siblings, 2 replies; 6+ messages in thread
From: Taniya Das @ 2022-06-14 16:11 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Douglas Anderson, Stephen Boyd, Andy Gross, devicetree,
linux-arm-msm, linux-kernel, Taniya Das
The lpass audio supports TX/RX/WSA block resets. The LPASS PIL clock
driver is not supported and mark it disabled. Also to keep consistency
update lpasscore to lpass_core.
Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index e66fc67de206..180cfd2765b9 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2174,6 +2174,7 @@
clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
clock-names = "iface";
#clock-cells = <1>;
+ status = "disabled";
};
lpass_audiocc: clock-controller@3300000 {
@@ -2185,6 +2186,7 @@
power-domains = <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
#clock-cells = <1>;
#power-domain-cells = <1>;
+ #reset-cells = <1>;
};
lpass_aon: clock-controller@3380000 {
@@ -2198,7 +2200,7 @@
#power-domain-cells = <1>;
};
- lpasscore: clock-controller@3900000 {
+ lpass_core: clock-controller@3900000 {
compatible = "qcom,sc7280-lpasscorecc";
reg = <0 0x03900000 0 0x50000>;
clocks = <&rpmhcc RPMH_CXO_CLK>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
2022-06-14 16:11 [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets Taniya Das
@ 2022-06-14 16:51 ` Matthias Kaehlcke
2022-06-14 20:38 ` Stephen Boyd
2022-06-30 18:44 ` kernel test robot
1 sibling, 1 reply; 6+ messages in thread
From: Matthias Kaehlcke @ 2022-06-14 16:51 UTC (permalink / raw)
To: Taniya Das
Cc: Rob Herring, Bjorn Andersson, Douglas Anderson, Stephen Boyd,
Andy Gross, devicetree, linux-arm-msm, linux-kernel
On Tue, Jun 14, 2022 at 09:41:18PM +0530, Taniya Das wrote:
> The lpass audio supports TX/RX/WSA block resets. The LPASS PIL clock
> driver is not supported and mark it disabled. Also to keep consistency
> update lpasscore to lpass_core.
There is a driver for "qcom,sc7280-lpasscc", what does it mean that is
isn't supported?
IIUC one problem is that 'lpasscc@3000000' and 'lpass_aon / clock-controller@3380000'
have overlapping register ranges, so they can't be used together.
You could just say 'Disable the LPASS PIL clock by default, boards
can enable it if needed'.
> Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index e66fc67de206..180cfd2765b9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2174,6 +2174,7 @@
> clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
> clock-names = "iface";
> #clock-cells = <1>;
> + status = "disabled";
> };
>
> lpass_audiocc: clock-controller@3300000 {
> @@ -2185,6 +2186,7 @@
> power-domains = <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
> #clock-cells = <1>;
> #power-domain-cells = <1>;
> + #reset-cells = <1>;
> };
>
> lpass_aon: clock-controller@3380000 {
> @@ -2198,7 +2200,7 @@
> #power-domain-cells = <1>;
> };
>
> - lpasscore: clock-controller@3900000 {
> + lpass_core: clock-controller@3900000 {
> compatible = "qcom,sc7280-lpasscorecc";
> reg = <0 0x03900000 0 0x50000>;
> clocks = <&rpmhcc RPMH_CXO_CLK>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
2022-06-14 16:51 ` Matthias Kaehlcke
@ 2022-06-14 20:38 ` Stephen Boyd
2022-07-07 7:06 ` Taniya Das
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2022-06-14 20:38 UTC (permalink / raw)
To: Matthias Kaehlcke, Taniya Das
Cc: Rob Herring, Bjorn Andersson, Douglas Anderson, Andy Gross,
devicetree, linux-arm-msm, linux-kernel
Quoting Matthias Kaehlcke (2022-06-14 09:51:57)
> On Tue, Jun 14, 2022 at 09:41:18PM +0530, Taniya Das wrote:
> > The lpass audio supports TX/RX/WSA block resets. The LPASS PIL clock
> > driver is not supported and mark it disabled. Also to keep consistency
> > update lpasscore to lpass_core.
>
> There is a driver for "qcom,sc7280-lpasscc", what does it mean that is
> isn't supported?
>
> IIUC one problem is that 'lpasscc@3000000' and 'lpass_aon / clock-controller@3380000'
> have overlapping register ranges, so they can't be used together.
>
> You could just say 'Disable the LPASS PIL clock by default, boards
> can enable it if needed'.
For the pinctrl driver we added a "qcom,adsp-bypass-mode" property[1] to
indicate that the ADSP was being bypassed or not. Can we do the same
here and combine the device nodes that have overlapping reg properties?
[1] https://lore.kernel.org/r/1654921357-16400-2-git-send-email-quic_srivasam@quicinc.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
2022-06-14 16:11 [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets Taniya Das
2022-06-14 16:51 ` Matthias Kaehlcke
@ 2022-06-30 18:44 ` kernel test robot
1 sibling, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-06-30 18:44 UTC (permalink / raw)
To: Taniya Das, Rob Herring, Bjorn Andersson
Cc: kbuild-all, Douglas Anderson, Stephen Boyd, Andy Gross,
devicetree, linux-arm-msm, linux-kernel, Taniya Das
Hi Taniya,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.19-rc4 next-20220630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Taniya-Das/arm64-dts-qcom-sc7280-Update-lpassaudio-clock-controller-for-resets/20220615-001326
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20220701/202207010242.gFemy13K-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3156737d3479e335c9ffd0d65e51b1ae6b6d1ec5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Taniya-Das/arm64-dts-qcom-sc7280-Update-lpassaudio-clock-controller-for-resets/20220615-001326
git checkout 3156737d3479e335c9ffd0d65e51b1ae6b6d1ec5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> ERROR: Input tree has errors, aborting (use -f to force output)
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
2022-06-14 20:38 ` Stephen Boyd
@ 2022-07-07 7:06 ` Taniya Das
2022-07-08 20:48 ` Stephen Boyd
0 siblings, 1 reply; 6+ messages in thread
From: Taniya Das @ 2022-07-07 7:06 UTC (permalink / raw)
To: Stephen Boyd, Matthias Kaehlcke
Cc: Rob Herring, Bjorn Andersson, Douglas Anderson, Andy Gross,
devicetree, linux-arm-msm, linux-kernel
Hi Stephen,
On 6/15/2022 2:08 AM, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2022-06-14 09:51:57)
>> On Tue, Jun 14, 2022 at 09:41:18PM +0530, Taniya Das wrote:
>>> The lpass audio supports TX/RX/WSA block resets. The LPASS PIL clock
>>> driver is not supported and mark it disabled. Also to keep consistency
>>> update lpasscore to lpass_core.
>>
>> There is a driver for "qcom,sc7280-lpasscc", what does it mean that is
>> isn't supported?
>>
>> IIUC one problem is that 'lpasscc@3000000' and 'lpass_aon / clock-controller@3380000'
>> have overlapping register ranges, so they can't be used together.
>>
>> You could just say 'Disable the LPASS PIL clock by default, boards
>> can enable it if needed'.
>
> For the pinctrl driver we added a "qcom,adsp-bypass-mode" property[1] to
> indicate that the ADSP was being bypassed or not. Can we do the same
> here and combine the device nodes that have overlapping reg properties?
>
> [1] https://lore.kernel.org/r/1654921357-16400-2-git-send-email-quic_srivasam@quicinc.com
Could we take up as a cleanup and take it forward:
https://lore.kernel.org/lkml/20220614153306.29339-1-quic_tdas@quicinc.com/T/#t
--
Thanks & Regards,
Taniya Das.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
2022-07-07 7:06 ` Taniya Das
@ 2022-07-08 20:48 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2022-07-08 20:48 UTC (permalink / raw)
To: Matthias Kaehlcke, Taniya Das
Cc: Rob Herring, Bjorn Andersson, Douglas Anderson, Andy Gross,
devicetree, linux-arm-msm, linux-kernel
Quoting Taniya Das (2022-07-07 00:06:59)
>
> Hi Stephen,
>
> On 6/15/2022 2:08 AM, Stephen Boyd wrote:
> > Quoting Matthias Kaehlcke (2022-06-14 09:51:57)
> >> On Tue, Jun 14, 2022 at 09:41:18PM +0530, Taniya Das wrote:
> >>> The lpass audio supports TX/RX/WSA block resets. The LPASS PIL clock
> >>> driver is not supported and mark it disabled. Also to keep consistency
> >>> update lpasscore to lpass_core.
> >>
> >> There is a driver for "qcom,sc7280-lpasscc", what does it mean that is
> >> isn't supported?
> >>
> >> IIUC one problem is that 'lpasscc@3000000' and 'lpass_aon / clock-controller@3380000'
> >> have overlapping register ranges, so they can't be used together.
> >>
> >> You could just say 'Disable the LPASS PIL clock by default, boards
> >> can enable it if needed'.
> >
> > For the pinctrl driver we added a "qcom,adsp-bypass-mode" property[1] to
> > indicate that the ADSP was being bypassed or not. Can we do the same
> > here and combine the device nodes that have overlapping reg properties?
> >
> > [1] https://lore.kernel.org/r/1654921357-16400-2-git-send-email-quic_srivasam@quicinc.com
>
> Could we take up as a cleanup and take it forward:
> https://lore.kernel.org/lkml/20220614153306.29339-1-quic_tdas@quicinc.com/T/#t
>
I don't think so. The binding would need to change.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-08 20:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 16:11 [PATCH v1] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets Taniya Das
2022-06-14 16:51 ` Matthias Kaehlcke
2022-06-14 20:38 ` Stephen Boyd
2022-07-07 7:06 ` Taniya Das
2022-07-08 20:48 ` Stephen Boyd
2022-06-30 18:44 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).