* [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding
@ 2020-04-22 14:08 Ansuel Smith
2020-04-22 14:08 ` [PATCH 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq Ansuel Smith
2020-04-22 15:26 ` [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Georgi Djakov
0 siblings, 2 replies; 3+ messages in thread
From: Ansuel Smith @ 2020-04-22 14:08 UTC (permalink / raw)
To: Ilia Lin
Cc: Ansuel Smith, Andy Gross, Bjorn Andersson, Viresh Kumar,
Nishanth Menon, Stephen Boyd, Rob Herring, Rafael J. Wysocki,
Sricharan R, linux-pm, linux-arm-msm, devicetree, linux-kernel
Binding has changed from operating-points-v2-kryo-cpu to
operating-points-v2-qcom-cpu. Also check for old binding in driver
probe.
Fixes: a8811ec764f9 cpufreq: qcom: Add support for krait based socs
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/cpufreq/qcom-cpufreq-nvmem.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
index a1b8238872a2..8a0411efc79a 100644
--- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
+++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
@@ -278,6 +278,10 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
return -ENOENT;
ret = of_device_is_compatible(np, "operating-points-v2-qcom-cpu");
+ if (!ret)
+ ret = of_device_is_compatible(np,
+ "operating-points-v2-kyro-cpu");
+
if (!ret) {
of_node_put(np);
return -ENOENT;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq
2020-04-22 14:08 [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Ansuel Smith
@ 2020-04-22 14:08 ` Ansuel Smith
2020-04-22 15:26 ` [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Georgi Djakov
1 sibling, 0 replies; 3+ messages in thread
From: Ansuel Smith @ 2020-04-22 14:08 UTC (permalink / raw)
To: Ilia Lin
Cc: Ansuel Smith, Andy Gross, Bjorn Andersson, Viresh Kumar,
Nishanth Menon, Stephen Boyd, Rob Herring, Rafael J. Wysocki,
Sricharan R, linux-pm, linux-arm-msm, devicetree, linux-kernel
Update binding to new generic name "operating-points-v2-qcom-cpu"
Fixes: a8811ec764f9 cpufreq: qcom: Add support for krait based socs
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt b/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
index 64f07417ecfb..537e1774f589 100644
--- a/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
+++ b/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
@@ -19,7 +19,7 @@ In 'cpu' nodes:
In 'operating-points-v2' table:
- compatible: Should be
- - 'operating-points-v2-kryo-cpu' for apq8096, msm8996, msm8974,
+ - 'operating-points-v2-qcom-cpu' for apq8096, msm8996, msm8974,
apq8064, ipq8064, msm8960 and ipq8074.
Optional properties:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding
2020-04-22 14:08 [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Ansuel Smith
2020-04-22 14:08 ` [PATCH 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq Ansuel Smith
@ 2020-04-22 15:26 ` Georgi Djakov
1 sibling, 0 replies; 3+ messages in thread
From: Georgi Djakov @ 2020-04-22 15:26 UTC (permalink / raw)
To: Ansuel Smith
Cc: Ilia Lin, Andy Gross, Bjorn Andersson, Viresh Kumar,
Nishanth Menon, Stephen Boyd, Rob Herring, Rafael J. Wysocki,
Sricharan R, linux-pm, linux-arm-msm, devicetree, linux-kernel
Hi Ansuel,
On 4/22/20 17:08, Ansuel Smith wrote:
> Binding has changed from operating-points-v2-kryo-cpu to
> operating-points-v2-qcom-cpu. Also check for old binding in driver
> probe.
>
> Fixes: a8811ec764f9 cpufreq: qcom: Add support for krait based socs
The correct format is: Fixes: %h (\"%s\")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index a1b8238872a2..8a0411efc79a 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -278,6 +278,10 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
> return -ENOENT;
>
> ret = of_device_is_compatible(np, "operating-points-v2-qcom-cpu");
> + if (!ret)
> + ret = of_device_is_compatible(np,
> + "operating-points-v2-kyro-cpu");
There is a typo in the compatible string.
Thanks,
Georgi
> +
> if (!ret) {
> of_node_put(np);
> return -ENOENT;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-22 15:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 14:08 [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Ansuel Smith
2020-04-22 14:08 ` [PATCH 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq Ansuel Smith
2020-04-22 15:26 ` [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Georgi Djakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).