* [PATCH 0/4] Tab P11 features
@ 2023-04-06 15:25 Konrad Dybcio
2023-04-06 15:25 ` [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node Konrad Dybcio
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 15:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
linux-hardening, Konrad Dybcio
This short series brings a couple of "nice" features to the Tab P11:
- Wi-Fi
- remoteprocs (+RMTFS)
- ramoops
No external dependencies.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (4):
arm64: dts: qcom: sm6115-j606f: Add ramoops node
arm64: dts: qcom: sm6115: Add RMTFS
arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs
arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi
arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 34 +++++++++++++++++++++++
2 files changed, 44 insertions(+)
---
base-commit: e134c93f788fb93fd6a3ec3af9af850a2048c7e6
change-id: 20230406-topic-lenovo_features-d708e51caa7e
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node
2023-04-06 15:25 [PATCH 0/4] Tab P11 features Konrad Dybcio
@ 2023-04-06 15:25 ` Konrad Dybcio
2023-04-06 17:54 ` Dmitry Baryshkov
2023-04-06 15:25 ` [PATCH 2/4] arm64: dts: qcom: sm6115: Add RMTFS Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 15:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
linux-hardening, Konrad Dybcio
Add a ramoops node to enable retrieving crash logs.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
index 10c9d338446c..fd064899791c 100644
--- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
@@ -52,6 +52,17 @@ key-volume-up {
wakeup-source;
};
};
+
+ reserved-memory {
+ ramoops@ffc00000 {
+ compatible = "ramoops";
+ reg = <0x0 0xffc00000 0x0 0x100000>;
+ record-size = <0x1000>;
+ console-size = <0x40000>;
+ ecc-size = <16>;
+ no-map;
+ };
+ };
};
&dispcc {
--
2.40.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/4] arm64: dts: qcom: sm6115: Add RMTFS
2023-04-06 15:25 [PATCH 0/4] Tab P11 features Konrad Dybcio
2023-04-06 15:25 ` [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node Konrad Dybcio
@ 2023-04-06 15:25 ` Konrad Dybcio
2023-04-06 17:52 ` Dmitry Baryshkov
2023-04-06 15:25 ` [PATCH 3/4] arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs Konrad Dybcio
2023-04-06 15:25 ` [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi Konrad Dybcio
3 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 15:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
linux-hardening, Konrad Dybcio
Add a node for RMTFS and associate it with MSA and NAV IDs to enable
modem functionality on SM6115.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index 2505c815c65a..99c6550663c8 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -8,6 +8,7 @@
#include <dt-bindings/clock/qcom,sm6115-gpucc.h>
#include <dt-bindings/clock/qcom,rpmcc.h>
#include <dt-bindings/dma/qcom-gpi.h>
+#include <dt-bindings/firmware/qcom,scm.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/power/qcom-rpmpd.h>
@@ -290,6 +291,15 @@ removed_mem: memory@60000000 {
reg = <0x0 0x60000000 0x0 0x3900000>;
no-map;
};
+
+ rmtfs_mem: memory@89b01000 {
+ compatible = "qcom,rmtfs-mem";
+ reg = <0x0 0x89b01000 0x0 0x200000>;
+ no-map;
+
+ qcom,client-id = <1>;
+ qcom,vmid = <QCOM_SCM_VMID_MSS_MSA QCOM_SCM_VMID_NAV>;
+ };
};
rpm-glink {
--
2.40.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/4] arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs
2023-04-06 15:25 [PATCH 0/4] Tab P11 features Konrad Dybcio
2023-04-06 15:25 ` [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node Konrad Dybcio
2023-04-06 15:25 ` [PATCH 2/4] arm64: dts: qcom: sm6115: Add RMTFS Konrad Dybcio
@ 2023-04-06 15:25 ` Konrad Dybcio
2023-04-06 17:51 ` Dmitry Baryshkov
2023-04-06 15:25 ` [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi Konrad Dybcio
3 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 15:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
linux-hardening, Konrad Dybcio
Enable the [AC]DSP and MPSS and specify the firmware paths.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
index fd064899791c..2aac25171dec 100644
--- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
@@ -89,6 +89,21 @@ &pon_resin {
status = "okay";
};
+&remoteproc_adsp {
+ firmware-name = "qcom/sm6115/LENOVO/J606F/adsp.mbn";
+ status = "okay";
+};
+
+&remoteproc_cdsp {
+ firmware-name = "qcom/sm6115/LENOVO/J606F/cdsp.mbn";
+ status = "okay";
+};
+
+&remoteproc_mpss {
+ firmware-name = "qcom/sm6115/LENOVO/J606F/modem.mbn";
+ status = "okay";
+};
+
&rpm_requests {
regulators-0 {
compatible = "qcom,rpm-pm6125-regulators";
--
2.40.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi
2023-04-06 15:25 [PATCH 0/4] Tab P11 features Konrad Dybcio
` (2 preceding siblings ...)
2023-04-06 15:25 ` [PATCH 3/4] arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs Konrad Dybcio
@ 2023-04-06 15:25 ` Konrad Dybcio
2023-04-06 17:51 ` Dmitry Baryshkov
3 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 15:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
linux-hardening, Konrad Dybcio
Enable the onboard QCA Wi-Fi. HW identifiers for reference:
qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000
Firmware sources:
/vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn
/vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin
[3] -> ath10k/.../firmware-5.bin
Not sure where 3 comes from on the device itself, gotta investigate that..
According to [4], it's called WCN3990_STRAIT.
[1] XX = board_id printed when the file is missing or by your downstream
kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin
[2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
[3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin
[4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
index 2aac25171dec..4ba8e59a27d8 100644
--- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
@@ -315,6 +315,14 @@ &usb_hsphy {
status = "okay";
};
+&wifi {
+ vdd-0.8-cx-mx-supply = <&pm6125_l8>;
+ vdd-1.8-xo-supply = <&pm6125_l16>;
+ vdd-1.3-rfa-supply = <&pm6125_l17>;
+ vdd-3.3-ch0-supply = <&pm6125_l23>;
+ status = "okay";
+};
+
&xo_board {
clock-frequency = <19200000>;
};
--
2.40.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi
2023-04-06 15:25 ` [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi Konrad Dybcio
@ 2023-04-06 17:51 ` Dmitry Baryshkov
2023-04-06 18:32 ` Konrad Dybcio
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-04-06 17:51 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 06/04/2023 18:25, Konrad Dybcio wrote:
> Enable the onboard QCA Wi-Fi. HW identifiers for reference:
> qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000
>
> Firmware sources:
> /vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn
> /vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin
> [3] -> ath10k/.../firmware-5.bin
>
> Not sure where 3 comes from on the device itself, gotta investigate that..
>
> According to [4], it's called WCN3990_STRAIT.
>
> [1] XX = board_id printed when the file is missing or by your downstream
> kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin
Since the board_id is 0xff, please add qcom,ath10k-calibration-variant
Ideally, could you please send the bdwlan to ath10k for inclusion, see
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles .
>
> [2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
> [3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin
> [4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> index 2aac25171dec..4ba8e59a27d8 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> @@ -315,6 +315,14 @@ &usb_hsphy {
> status = "okay";
> };
>
> +&wifi {
> + vdd-0.8-cx-mx-supply = <&pm6125_l8>;
> + vdd-1.8-xo-supply = <&pm6125_l16>;
> + vdd-1.3-rfa-supply = <&pm6125_l17>;
> + vdd-3.3-ch0-supply = <&pm6125_l23>;
> + status = "okay";
> +};
> +
> &xo_board {
> clock-frequency = <19200000>;
> };
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs
2023-04-06 15:25 ` [PATCH 3/4] arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs Konrad Dybcio
@ 2023-04-06 17:51 ` Dmitry Baryshkov
0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-04-06 17:51 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 06/04/2023 18:25, Konrad Dybcio wrote:
> Enable the [AC]DSP and MPSS and specify the firmware paths.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/4] arm64: dts: qcom: sm6115: Add RMTFS
2023-04-06 15:25 ` [PATCH 2/4] arm64: dts: qcom: sm6115: Add RMTFS Konrad Dybcio
@ 2023-04-06 17:52 ` Dmitry Baryshkov
0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-04-06 17:52 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 06/04/2023 18:25, Konrad Dybcio wrote:
> Add a node for RMTFS and associate it with MSA and NAV IDs to enable
> modem functionality on SM6115.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node
2023-04-06 15:25 ` [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node Konrad Dybcio
@ 2023-04-06 17:54 ` Dmitry Baryshkov
2023-04-06 18:29 ` Konrad Dybcio
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-04-06 17:54 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 06/04/2023 18:25, Konrad Dybcio wrote:
> Add a ramoops node to enable retrieving crash logs.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> index 10c9d338446c..fd064899791c 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> @@ -52,6 +52,17 @@ key-volume-up {
> wakeup-source;
> };
> };
> +
> + reserved-memory {
> + ramoops@ffc00000 {
> + compatible = "ramoops";
> + reg = <0x0 0xffc00000 0x0 0x100000>;
> + record-size = <0x1000>;
> + console-size = <0x40000>;
no ftrace-size?
> + ecc-size = <16>;
> + no-map;
I see that other ramoops defines are not marked with no-map. Is there
any reason for that?
> + };
> + };
> };
>
> &dispcc {
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node
2023-04-06 17:54 ` Dmitry Baryshkov
@ 2023-04-06 18:29 ` Konrad Dybcio
0 siblings, 0 replies; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 18:29 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 6.04.2023 19:54, Dmitry Baryshkov wrote:
> On 06/04/2023 18:25, Konrad Dybcio wrote:
>> Add a ramoops node to enable retrieving crash logs.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> index 10c9d338446c..fd064899791c 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> @@ -52,6 +52,17 @@ key-volume-up {
>> wakeup-source;
>> };
>> };
>> +
>> + reserved-memory {
>> + ramoops@ffc00000 {
>> + compatible = "ramoops";
>> + reg = <0x0 0xffc00000 0x0 0x100000>;
>> + record-size = <0x1000>;
>> + console-size = <0x40000>;
>
> no ftrace-size?
It could use some!
>
>> + ecc-size = <16>;
>> + no-map;
>
> I see that other ramoops defines are not marked with no-map. Is there any reason for that?
Hm, not really. I can get rid of it for v2.
Konrad
>
>> + };
>> + };
>> };
>> &dispcc {
>>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi
2023-04-06 17:51 ` Dmitry Baryshkov
@ 2023-04-06 18:32 ` Konrad Dybcio
2023-04-06 18:56 ` Dmitry Baryshkov
0 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-04-06 18:32 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Kees Cook, Tony Luck, Guilherme G. Piccoli
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 6.04.2023 19:51, Dmitry Baryshkov wrote:
> On 06/04/2023 18:25, Konrad Dybcio wrote:
>> Enable the onboard QCA Wi-Fi. HW identifiers for reference:
>> qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000
>>
>> Firmware sources:
>> /vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn
>> /vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin
>> [3] -> ath10k/.../firmware-5.bin
>>
>> Not sure where 3 comes from on the device itself, gotta investigate that..
>>
>> According to [4], it's called WCN3990_STRAIT.
>>
>> [1] XX = board_id printed when the file is missing or by your downstream
>> kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin
>
> Since the board_id is 0xff, please add qcom,ath10k-calibration-variant
Do I make up a name, or is there some convention?
I see Johan used "LE_X13S" in commit 2702f54f400ad3979632cdb76553772414f4c5e3.
Should I go with "LE_P11"?
>
> Ideally, could you please send the bdwlan to ath10k for inclusion, see https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles .
The legal situation is ambiguous at best :/
Konrad
>
>>
>> [2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
>> [3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin
>> [4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> index 2aac25171dec..4ba8e59a27d8 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> @@ -315,6 +315,14 @@ &usb_hsphy {
>> status = "okay";
>> };
>> +&wifi {
>> + vdd-0.8-cx-mx-supply = <&pm6125_l8>;
>> + vdd-1.8-xo-supply = <&pm6125_l16>;
>> + vdd-1.3-rfa-supply = <&pm6125_l17>;
>> + vdd-3.3-ch0-supply = <&pm6125_l23>;
>> + status = "okay";
>> +};
>> +
>> &xo_board {
>> clock-frequency = <19200000>;
>> };
>>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi
2023-04-06 18:32 ` Konrad Dybcio
@ 2023-04-06 18:56 ` Dmitry Baryshkov
2023-04-07 13:27 ` Dmitry Baryshkov
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-04-06 18:56 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli, Marijn Suijten,
linux-arm-msm, devicetree, linux-kernel, linux-hardening
On Thu, 6 Apr 2023 at 21:32, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 6.04.2023 19:51, Dmitry Baryshkov wrote:
> > On 06/04/2023 18:25, Konrad Dybcio wrote:
> >> Enable the onboard QCA Wi-Fi. HW identifiers for reference:
> >> qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000
> >>
> >> Firmware sources:
> >> /vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn
> >> /vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin
> >> [3] -> ath10k/.../firmware-5.bin
> >>
> >> Not sure where 3 comes from on the device itself, gotta investigate that..
> >>
> >> According to [4], it's called WCN3990_STRAIT.
> >>
> >> [1] XX = board_id printed when the file is missing or by your downstream
> >> kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin
> >
> > Since the board_id is 0xff, please add qcom,ath10k-calibration-variant
> Do I make up a name, or is there some convention?
>
> I see Johan used "LE_X13S" in commit 2702f54f400ad3979632cdb76553772414f4c5e3.
> Should I go with "LE_P11"?
I think Lenovo_P11 or LENOVO_P11 might be better.
>
> >
> > Ideally, could you please send the bdwlan to ath10k for inclusion, see https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles .
> The legal situation is ambiguous at best :/
As usual :-(
>
> Konrad
> >
> >>
> >> [2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
> >> [3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin
> >> [4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> >> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> >> index 2aac25171dec..4ba8e59a27d8 100644
> >> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> >> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> >> @@ -315,6 +315,14 @@ &usb_hsphy {
> >> status = "okay";
> >> };
> >> +&wifi {
> >> + vdd-0.8-cx-mx-supply = <&pm6125_l8>;
> >> + vdd-1.8-xo-supply = <&pm6125_l16>;
> >> + vdd-1.3-rfa-supply = <&pm6125_l17>;
> >> + vdd-3.3-ch0-supply = <&pm6125_l23>;
> >> + status = "okay";
> >> +};
> >> +
> >> &xo_board {
> >> clock-frequency = <19200000>;
> >> };
> >>
> >
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi
2023-04-06 18:56 ` Dmitry Baryshkov
@ 2023-04-07 13:27 ` Dmitry Baryshkov
0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-04-07 13:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Kees Cook, Tony Luck, Guilherme G. Piccoli, Marijn Suijten,
linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 06/04/2023 21:56, Dmitry Baryshkov wrote:
> On Thu, 6 Apr 2023 at 21:32, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 6.04.2023 19:51, Dmitry Baryshkov wrote:
>>> On 06/04/2023 18:25, Konrad Dybcio wrote:
>>>> Enable the onboard QCA Wi-Fi. HW identifiers for reference:
>>>> qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000
>>>>
>>>> Firmware sources:
>>>> /vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn
>>>> /vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin
>>>> [3] -> ath10k/.../firmware-5.bin
>>>>
>>>> Not sure where 3 comes from on the device itself, gotta investigate that..
>>>>
>>>> According to [4], it's called WCN3990_STRAIT.
>>>>
>>>> [1] XX = board_id printed when the file is missing or by your downstream
>>>> kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin
>>>
>>> Since the board_id is 0xff, please add qcom,ath10k-calibration-variant
>> Do I make up a name, or is there some convention?
>>
>> I see Johan used "LE_X13S" in commit 2702f54f400ad3979632cdb76553772414f4c5e3.
>> Should I go with "LE_P11"?
>
> I think Lenovo_P11 or LENOVO_P11 might be better.
An update here:
Kalle added a board file for Yoga C630 using the id
'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=Lenovo_C630'. So, I
think, we should use 'Lenovo_P11' here.
>
>>
>>>
>>> Ideally, could you please send the bdwlan to ath10k for inclusion, see https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles .
>> The legal situation is ambiguous at best :/
>
> As usual :-(
>
>>
>> Konrad
>>>
>>>>
>>>> [2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
>>>> [3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin
>>>> [4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55
>>>>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>>>> index 2aac25171dec..4ba8e59a27d8 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>>>> @@ -315,6 +315,14 @@ &usb_hsphy {
>>>> status = "okay";
>>>> };
>>>> +&wifi {
>>>> + vdd-0.8-cx-mx-supply = <&pm6125_l8>;
>>>> + vdd-1.8-xo-supply = <&pm6125_l16>;
>>>> + vdd-1.3-rfa-supply = <&pm6125_l17>;
>>>> + vdd-3.3-ch0-supply = <&pm6125_l23>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> &xo_board {
>>>> clock-frequency = <19200000>;
>>>> };
>>>>
>>>
>
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-04-07 13:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 15:25 [PATCH 0/4] Tab P11 features Konrad Dybcio
2023-04-06 15:25 ` [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node Konrad Dybcio
2023-04-06 17:54 ` Dmitry Baryshkov
2023-04-06 18:29 ` Konrad Dybcio
2023-04-06 15:25 ` [PATCH 2/4] arm64: dts: qcom: sm6115: Add RMTFS Konrad Dybcio
2023-04-06 17:52 ` Dmitry Baryshkov
2023-04-06 15:25 ` [PATCH 3/4] arm64: dts: qcom: sm6115p-j606f: Enable remoteprocs Konrad Dybcio
2023-04-06 17:51 ` Dmitry Baryshkov
2023-04-06 15:25 ` [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi Konrad Dybcio
2023-04-06 17:51 ` Dmitry Baryshkov
2023-04-06 18:32 ` Konrad Dybcio
2023-04-06 18:56 ` Dmitry Baryshkov
2023-04-07 13:27 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).