* Re: [PATCH v2] arm64: dts: qcom: pmi8998: add rradc node
2022-10-17 18:56 [PATCH v2] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
@ 2022-10-17 18:43 ` konrad.dybcio
0 siblings, 0 replies; 2+ messages in thread
From: konrad.dybcio @ 2022-10-17 18:43 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Bjorn Andersson, devicetree, Konrad Dybcio,
Krzysztof Kozlowski, Lee Jones, linux-arm-msm, linux-kernel,
Rob Herring, Stephen Boyd
On 2022-10-17 20:56, Caleb Connolly wrote:
> Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
>
> The RRADC reports PMIC die and skin temperatures, as well as
> battery/charger thermals. It also reports USB and DC charger voltage
> and
> current measurements.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> This patch introduces a new dtbs_check warning which will be fixed by
> https://lore.kernel.org/linux-arm-msm/20221017185105.2279129-1-caleb.connolly@linaro.org/
>
> V1:
> https://lore.kernel.org/linux-arm-msm/20221016180330.1912214-1-caleb.connolly@linaro.org/
> Changes since v1:
> * Change node name from adc@ to rradc@, see linked patch
> * Enable the RRADC by default, rather than per-device
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index 6d3d212560c1..95c74d88eb93 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pmi8998_rradc: rradc@4500 {
> + compatible = "qcom,pmi8998-rradc";
> + reg = <0x4500>;
> + #io-channel-cells = <1>;
> +
> + status = "okay";
No need to, it's enabled by default when you define it.
Konrad
> + };
> };
>
> pmi8998_lsid1: pmic@3 {
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2] arm64: dts: qcom: pmi8998: add rradc node
@ 2022-10-17 18:56 Caleb Connolly
2022-10-17 18:43 ` konrad.dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Caleb Connolly @ 2022-10-17 18:56 UTC (permalink / raw)
To: caleb.connolly
Cc: Andy Gross, Bjorn Andersson, devicetree, Konrad Dybcio,
Krzysztof Kozlowski, Lee Jones, linux-arm-msm, linux-kernel,
Rob Herring, Stephen Boyd
Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
The RRADC reports PMIC die and skin temperatures, as well as
battery/charger thermals. It also reports USB and DC charger voltage and
current measurements.
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
This patch introduces a new dtbs_check warning which will be fixed by
https://lore.kernel.org/linux-arm-msm/20221017185105.2279129-1-caleb.connolly@linaro.org/
V1: https://lore.kernel.org/linux-arm-msm/20221016180330.1912214-1-caleb.connolly@linaro.org/
Changes since v1:
* Change node name from adc@ to rradc@, see linked patch
* Enable the RRADC by default, rather than per-device
---
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index 6d3d212560c1..95c74d88eb93 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pmi8998_rradc: rradc@4500 {
+ compatible = "qcom,pmi8998-rradc";
+ reg = <0x4500>;
+ #io-channel-cells = <1>;
+
+ status = "okay";
+ };
};
pmi8998_lsid1: pmic@3 {
--
2.38.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-17 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 18:56 [PATCH v2] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-10-17 18:43 ` konrad.dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).