* Re: [PATCH] PCI: qcom: Improve exception handling in qcom_pcie_probe()
@ 2020-05-26 14:30 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-26 14:30 UTC (permalink / raw)
To: Qiushi Wu, linux-arm-msm, linux-pci
Cc: Andy Gross, Bjorn Andersson, Bjorn Helgaas, Kangjie Lu,
Lorenzo Pieralisi, Philipp Zabel, Rob Herring, Stanimir Varbanov,
linux-kernel
Please avoid a typo in the patch subject (by a possible alternative?).
> In function qcom_pcie_probe(), there are several error-handling problem.
Wording adjustments:
This function contained improvable implementation details according to
exception handling.
> because refcount will be increased even pm_runtime_get_sync() returns
> an error.
because the reference count will be increased despite of the failure.
Thus add the missed function call.
> 2. pm_runtime_disable() are called twice, …
…
Thus remove redundant function calls.
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-26 14:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 14:30 [PATCH] PCI: qcom: Improve exception handling in qcom_pcie_probe() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).