* [PATCH] drm/msm/dpu: Fix error return code in dpu_mdss_init()
@ 2020-11-17 2:56 Chen Zhou
2020-11-17 19:53 ` [Freedreno] " abhinavk
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-11-17 2:56 UTC (permalink / raw)
To: robdclark, airlied
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, chenzhou10
Fix to return a negative error code from the error handling case
instead of 0 in function dpu_mdss_init(), as done elsewhere in this
function.
Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
index cd4078807db1..6e600b4ca995 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
@@ -297,8 +297,10 @@ int dpu_mdss_init(struct drm_device *dev)
goto irq_domain_error;
irq = platform_get_irq(pdev, 0);
- if (irq < 0)
+ if (irq < 0) {
+ ret = irq;
goto irq_error;
+ }
irq_set_chained_handler_and_data(irq, dpu_mdss_irq,
dpu_mdss);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Freedreno] [PATCH] drm/msm/dpu: Fix error return code in dpu_mdss_init()
2020-11-17 2:56 [PATCH] drm/msm/dpu: Fix error return code in dpu_mdss_init() Chen Zhou
@ 2020-11-17 19:53 ` abhinavk
0 siblings, 0 replies; 2+ messages in thread
From: abhinavk @ 2020-11-17 19:53 UTC (permalink / raw)
To: Chen Zhou
Cc: robdclark, airlied, linux-arm-msm, freedreno, linux-kernel, dri-devel
On 2020-11-16 18:56, Chen Zhou wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function dpu_mdss_init(), as done elsewhere in this
> function.
>
> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> index cd4078807db1..6e600b4ca995 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> @@ -297,8 +297,10 @@ int dpu_mdss_init(struct drm_device *dev)
> goto irq_domain_error;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0)
> + if (irq < 0) {
> + ret = irq;
> goto irq_error;
> + }
>
> irq_set_chained_handler_and_data(irq, dpu_mdss_irq,
> dpu_mdss);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-17 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 2:56 [PATCH] drm/msm/dpu: Fix error return code in dpu_mdss_init() Chen Zhou
2020-11-17 19:53 ` [Freedreno] " abhinavk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).