* [PATCH v2] drivers: thermal: tsens: Work with old DTBs
[not found] <cover.1576146898.git.amit.kucheria@linaro.org>
@ 2019-12-12 10:38 ` Amit Kucheria
2019-12-12 23:46 ` Bjorn Andersson
2019-12-16 9:28 ` Daniel Lezcano
0 siblings, 2 replies; 6+ messages in thread
From: Amit Kucheria @ 2019-12-12 10:38 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, agross, swboyd,
stephan, olof, Daniel Lezcano
Cc: linux-pm
In order for the old DTBs to continue working, the new interrupt code
must not return an error if interrupts are not defined. Don't return an
error in case of -ENXIO.
Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support")
Suggested-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
drivers/thermal/qcom/tsens.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 015e7d2015985..0e7cf52369326 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -110,6 +110,9 @@ static int tsens_register(struct tsens_priv *priv)
irq = platform_get_irq_byname(pdev, "uplow");
if (irq < 0) {
ret = irq;
+ /* For old DTs with no IRQ defined */
+ if (irq == -ENXIO)
+ ret = 0;
goto err_put_device;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers: thermal: tsens: Work with old DTBs
2019-12-12 10:38 ` [PATCH v2] drivers: thermal: tsens: Work with old DTBs Amit Kucheria
@ 2019-12-12 23:46 ` Bjorn Andersson
2019-12-16 9:28 ` Daniel Lezcano
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2019-12-12 23:46 UTC (permalink / raw)
To: Amit Kucheria
Cc: linux-kernel, linux-arm-msm, agross, swboyd, stephan, olof,
Daniel Lezcano, linux-pm
On Thu 12 Dec 02:38 PST 2019, Amit Kucheria wrote:
> In order for the old DTBs to continue working, the new interrupt code
> must not return an error if interrupts are not defined. Don't return an
> error in case of -ENXIO.
>
> Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support")
> Suggested-by: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/thermal/qcom/tsens.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 015e7d2015985..0e7cf52369326 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -110,6 +110,9 @@ static int tsens_register(struct tsens_priv *priv)
> irq = platform_get_irq_byname(pdev, "uplow");
> if (irq < 0) {
> ret = irq;
> + /* For old DTs with no IRQ defined */
> + if (irq == -ENXIO)
> + ret = 0;
> goto err_put_device;
> }
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers: thermal: tsens: Work with old DTBs
2019-12-12 10:38 ` [PATCH v2] drivers: thermal: tsens: Work with old DTBs Amit Kucheria
2019-12-12 23:46 ` Bjorn Andersson
@ 2019-12-16 9:28 ` Daniel Lezcano
2020-01-01 21:15 ` Amit Kucheria
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Lezcano @ 2019-12-16 9:28 UTC (permalink / raw)
To: Amit Kucheria, linux-kernel, linux-arm-msm, bjorn.andersson,
agross, swboyd, stephan, olof
Cc: linux-pm
On 12/12/2019 11:38, Amit Kucheria wrote:
> In order for the old DTBs to continue working, the new interrupt code
> must not return an error if interrupts are not defined. Don't return an
> error in case of -ENXIO.
>
> Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support")
> Suggested-by: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Applied.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers: thermal: tsens: Work with old DTBs
2019-12-16 9:28 ` Daniel Lezcano
@ 2020-01-01 21:15 ` Amit Kucheria
2020-01-01 21:44 ` Daniel Lezcano
0 siblings, 1 reply; 6+ messages in thread
From: Amit Kucheria @ 2020-01-01 21:15 UTC (permalink / raw)
To: Daniel Lezcano
Cc: LKML, linux-arm-msm, Bjorn Andersson, Andy Gross, Stephen Boyd,
Stephan Gerhold, Olof Johansson, Linux PM list
On Mon, Dec 16, 2019 at 2:58 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 12/12/2019 11:38, Amit Kucheria wrote:
> > In order for the old DTBs to continue working, the new interrupt code
> > must not return an error if interrupts are not defined. Don't return an
> > error in case of -ENXIO.
> >
> > Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support")
> > Suggested-by: Stephan Gerhold <stephan@gerhold.net>
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
>
> Applied.
Hi Daniel,
I haven't seen this fix until -rc4. Do you plan to send it?
Regards,
Amit
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers: thermal: tsens: Work with old DTBs
2020-01-01 21:15 ` Amit Kucheria
@ 2020-01-01 21:44 ` Daniel Lezcano
2020-01-01 22:02 ` Amit Kucheria
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Lezcano @ 2020-01-01 21:44 UTC (permalink / raw)
To: Amit Kucheria
Cc: LKML, linux-arm-msm, Bjorn Andersson, Andy Gross, Stephen Boyd,
Stephan Gerhold, Olof Johansson, Linux PM list
On 01/01/2020 22:15, Amit Kucheria wrote:
> On Mon, Dec 16, 2019 at 2:58 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 12/12/2019 11:38, Amit Kucheria wrote:
>>> In order for the old DTBs to continue working, the new interrupt code
>>> must not return an error if interrupts are not defined. Don't return an
>>> error in case of -ENXIO.
>>>
>>> Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support")
>>> Suggested-by: Stephan Gerhold <stephan@gerhold.net>
>>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
>>
>> Applied.
>
> Hi Daniel,
>
> I haven't seen this fix until -rc4. Do you plan to send it?
Hi Amit,
right, I've put it in the thermal/linux-next branch. I'll move it to
thermal/fixes and send a PR tomorrow.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers: thermal: tsens: Work with old DTBs
2020-01-01 21:44 ` Daniel Lezcano
@ 2020-01-01 22:02 ` Amit Kucheria
0 siblings, 0 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-01-01 22:02 UTC (permalink / raw)
To: Daniel Lezcano
Cc: LKML, linux-arm-msm, Bjorn Andersson, Andy Gross, Stephen Boyd,
Stephan Gerhold, Olof Johansson, Linux PM list
On Thu, Jan 2, 2020 at 3:14 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> On 01/01/2020 22:15, Amit Kucheria wrote:
> > On Mon, Dec 16, 2019 at 2:58 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 12/12/2019 11:38, Amit Kucheria wrote:
> >>> In order for the old DTBs to continue working, the new interrupt code
> >>> must not return an error if interrupts are not defined. Don't return an
> >>> error in case of -ENXIO.
> >>>
> >>> Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support")
> >>> Suggested-by: Stephan Gerhold <stephan@gerhold.net>
> >>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> >>
> >> Applied.
> >
> > Hi Daniel,
> >
> > I haven't seen this fix until -rc4. Do you plan to send it?
>
> Hi Amit,
>
> right, I've put it in the thermal/linux-next branch. I'll move it to
> thermal/fixes and send a PR tomorrow.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-01 22:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1576146898.git.amit.kucheria@linaro.org>
2019-12-12 10:38 ` [PATCH v2] drivers: thermal: tsens: Work with old DTBs Amit Kucheria
2019-12-12 23:46 ` Bjorn Andersson
2019-12-16 9:28 ` Daniel Lezcano
2020-01-01 21:15 ` Amit Kucheria
2020-01-01 21:44 ` Daniel Lezcano
2020-01-01 22:02 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).