* [PATCH 00/38] media sparse/smatch warn fixes
@ 2020-09-02 16:10 Mauro Carvalho Chehab
2020-09-02 16:10 ` [PATCH 06/38] media: venus: place extern venus_fw_debug on a header file Mauro Carvalho Chehab
2020-09-07 10:17 ` [PATCH 00/38] media sparse/smatch warn fixes Hans Verkuil
0 siblings, 2 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2020-09-02 16:10 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Sean Young, Andrew Morton,
Laurent Pinchart, linux-kernel, Arnd Bergmann,
Niklas Söderlund, Nicolas Boichat, Stanimir Varbanov,
Mike Rapoport, Michel Lespinasse, linux-media, Allen Pais,
Bjorn Andersson, Greg Kroah-Hartman, Sakari Ailus,
Nathan Chancellor, Forest Crossman, Hans Verkuil, Hans Verkuil,
Colin Ian King, Antti Palosaari, Romain Perier, linux-arm-msm,
Andy Gross, Vandana BN, devel, Takashi Iwai, John Hubbard,
Andy Shevchenko
While I was lately relying on Jenkins to report smatch/sparse issues,
I discovered this week that the reports were missing such warnings
I got it fixed already at builder.linuxtv.org, but there are several new
warnings that got added over time.
This series is meant to solve the ones that are reported on x86_64
without pre-building the smatch database.
It should allow receiving cleaner error reports.
While most of the patches are meant to shut up the static analizers,
some contain real bug fixes.
Mauro Carvalho Chehab (38):
media: tda10086: cleanup symbol_rate setting logic
media: v4l2-ioctl: avoid memory leaks on some time32 compat functions
media: qt1010: fix usage of unititialized value
media: av7110_v4l: avoid a typecast
media: wl128x: get rid of a potential spectre issue
media: venus: place extern venus_fw_debug on a header file
media: tda10021: avoid casts when using symbol_rate
media: serial_ir: use the right type for a dma address
media: vivid: move the detection part out of vivid_create_instance
media: vivid: place the logic which disables ioctl on a separate
function
media: vivid: move set_capabilities logic to a separate function
media: vivid: place dt timings init code on a separate function
media: vivid: move the create queues to a separate function
media: vivid: move the devnode creation logic to a separate function
media: vivid: fix error path
media: videobuf-dma-sg: number of pages should be unsigned long
media: cx25821-alsa: number of pages should be unsigned long
media: cx23885-alsa: number of pages should be unsigned long
media: cx88-alsa: number of pages should be unsigned long
media: saa7134-alsa.c: number of pages should be unsigned long
media: dvb-ttusb-budget: don't use stack for USB transfers
media: dvb-ttusb-budget: cleanup printk logic
media: saa7134: avoid a shift overflow
media: atomisp: fix casts at atomisp_compat_ioctl32.c
media: atomisp: get rid of some unused code
media: atomisp: cleanup ifdefs from ia_css_debug.c
media: atomisp: get rid of version-dependent globals
media: atomisp: get rid of isys_dma.h and isys_dma_local.h
media: atomisp: get rid of ibuf_ctrl abstraction
media: atomisp: don't check for ISP version for includes
media: atomisp: unify INPUT error return type
media: atomisp: de-duplicate names at *_input_system_global.h
media: atomisp: reorder functions at pixelgen_private.h
media: atomisp: remove compile-time tests from input_system_global.h
media: atomisp: fix some bad indents
media: atomisp: csi_rx.c: add a missing includes
media: atomisp: atomisp_gmin_platform: check before use
media: atomisp: cleanup isys_irq headers
drivers/media/dvb-frontends/tda10021.c | 38 +-
drivers/media/dvb-frontends/tda10086.c | 22 +-
drivers/media/pci/cx23885/cx23885-alsa.c | 7 +-
drivers/media/pci/cx23885/cx23885.h | 4 +-
drivers/media/pci/cx25821/cx25821-alsa.c | 11 +-
drivers/media/pci/cx88/cx88-alsa.c | 13 +-
drivers/media/pci/saa7134/saa7134-alsa.c | 7 +-
drivers/media/pci/saa7134/saa7134-tvaudio.c | 3 +-
drivers/media/pci/saa7134/saa7134.h | 2 +-
drivers/media/pci/ttpci/av7110_v4l.c | 4 +-
drivers/media/platform/qcom/venus/core.h | 2 +
drivers/media/platform/qcom/venus/dbgfs.c | 2 -
drivers/media/radio/wl128x/fmdrv_common.c | 16 +-
drivers/media/rc/serial_ir.c | 2 +-
drivers/media/test-drivers/vivid/vivid-core.c | 645 ++++++------
drivers/media/tuners/qt1010.c | 25 +-
.../media/usb/ttusb-budget/dvb-ttusb-budget.c | 197 ++--
drivers/media/v4l2-core/v4l2-ioctl.c | 48 +-
drivers/media/v4l2-core/videobuf-dma-sg.c | 22 +-
drivers/staging/media/atomisp/Makefile | 12 +-
.../atomisp/pci/atomisp_compat_ioctl32.c | 84 +-
.../media/atomisp/pci/atomisp_gmin_platform.c | 5 +-
.../atomisp/pci/css_2401_system/host/csi_rx.c | 1 +
.../pci/css_2401_system/host/ibuf_ctrl.c | 1 +
.../css_2401_system/host/ibuf_ctrl_local.h | 1 +
.../css_2401_system/host/ibuf_ctrl_private.h | 268 -----
.../pci/css_2401_system/host/isys_dma.c | 10 +-
.../pci/css_2401_system/host/isys_dma_local.h | 21 -
.../css_2401_system/host/isys_dma_private.h | 12 +-
.../pci/css_2401_system/host/isys_irq.c | 3 +-
.../pci/css_2401_system/host/isys_irq_local.h | 4 +-
.../css_2401_system/host/isys_irq_private.h | 12 +-
.../css_2401_system/host/pixelgen_private.h | 73 +-
.../pci/css_2401_system/ibuf_ctrl_global.h | 6 +-
.../pci/css_2401_system/isys_irq_global.h | 4 +-
.../pci/css_2401_system/pixelgen_global.h | 8 +-
.../host/input_formatter.c | 2 +-
.../hive_isp_css_common/host/input_system.c | 70 +-
.../hive_isp_css_include/host/csi_rx_public.h | 4 +-
.../host/ibuf_ctrl_public.h | 94 --
.../host/isys_dma_public.h | 8 +-
.../host/isys_irq_public.h | 29 +-
.../hive_isp_css_include/host/isys_public.h | 4 +-
.../host/pixelgen_public.h | 4 +-
.../pci/hive_isp_css_include/ibuf_ctrl.h | 47 -
.../pci/hive_isp_css_include/isys_dma.h | 47 -
.../pci/hive_isp_css_include/isys_irq.h | 16 +-
drivers/staging/media/atomisp/pci/hmm/hmm.c | 6 +-
.../staging/media/atomisp/pci/ia_css_mipi.h | 2 -
.../staging/media/atomisp/pci/ia_css_stream.h | 4 +-
.../media/atomisp/pci/input_system_global.h | 29 +-
.../kernels/ctc/ctc_1.0/ia_css_ctc_param.h | 7 -
.../ctc/ctc_1.0/ia_css_ctc_table.host.c | 145 ---
.../kernels/gc/gc_1.0/ia_css_gc_table.host.c | 144 ---
.../kernels/gc/gc_2/ia_css_gc2_table.host.c | 53 -
.../isp/kernels/raw/raw_1.0/ia_css_raw.host.c | 4 +-
.../kernels/xnr/xnr_1.0/ia_css_xnr_param.h | 7 -
.../xnr/xnr_1.0/ia_css_xnr_table.host.c | 31 -
.../atomisp/pci/isp2400_input_system_global.h | 21 +-
.../atomisp/pci/isp2400_input_system_local.h | 17 +-
.../atomisp/pci/isp2400_input_system_public.h | 26 +-
.../media/atomisp/pci/isp2400_system_global.h | 16 -
.../atomisp/pci/isp2401_input_system_global.h | 30 +-
.../atomisp/pci/isp2401_input_system_local.h | 3 -
.../pci/isp2401_input_system_private.h | 224 ++++-
.../media/atomisp/pci/isp2401_system_global.h | 19 -
.../atomisp/pci/runtime/binary/src/binary.c | 919 +++++++++---------
.../runtime/bufq/interface/ia_css_bufq_comm.h | 10 -
.../media/atomisp/pci/runtime/bufq/src/bufq.c | 26 +-
.../runtime/debug/interface/ia_css_debug.h | 6 -
.../pci/runtime/debug/src/ia_css_debug.c | 193 +---
.../atomisp/pci/runtime/ifmtr/src/ifmtr.c | 2 +-
.../pci/runtime/inputfifo/src/inputfifo.c | 10 -
.../pci/runtime/isys/interface/ia_css_isys.h | 18 +-
.../runtime/isys/interface/ia_css_isys_comm.h | 4 +-
.../pci/runtime/isys/src/csi_rx_rmgr.c | 2 +-
.../pci/runtime/isys/src/isys_dma_rmgr.c | 2 +-
.../atomisp/pci/runtime/isys/src/isys_init.c | 20 +-
.../runtime/isys/src/isys_stream2mmio_rmgr.c | 2 +-
.../media/atomisp/pci/runtime/isys/src/rx.c | 24 +-
.../pci/runtime/isys/src/virtual_isys.c | 58 +-
.../pipeline/interface/ia_css_pipeline.h | 2 +-
.../pci/runtime/pipeline/src/pipeline.c | 4 +-
drivers/staging/media/atomisp/pci/sh_css.c | 296 ++----
.../staging/media/atomisp/pci/sh_css_defs.h | 4 -
.../staging/media/atomisp/pci/sh_css_hrt.c | 4 -
.../media/atomisp/pci/sh_css_internal.h | 36 +-
.../staging/media/atomisp/pci/sh_css_mipi.c | 34 +-
.../media/atomisp/pci/sh_css_param_shading.c | 2 +-
.../staging/media/atomisp/pci/sh_css_params.c | 538 ----------
.../media/atomisp/pci/sh_css_properties.c | 10 -
drivers/staging/media/atomisp/pci/sh_css_sp.c | 39 +-
drivers/staging/media/atomisp/pci/sh_css_sp.h | 8 +-
.../staging/media/atomisp/pci/sh_css_struct.h | 2 -
.../staging/media/atomisp/pci/system_global.h | 23 -
include/media/videobuf-dma-sg.h | 2 +-
96 files changed, 1708 insertions(+), 3300 deletions(-)
delete mode 100644 drivers/staging/media/atomisp/pci/css_2401_system/host/ibuf_ctrl_private.h
delete mode 100644 drivers/staging/media/atomisp/pci/css_2401_system/host/isys_dma_local.h
delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/host/ibuf_ctrl_public.h
delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/ibuf_ctrl.h
delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/isys_dma.h
delete mode 100644 drivers/staging/media/atomisp/pci/isp2400_system_global.h
delete mode 100644 drivers/staging/media/atomisp/pci/isp2401_system_global.h
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 06/38] media: venus: place extern venus_fw_debug on a header file
2020-09-02 16:10 [PATCH 00/38] media sparse/smatch warn fixes Mauro Carvalho Chehab
@ 2020-09-02 16:10 ` Mauro Carvalho Chehab
2020-09-10 10:45 ` Stanimir Varbanov
2020-09-07 10:17 ` [PATCH 00/38] media sparse/smatch warn fixes Hans Verkuil
1 sibling, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2020-09-02 16:10 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Stanimir Varbanov, Andy Gross,
Bjorn Andersson, linux-media, linux-arm-msm, linux-kernel
Sparse warns about this symbol:
drivers/media/platform/qcom/venus/hfi_venus.c:133:5: warning: symbol 'venus_fw_debug' was not declared. Should it be static?
Because hfi_venus.c doesn't include a header file with the
extern. So, move it to core.h, with is included by both
hfi_venus.c and dbgfs.c.
This way, if something changes with it, warnings or errors
will be produced.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/media/platform/qcom/venus/core.h | 2 ++
drivers/media/platform/qcom/venus/dbgfs.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
index 8e75a199f9f7..1a7aee7ee628 100644
--- a/drivers/media/platform/qcom/venus/core.h
+++ b/drivers/media/platform/qcom/venus/core.h
@@ -24,6 +24,8 @@
#define VIDC_VCODEC_CLKS_NUM_MAX 2
#define VIDC_PMDOMAINS_NUM_MAX 3
+extern int venus_fw_debug;
+
struct freq_tbl {
unsigned int load;
unsigned long freq;
diff --git a/drivers/media/platform/qcom/venus/dbgfs.c b/drivers/media/platform/qcom/venus/dbgfs.c
index 782d54ac1b8f..52de47f2ca88 100644
--- a/drivers/media/platform/qcom/venus/dbgfs.c
+++ b/drivers/media/platform/qcom/venus/dbgfs.c
@@ -7,8 +7,6 @@
#include "core.h"
-extern int venus_fw_debug;
-
void venus_dbgfs_init(struct venus_core *core)
{
core->root = debugfs_create_dir("venus", NULL);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 00/38] media sparse/smatch warn fixes
2020-09-02 16:10 [PATCH 00/38] media sparse/smatch warn fixes Mauro Carvalho Chehab
2020-09-02 16:10 ` [PATCH 06/38] media: venus: place extern venus_fw_debug on a header file Mauro Carvalho Chehab
@ 2020-09-07 10:17 ` Hans Verkuil
1 sibling, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2020-09-07 10:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Sean Young, Andrew Morton, Laurent Pinchart, linux-kernel,
Arnd Bergmann, Niklas Söderlund, Nicolas Boichat,
Stanimir Varbanov, Mike Rapoport, Michel Lespinasse, linux-media,
Allen Pais, Bjorn Andersson, Greg Kroah-Hartman, Sakari Ailus,
Nathan Chancellor, Forest Crossman, Hans Verkuil, Colin Ian King,
Antti Palosaari, Romain Perier, linux-arm-msm, Andy Gross,
Vandana BN, devel, Takashi Iwai, John Hubbard, Andy Shevchenko
On 02/09/2020 18:10, Mauro Carvalho Chehab wrote:
> While I was lately relying on Jenkins to report smatch/sparse issues,
> I discovered this week that the reports were missing such warnings
>
> I got it fixed already at builder.linuxtv.org, but there are several new
> warnings that got added over time.
>
> This series is meant to solve the ones that are reported on x86_64
> without pre-building the smatch database.
>
> It should allow receiving cleaner error reports.
>
> While most of the patches are meant to shut up the static analizers,
> some contain real bug fixes.
>
> Mauro Carvalho Chehab (38):
> media: tda10086: cleanup symbol_rate setting logic
> media: v4l2-ioctl: avoid memory leaks on some time32 compat functions
> media: qt1010: fix usage of unititialized value
> media: av7110_v4l: avoid a typecast
> media: wl128x: get rid of a potential spectre issue
> media: venus: place extern venus_fw_debug on a header file
> media: tda10021: avoid casts when using symbol_rate
> media: serial_ir: use the right type for a dma address
> media: vivid: move the detection part out of vivid_create_instance
> media: vivid: place the logic which disables ioctl on a separate
> function
> media: vivid: move set_capabilities logic to a separate function
> media: vivid: place dt timings init code on a separate function
> media: vivid: move the create queues to a separate function
> media: vivid: move the devnode creation logic to a separate function
> media: vivid: fix error path
For these vivid patches and after fixing the "unused variable 'i'" warning
as reported by the kernel test robot:
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Thank you for working on this!
Regards,
Hans
> media: videobuf-dma-sg: number of pages should be unsigned long
> media: cx25821-alsa: number of pages should be unsigned long
> media: cx23885-alsa: number of pages should be unsigned long
> media: cx88-alsa: number of pages should be unsigned long
> media: saa7134-alsa.c: number of pages should be unsigned long
> media: dvb-ttusb-budget: don't use stack for USB transfers
> media: dvb-ttusb-budget: cleanup printk logic
> media: saa7134: avoid a shift overflow
> media: atomisp: fix casts at atomisp_compat_ioctl32.c
> media: atomisp: get rid of some unused code
> media: atomisp: cleanup ifdefs from ia_css_debug.c
> media: atomisp: get rid of version-dependent globals
> media: atomisp: get rid of isys_dma.h and isys_dma_local.h
> media: atomisp: get rid of ibuf_ctrl abstraction
> media: atomisp: don't check for ISP version for includes
> media: atomisp: unify INPUT error return type
> media: atomisp: de-duplicate names at *_input_system_global.h
> media: atomisp: reorder functions at pixelgen_private.h
> media: atomisp: remove compile-time tests from input_system_global.h
> media: atomisp: fix some bad indents
> media: atomisp: csi_rx.c: add a missing includes
> media: atomisp: atomisp_gmin_platform: check before use
> media: atomisp: cleanup isys_irq headers
>
> drivers/media/dvb-frontends/tda10021.c | 38 +-
> drivers/media/dvb-frontends/tda10086.c | 22 +-
> drivers/media/pci/cx23885/cx23885-alsa.c | 7 +-
> drivers/media/pci/cx23885/cx23885.h | 4 +-
> drivers/media/pci/cx25821/cx25821-alsa.c | 11 +-
> drivers/media/pci/cx88/cx88-alsa.c | 13 +-
> drivers/media/pci/saa7134/saa7134-alsa.c | 7 +-
> drivers/media/pci/saa7134/saa7134-tvaudio.c | 3 +-
> drivers/media/pci/saa7134/saa7134.h | 2 +-
> drivers/media/pci/ttpci/av7110_v4l.c | 4 +-
> drivers/media/platform/qcom/venus/core.h | 2 +
> drivers/media/platform/qcom/venus/dbgfs.c | 2 -
> drivers/media/radio/wl128x/fmdrv_common.c | 16 +-
> drivers/media/rc/serial_ir.c | 2 +-
> drivers/media/test-drivers/vivid/vivid-core.c | 645 ++++++------
> drivers/media/tuners/qt1010.c | 25 +-
> .../media/usb/ttusb-budget/dvb-ttusb-budget.c | 197 ++--
> drivers/media/v4l2-core/v4l2-ioctl.c | 48 +-
> drivers/media/v4l2-core/videobuf-dma-sg.c | 22 +-
> drivers/staging/media/atomisp/Makefile | 12 +-
> .../atomisp/pci/atomisp_compat_ioctl32.c | 84 +-
> .../media/atomisp/pci/atomisp_gmin_platform.c | 5 +-
> .../atomisp/pci/css_2401_system/host/csi_rx.c | 1 +
> .../pci/css_2401_system/host/ibuf_ctrl.c | 1 +
> .../css_2401_system/host/ibuf_ctrl_local.h | 1 +
> .../css_2401_system/host/ibuf_ctrl_private.h | 268 -----
> .../pci/css_2401_system/host/isys_dma.c | 10 +-
> .../pci/css_2401_system/host/isys_dma_local.h | 21 -
> .../css_2401_system/host/isys_dma_private.h | 12 +-
> .../pci/css_2401_system/host/isys_irq.c | 3 +-
> .../pci/css_2401_system/host/isys_irq_local.h | 4 +-
> .../css_2401_system/host/isys_irq_private.h | 12 +-
> .../css_2401_system/host/pixelgen_private.h | 73 +-
> .../pci/css_2401_system/ibuf_ctrl_global.h | 6 +-
> .../pci/css_2401_system/isys_irq_global.h | 4 +-
> .../pci/css_2401_system/pixelgen_global.h | 8 +-
> .../host/input_formatter.c | 2 +-
> .../hive_isp_css_common/host/input_system.c | 70 +-
> .../hive_isp_css_include/host/csi_rx_public.h | 4 +-
> .../host/ibuf_ctrl_public.h | 94 --
> .../host/isys_dma_public.h | 8 +-
> .../host/isys_irq_public.h | 29 +-
> .../hive_isp_css_include/host/isys_public.h | 4 +-
> .../host/pixelgen_public.h | 4 +-
> .../pci/hive_isp_css_include/ibuf_ctrl.h | 47 -
> .../pci/hive_isp_css_include/isys_dma.h | 47 -
> .../pci/hive_isp_css_include/isys_irq.h | 16 +-
> drivers/staging/media/atomisp/pci/hmm/hmm.c | 6 +-
> .../staging/media/atomisp/pci/ia_css_mipi.h | 2 -
> .../staging/media/atomisp/pci/ia_css_stream.h | 4 +-
> .../media/atomisp/pci/input_system_global.h | 29 +-
> .../kernels/ctc/ctc_1.0/ia_css_ctc_param.h | 7 -
> .../ctc/ctc_1.0/ia_css_ctc_table.host.c | 145 ---
> .../kernels/gc/gc_1.0/ia_css_gc_table.host.c | 144 ---
> .../kernels/gc/gc_2/ia_css_gc2_table.host.c | 53 -
> .../isp/kernels/raw/raw_1.0/ia_css_raw.host.c | 4 +-
> .../kernels/xnr/xnr_1.0/ia_css_xnr_param.h | 7 -
> .../xnr/xnr_1.0/ia_css_xnr_table.host.c | 31 -
> .../atomisp/pci/isp2400_input_system_global.h | 21 +-
> .../atomisp/pci/isp2400_input_system_local.h | 17 +-
> .../atomisp/pci/isp2400_input_system_public.h | 26 +-
> .../media/atomisp/pci/isp2400_system_global.h | 16 -
> .../atomisp/pci/isp2401_input_system_global.h | 30 +-
> .../atomisp/pci/isp2401_input_system_local.h | 3 -
> .../pci/isp2401_input_system_private.h | 224 ++++-
> .../media/atomisp/pci/isp2401_system_global.h | 19 -
> .../atomisp/pci/runtime/binary/src/binary.c | 919 +++++++++---------
> .../runtime/bufq/interface/ia_css_bufq_comm.h | 10 -
> .../media/atomisp/pci/runtime/bufq/src/bufq.c | 26 +-
> .../runtime/debug/interface/ia_css_debug.h | 6 -
> .../pci/runtime/debug/src/ia_css_debug.c | 193 +---
> .../atomisp/pci/runtime/ifmtr/src/ifmtr.c | 2 +-
> .../pci/runtime/inputfifo/src/inputfifo.c | 10 -
> .../pci/runtime/isys/interface/ia_css_isys.h | 18 +-
> .../runtime/isys/interface/ia_css_isys_comm.h | 4 +-
> .../pci/runtime/isys/src/csi_rx_rmgr.c | 2 +-
> .../pci/runtime/isys/src/isys_dma_rmgr.c | 2 +-
> .../atomisp/pci/runtime/isys/src/isys_init.c | 20 +-
> .../runtime/isys/src/isys_stream2mmio_rmgr.c | 2 +-
> .../media/atomisp/pci/runtime/isys/src/rx.c | 24 +-
> .../pci/runtime/isys/src/virtual_isys.c | 58 +-
> .../pipeline/interface/ia_css_pipeline.h | 2 +-
> .../pci/runtime/pipeline/src/pipeline.c | 4 +-
> drivers/staging/media/atomisp/pci/sh_css.c | 296 ++----
> .../staging/media/atomisp/pci/sh_css_defs.h | 4 -
> .../staging/media/atomisp/pci/sh_css_hrt.c | 4 -
> .../media/atomisp/pci/sh_css_internal.h | 36 +-
> .../staging/media/atomisp/pci/sh_css_mipi.c | 34 +-
> .../media/atomisp/pci/sh_css_param_shading.c | 2 +-
> .../staging/media/atomisp/pci/sh_css_params.c | 538 ----------
> .../media/atomisp/pci/sh_css_properties.c | 10 -
> drivers/staging/media/atomisp/pci/sh_css_sp.c | 39 +-
> drivers/staging/media/atomisp/pci/sh_css_sp.h | 8 +-
> .../staging/media/atomisp/pci/sh_css_struct.h | 2 -
> .../staging/media/atomisp/pci/system_global.h | 23 -
> include/media/videobuf-dma-sg.h | 2 +-
> 96 files changed, 1708 insertions(+), 3300 deletions(-)
> delete mode 100644 drivers/staging/media/atomisp/pci/css_2401_system/host/ibuf_ctrl_private.h
> delete mode 100644 drivers/staging/media/atomisp/pci/css_2401_system/host/isys_dma_local.h
> delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/host/ibuf_ctrl_public.h
> delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/ibuf_ctrl.h
> delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/isys_dma.h
> delete mode 100644 drivers/staging/media/atomisp/pci/isp2400_system_global.h
> delete mode 100644 drivers/staging/media/atomisp/pci/isp2401_system_global.h
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 06/38] media: venus: place extern venus_fw_debug on a header file
2020-09-02 16:10 ` [PATCH 06/38] media: venus: place extern venus_fw_debug on a header file Mauro Carvalho Chehab
@ 2020-09-10 10:45 ` Stanimir Varbanov
0 siblings, 0 replies; 4+ messages in thread
From: Stanimir Varbanov @ 2020-09-10 10:45 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Stanimir Varbanov, Andy Gross, Bjorn Andersson, linux-media,
linux-arm-msm, linux-kernel
Hi Mauro,
Thanks for the fix!
On 9/2/20 7:10 PM, Mauro Carvalho Chehab wrote:
> Sparse warns about this symbol:
>
> drivers/media/platform/qcom/venus/hfi_venus.c:133:5: warning: symbol 'venus_fw_debug' was not declared. Should it be static?
>
> Because hfi_venus.c doesn't include a header file with the
> extern. So, move it to core.h, with is included by both
> hfi_venus.c and dbgfs.c.
>
> This way, if something changes with it, warnings or errors
> will be produced.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/media/platform/qcom/venus/core.h | 2 ++
> drivers/media/platform/qcom/venus/dbgfs.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
> index 8e75a199f9f7..1a7aee7ee628 100644
> --- a/drivers/media/platform/qcom/venus/core.h
> +++ b/drivers/media/platform/qcom/venus/core.h
> @@ -24,6 +24,8 @@
> #define VIDC_VCODEC_CLKS_NUM_MAX 2
> #define VIDC_PMDOMAINS_NUM_MAX 3
>
> +extern int venus_fw_debug;
> +
> struct freq_tbl {
> unsigned int load;
> unsigned long freq;
> diff --git a/drivers/media/platform/qcom/venus/dbgfs.c b/drivers/media/platform/qcom/venus/dbgfs.c
> index 782d54ac1b8f..52de47f2ca88 100644
> --- a/drivers/media/platform/qcom/venus/dbgfs.c
> +++ b/drivers/media/platform/qcom/venus/dbgfs.c
> @@ -7,8 +7,6 @@
>
> #include "core.h"
>
> -extern int venus_fw_debug;
> -
> void venus_dbgfs_init(struct venus_core *core)
> {
> core->root = debugfs_create_dir("venus", NULL);
>
--
regards,
Stan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-10 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 16:10 [PATCH 00/38] media sparse/smatch warn fixes Mauro Carvalho Chehab
2020-09-02 16:10 ` [PATCH 06/38] media: venus: place extern venus_fw_debug on a header file Mauro Carvalho Chehab
2020-09-10 10:45 ` Stanimir Varbanov
2020-09-07 10:17 ` [PATCH 00/38] media sparse/smatch warn fixes Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).