linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: skakit@codeaurora.org
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node
Date: Thu, 20 May 2021 11:55:15 +0530	[thread overview]
Message-ID: <f7d2584dfd69d514c8f2aed053204b66@codeaurora.org> (raw)
In-Reply-To: <YKPq84r7soE0yjMA@google.com>

Hi Matthias,

On 2021-05-18 21:57, Matthias Kaehlcke wrote:
> On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote:
>> On 18-05-21, 11:50, satya priya wrote:
>> > Add thermal-zones node for SC7280 SoC.
>> >
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> > ---
>> > Changes in RESEND V4:
>> >  - No Changes.
>> >
>> >  arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > index 2cc4785..2a7d488 100644
>> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > @@ -1125,4 +1125,7 @@
>> >  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
>> >  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>> >  	};
>> > +
>> > +	thermal_zones: thermal-zones {
>> > +	};
>> 
>> Empty node..? what am i missing here...
> 
> The 'thermal-zones' node with the SoC thermal zones is usually created
> in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings
> and device tree nodes for TSENS in SC7280' series
> (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225)
> is creating it, but the series hasn't landed yet.
> 
> The node is needed by other patches in this series that add non-SoC
> thermal zones. Hence either an empty node needs to be added (for now)
> or this series should 'officially' depend on the TSENS series mentioned
> above.

I will add the dependency in cover letter and drop this patch.

Thanks,
Satya Priya

  parent reply	other threads:[~2021-05-20  6:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-18 11:43   ` Vinod Koul
2021-05-20  6:24     ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
2021-05-18 11:44   ` Vinod Koul
2021-05-18 16:27     ` Matthias Kaehlcke
2021-05-18 21:16       ` Dmitry Baryshkov
2021-05-20  6:25       ` skakit [this message]
2021-05-18  6:20 ` [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
2021-05-18 11:46   ` Vinod Koul
2021-05-18 16:42     ` Matthias Kaehlcke
2021-05-20  6:32       ` skakit
2021-05-20  7:20         ` Vinod Koul
2021-05-21 12:22           ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
2021-05-18 11:48   ` Vinod Koul
2021-05-20  6:25     ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 7/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 8/8] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7d2584dfd69d514c8f2aed053204b66@codeaurora.org \
    --to=skakit@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgunda@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --subject='Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).