* [PATCH V5 01/11] arm64: dts: qcom: sm8350: Add label for thermal-zones node
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
@ 2021-05-25 10:10 ` satya priya
2021-05-25 10:10 ` [PATCH V5 02/11] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
` (9 subsequent siblings)
10 siblings, 0 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add label "thermal_zones" for thermal-zones node.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
Changes in V5:
- No Changes.
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index ed0b51b..47c6c0b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1317,7 +1317,7 @@
};
};
- thermal-zones {
+ thermal_zones: thermal-zones {
cpu0-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH V5 02/11] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
2021-05-25 10:10 ` [PATCH V5 01/11] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
@ 2021-05-25 10:10 ` satya priya
2021-05-25 10:10 ` [PATCH V5 03/11] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
` (8 subsequent siblings)
10 siblings, 0 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
Changes in V5:
- No Changes.
arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
new file mode 100644
index 0000000..e7f64a9
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2021, The Linux Foundation. All rights reserved.
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+ pm7325: pmic@1 {
+ compatible = "qcom,pm7325", "qcom,spmi-pmic";
+ reg = <0x1 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pm7325_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ pm7325_gpios: gpios@8800 {
+ compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pm7325_gpios 0 0 10>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+};
+
+&thermal_zones {
+ pm7325_thermal: pm7325-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm7325_temp_alarm>;
+
+ trips {
+ pm7325_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pm7325_crit: pm7325-crit {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH V5 03/11] arm64: dts: qcom: pm8350c: Add temp-alarm support
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
2021-05-25 10:10 ` [PATCH V5 01/11] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-25 10:10 ` [PATCH V5 02/11] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
@ 2021-05-25 10:10 ` satya priya
2021-05-25 10:10 ` [PATCH V5 04/11] arm64: dts: qcom: pm8350c: Correct the GPIO node satya priya
` (7 subsequent siblings)
10 siblings, 0 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add temp-alarm support for PM8350C pmic.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
Changes in V5:
- Split this patch into two. One for adding temp-alarm support and
next one to correct GPIO node.
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index 2b9b75e..f926508 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -13,6 +13,13 @@
#address-cells = <1>;
#size-cells = <0>;
+ pm8350c_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
pm8350c_gpios: gpio@8800 {
compatible = "qcom,pm8350c-gpio";
reg = <0x8800>;
@@ -23,3 +30,25 @@
};
};
};
+
+&thermal_zones {
+ pm8350c_thermal: pm8350c-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm8350c_temp_alarm>;
+
+ trips {
+ pm8350c_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pm8350c_crit: pm8350c-crit {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH V5 04/11] arm64: dts: qcom: pm8350c: Correct the GPIO node
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (2 preceding siblings ...)
2021-05-25 10:10 ` [PATCH V5 03/11] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
@ 2021-05-25 10:10 ` satya priya
2021-05-25 20:53 ` Matthias Kaehlcke
2021-05-25 10:11 ` [PATCH V5 05/11] arm64: dts: qcom: pmr735a: Add temp-alarm support satya priya
` (6 subsequent siblings)
10 siblings, 1 reply; 20+ messages in thread
From: satya priya @ 2021-05-25 10:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.
Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in V5:
- This is split from patch [3/11] and added newly in V5.
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index f926508..e1b75ae 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -21,9 +21,10 @@
};
pm8350c_gpios: gpio@8800 {
- compatible = "qcom,pm8350c-gpio";
+ compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
+ gpio-ranges = <&pm8350c_gpios 0 0 9>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH V5 04/11] arm64: dts: qcom: pm8350c: Correct the GPIO node
2021-05-25 10:10 ` [PATCH V5 04/11] arm64: dts: qcom: pm8350c: Correct the GPIO node satya priya
@ 2021-05-25 20:53 ` Matthias Kaehlcke
0 siblings, 0 replies; 20+ messages in thread
From: Matthias Kaehlcke @ 2021-05-25 20:53 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Lee Jones,
linux-arm-msm, linux-kernel, devicetree, kgunda
On Tue, May 25, 2021 at 03:40:59PM +0530, satya priya wrote:
> Add gpio ranges and correct the compatible to add
> "qcom,spmi-gpio" as this pmic is on spmi bus.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V5:
> - This is split from patch [3/11] and added newly in V5.
isn't the split from patch [4/8]?
https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-5-git-send-email-skakit@codeaurora.org/
> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> index f926508..e1b75ae 100644
> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> @@ -21,9 +21,10 @@
> };
>
> pm8350c_gpios: gpio@8800 {
> - compatible = "qcom,pm8350c-gpio";
> + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
> reg = <0x8800>;
> gpio-controller;
> + gpio-ranges = <&pm8350c_gpios 0 0 9>;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH V5 05/11] arm64: dts: qcom: pmr735a: Add temp-alarm support
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (3 preceding siblings ...)
2021-05-25 10:10 ` [PATCH V5 04/11] arm64: dts: qcom: pm8350c: Correct the GPIO node satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 10:11 ` [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node satya priya
` (5 subsequent siblings)
10 siblings, 0 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add temp-alarm support for PMR735A pmic.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
Changes in V5:
- Split this patch into two. One for adding temp-alarm support and
next one to correct GPIO node.
arch/arm64/boot/dts/qcom/pmr735a.dtsi | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
index 1c675af1..b0a7cd6c0 100644
--- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
@@ -13,6 +13,13 @@
#address-cells = <1>;
#size-cells = <0>;
+ pmr735a_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x4 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
pmr735a_gpios: gpio@8800 {
compatible = "qcom,pmr735a-gpio";
reg = <0x8800>;
@@ -23,3 +30,25 @@
};
};
};
+
+&thermal_zones {
+ pmr735a_thermal: pmr735a-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pmr735a_temp_alarm>;
+
+ trips {
+ pmr735a_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pmr735a_crit: pmr735a-crit {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (4 preceding siblings ...)
2021-05-25 10:11 ` [PATCH V5 05/11] arm64: dts: qcom: pmr735a: Add temp-alarm support satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 20:56 ` Matthias Kaehlcke
2021-05-25 10:11 ` [PATCH V5 07/11] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
` (4 subsequent siblings)
10 siblings, 1 reply; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.
Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in V5:
- This is split from patch [5/11] and added newly in V5.
arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
index b0a7cd6c0..b4b6ba24 100644
--- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
@@ -21,9 +21,10 @@
};
pmr735a_gpios: gpio@8800 {
- compatible = "qcom,pmr735a-gpio";
+ compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
+ gpio-ranges = <&pmr735a_gpios 0 0 4>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node
2021-05-25 10:11 ` [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node satya priya
@ 2021-05-25 20:56 ` Matthias Kaehlcke
2021-05-26 3:59 ` skakit
0 siblings, 1 reply; 20+ messages in thread
From: Matthias Kaehlcke @ 2021-05-25 20:56 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Lee Jones,
linux-arm-msm, linux-kernel, devicetree, kgunda
On Tue, May 25, 2021 at 03:41:01PM +0530, satya priya wrote:
> Add gpio ranges and correct the compatible to add
> "qcom,spmi-gpio" as this pmic is on spmi bus.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V5:
> - This is split from patch [5/11] and added newly in V5.
actually it's a split from patch [5/8], right?
https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-6-git-send-email-skakit@codeaurora.org/
> arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
> index b0a7cd6c0..b4b6ba24 100644
> --- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
> @@ -21,9 +21,10 @@
> };
>
> pmr735a_gpios: gpio@8800 {
> - compatible = "qcom,pmr735a-gpio";
> + compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
> reg = <0x8800>;
> gpio-controller;
> + gpio-ranges = <&pmr735a_gpios 0 0 4>;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node
2021-05-25 20:56 ` Matthias Kaehlcke
@ 2021-05-26 3:59 ` skakit
0 siblings, 0 replies; 20+ messages in thread
From: skakit @ 2021-05-26 3:59 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Lee Jones,
linux-arm-msm, linux-kernel, devicetree, kgunda
On 2021-05-26 02:26, Matthias Kaehlcke wrote:
> On Tue, May 25, 2021 at 03:41:01PM +0530, satya priya wrote:
>> Add gpio ranges and correct the compatible to add
>> "qcom,spmi-gpio" as this pmic is on spmi bus.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> ---
>> Changes in V5:
>> - This is split from patch [5/11] and added newly in V5.
>
> actually it's a split from patch [5/8], right?
>
Right, my bad. I should have mentioned this way to be more clear.
Thank you for reviewing the patches!
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-6-git-send-email-skakit@codeaurora.org/
>
>> arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> index b0a7cd6c0..b4b6ba24 100644
>> --- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> @@ -21,9 +21,10 @@
>> };
>>
>> pmr735a_gpios: gpio@8800 {
>> - compatible = "qcom,pmr735a-gpio";
>> + compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
>> reg = <0x8800>;
>> gpio-controller;
>> + gpio-ranges = <&pmr735a_gpios 0 0 4>;
>> #gpio-cells = <2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH V5 07/11] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (5 preceding siblings ...)
2021-05-25 10:11 ` [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 10:11 ` [PATCH V5 08/11] arm64: dts: qcom: pmk8350: Correct the GPIO node satya priya
` (3 subsequent siblings)
10 siblings, 0 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add PON, RTC, VADC and ACD_TM support for PMK8350.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
Changes in V5:
- Split this patch into two. One for adding pmk8350 peripherals and
next one to correct GPIO node.
arch/arm64/boot/dts/qcom/pmk8350.dtsi | 48 +++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
index 1530b8f..ecd5ccd 100644
--- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
@@ -3,6 +3,8 @@
* Copyright (c) 2021, Linaro Limited
*/
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
@@ -13,6 +15,52 @@
#address-cells = <1>;
#size-cells = <0>;
+ pmk8350_pon: pon@1300 {
+ compatible = "qcom,pm8998-pon";
+ reg = <0x1300>;
+
+ pwrkey {
+ compatible = "qcom,pmk8350-pwrkey";
+ interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
+ linux,code = <KEY_POWER>;
+ };
+
+ resin {
+ compatible = "qcom,pmk8350-resin";
+ interrupts = <0x0 0x13 0x6 IRQ_TYPE_EDGE_BOTH>;
+ linux,code = <KEY_VOLUMEDOWN>;
+ };
+ };
+
+ pmk8350_vadc: adc@3100 {
+ compatible = "qcom,spmi-adc7";
+ reg = <0x3100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "eoc-int-en-set";
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+ };
+
+ pmk8350_adc_tm: adc-tm@3400 {
+ compatible = "qcom,adc-tm7";
+ reg = <0x3400>;
+ interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "threshold";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ #thermal-sensor-cells = <1>;
+ status = "disabled";
+ };
+
+ pmk8350_rtc: rtc@6100 {
+ compatible = "qcom,pmk8350-rtc";
+ reg = <0x6100>, <0x6200>;
+ reg-names = "rtc", "alarm";
+ interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
+ };
+
pmk8350_gpios: gpio@b000 {
compatible = "qcom,pmk8350-gpio";
reg = <0xb000>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH V5 08/11] arm64: dts: qcom: pmk8350: Correct the GPIO node
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (6 preceding siblings ...)
2021-05-25 10:11 ` [PATCH V5 07/11] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 21:00 ` Matthias Kaehlcke
2021-05-25 10:11 ` [PATCH V5 09/11] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
` (2 subsequent siblings)
10 siblings, 1 reply; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.
Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in V5:
- This is split from patch [7/11] and added newly in V5.
arch/arm64/boot/dts/qcom/pmk8350.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
index ecd5ccd..04fc263 100644
--- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
@@ -62,9 +62,10 @@
};
pmk8350_gpios: gpio@b000 {
- compatible = "qcom,pmk8350-gpio";
+ compatible = "qcom,pmk8350-gpio", "qcom,spmi-gpio";
reg = <0xb000>;
gpio-controller;
+ gpio-ranges = <&pmk8350_gpios 0 0 4>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH V5 08/11] arm64: dts: qcom: pmk8350: Correct the GPIO node
2021-05-25 10:11 ` [PATCH V5 08/11] arm64: dts: qcom: pmk8350: Correct the GPIO node satya priya
@ 2021-05-25 21:00 ` Matthias Kaehlcke
0 siblings, 0 replies; 20+ messages in thread
From: Matthias Kaehlcke @ 2021-05-25 21:00 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Lee Jones,
linux-arm-msm, linux-kernel, devicetree, kgunda
On Tue, May 25, 2021 at 03:41:03PM +0530, satya priya wrote:
> Add gpio ranges and correct the compatible to add
> "qcom,spmi-gpio" as this pmic is on spmi bus.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V5:
> - This is split from patch [7/11] and added newly in V5.
this should say 'patch [6/8]' I think.
https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-7-git-send-email-skakit@codeaurora.org/
> arch/arm64/boot/dts/qcom/pmk8350.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> index ecd5ccd..04fc263 100644
> --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> @@ -62,9 +62,10 @@
> };
>
> pmk8350_gpios: gpio@b000 {
> - compatible = "qcom,pmk8350-gpio";
> + compatible = "qcom,pmk8350-gpio", "qcom,spmi-gpio";
> reg = <0xb000>;
> gpio-controller;
> + gpio-ranges = <&pmk8350_gpios 0 0 4>;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH V5 09/11] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (7 preceding siblings ...)
2021-05-25 10:11 ` [PATCH V5 08/11] arm64: dts: qcom: pmk8350: Correct the GPIO node satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 21:03 ` Matthias Kaehlcke
2021-05-25 10:11 ` [PATCH V5 10/11] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya
2021-05-25 10:11 ` [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants satya priya
10 siblings, 1 reply; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
The sc7280-idp has four PMICs, include their .dtsi files.
Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in RESEND V4:
- As per Matthias comments moved this patch before 'Add ADC channel nodes
for PMIC temperatures to sc7280-idp'
Changes in V5:
- No changes.
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 54d2cb3..f295580 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -8,6 +8,10 @@
/dts-v1/;
#include "sc7280.dtsi"
+#include "pm7325.dtsi"
+#include "pmr735a.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"
/ {
model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH V5 09/11] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp
2021-05-25 10:11 ` [PATCH V5 09/11] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
@ 2021-05-25 21:03 ` Matthias Kaehlcke
0 siblings, 0 replies; 20+ messages in thread
From: Matthias Kaehlcke @ 2021-05-25 21:03 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Lee Jones,
linux-arm-msm, linux-kernel, devicetree, kgunda
On Tue, May 25, 2021 at 03:41:04PM +0530, satya priya wrote:
> The sc7280-idp has four PMICs, include their .dtsi files.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in RESEND V4:
> - As per Matthias comments moved this patch before 'Add ADC channel nodes
> for PMIC temperatures to sc7280-idp'
>
> Changes in V5:
> - No changes.
>
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 54d2cb3..f295580 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -8,6 +8,10 @@
> /dts-v1/;
>
> #include "sc7280.dtsi"
> +#include "pm7325.dtsi"
> +#include "pmr735a.dtsi"
> +#include "pm8350c.dtsi"
> +#include "pmk8350.dtsi"
>
> / {
> model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH V5 10/11] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (8 preceding siblings ...)
2021-05-25 10:11 ` [PATCH V5 09/11] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 10:11 ` [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants satya priya
10 siblings, 0 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add channel nodes for the on die temperatures of PMICS
pmk8350, pm8350, pmr735a and pmr735b.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- As per Matthias comments, changed the commit text.
Changes in V5:
- No Changes.
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index f295580..704fb9a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -7,6 +7,10 @@
/dts-v1/;
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include "sc7280.dtsi"
#include "pm7325.dtsi"
#include "pmr735a.dtsi"
@@ -238,6 +242,32 @@
};
};
+&pmk8350_vadc {
+ pm8350_die_temp {
+ reg = <PM8350_ADC7_DIE_TEMP>;
+ label = "pm8350_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmk8350_die_temp {
+ reg = <PMK8350_ADC7_DIE_TEMP>;
+ label = "pmk8350_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmr735a_die_temp {
+ reg = <PMR735A_ADC7_DIE_TEMP>;
+ label = "pmr735a_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmr735b_die_temp {
+ reg = <PMR735B_ADC7_DIE_TEMP>;
+ label = "pmr735b_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants
2021-05-25 10:10 [PATCH V5 00/11] Add PMIC DT files for sc7280 satya priya
` (9 preceding siblings ...)
2021-05-25 10:11 ` [PATCH V5 10/11] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya
@ 2021-05-25 10:11 ` satya priya
2021-05-25 17:05 ` Bjorn Andersson
2021-06-01 15:23 ` Lee Jones
10 siblings, 2 replies; 20+ messages in thread
From: satya priya @ 2021-05-25 10:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, Lee Jones, linux-arm-msm, linux-kernel, devicetree, kgunda,
satya priya
Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.
Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in V5:
- Newly added in V5 to add documentation support for pmics of this series.
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
index 79367a4..5ef79bf 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
@@ -34,6 +34,10 @@ Required properties:
"qcom,pm8998",
"qcom,pmi8998",
"qcom,pm8005",
+ "qcom,pm8350c",
+ "qcom,pmk8350",
+ "qcom,pm7325",
+ "qcom,pmr735a",
or generalized "qcom,spmi-pmic".
- reg: Specifies the SPMI USID slave address for this device.
For more information see:
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants
2021-05-25 10:11 ` [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants satya priya
@ 2021-05-25 17:05 ` Bjorn Andersson
2021-05-26 7:27 ` Lee Jones
2021-06-01 15:23 ` Lee Jones
1 sibling, 1 reply; 20+ messages in thread
From: Bjorn Andersson @ 2021-05-25 17:05 UTC (permalink / raw)
To: Lee Jones, satya priya
Cc: Andy Gross, Rob Herring, mka, linux-arm-msm, linux-kernel,
devicetree, kgunda
On Tue 25 May 05:11 CDT 2021, satya priya wrote:
> Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
@Lee, will you take this patch through the mfd tree?
Regards,
Bjorn
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V5:
> - Newly added in V5 to add documentation support for pmics of this series.
>
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> index 79367a4..5ef79bf 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> @@ -34,6 +34,10 @@ Required properties:
> "qcom,pm8998",
> "qcom,pmi8998",
> "qcom,pm8005",
> + "qcom,pm8350c",
> + "qcom,pmk8350",
> + "qcom,pm7325",
> + "qcom,pmr735a",
> or generalized "qcom,spmi-pmic".
> - reg: Specifies the SPMI USID slave address for this device.
> For more information see:
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants
2021-05-25 17:05 ` Bjorn Andersson
@ 2021-05-26 7:27 ` Lee Jones
0 siblings, 0 replies; 20+ messages in thread
From: Lee Jones @ 2021-05-26 7:27 UTC (permalink / raw)
To: Bjorn Andersson
Cc: satya priya, Andy Gross, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On Tue, 25 May 2021, Bjorn Andersson wrote:
> On Tue 25 May 05:11 CDT 2021, satya priya wrote:
>
> > Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.
> >
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> @Lee, will you take this patch through the mfd tree?
I will.
Not sure if Rob would like to review it too - it's pretty simple.
> > Signed-off-by: satya priya <skakit@codeaurora.org>
> > ---
> > Changes in V5:
> > - Newly added in V5 to add documentation support for pmics of this series.
> >
> > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > index 79367a4..5ef79bf 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > @@ -34,6 +34,10 @@ Required properties:
> > "qcom,pm8998",
> > "qcom,pmi8998",
> > "qcom,pm8005",
> > + "qcom,pm8350c",
> > + "qcom,pmk8350",
> > + "qcom,pm7325",
> > + "qcom,pmr735a",
> > or generalized "qcom,spmi-pmic".
> > - reg: Specifies the SPMI USID slave address for this device.
> > For more information see:
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants
2021-05-25 10:11 ` [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants satya priya
2021-05-25 17:05 ` Bjorn Andersson
@ 2021-06-01 15:23 ` Lee Jones
1 sibling, 0 replies; 20+ messages in thread
From: Lee Jones @ 2021-06-01 15:23 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On Tue, 25 May 2021, satya priya wrote:
> Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V5:
> - Newly added in V5 to add documentation support for pmics of this series.
>
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 20+ messages in thread