[PATCH v3 0/2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750

[PATCH v3 0/2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750

[Manikanta Pubbisetty]

Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
WiFi hardware on SC7280 SoC.

Manikanta Pubbisetty (2):
  dt-bindings: qcom: smp2p: Add WPSS node names to pattern property
  arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
---
Changes from V2:
- Added a pre-requisite binding patch to support WPSS sub nodes in the SMP2P node
- Rebased on ToT

Changes from V1:
- Rebased on ToT

 .../devicetree/bindings/soc/qcom/qcom,smp2p.yaml    |  2 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi                | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

-- 
2.38.0

[PATCH v3 1/2] dt-bindings: qcom: smp2p: Add WPSS node names to pattern property

[Manikanta Pubbisetty]

WLAN firmware uses SMP2P protocol in order to talk to the application
processor (AP) in certain cases like WoW (Wake on Wireless). WLAN
firmware runs on the WPSS Q6 processor (Wireless Processor SubSystem).
Therefore it is required to have sub nodes pertaining to the WPSS Q6
processor and the application processor in the SMP2P node.

Add WPSS Q6 (Wireless Processor SubSystem) node names to the pattern
property required for WPSS Q6 processor to communicate to the
application processor and vice versa over SMP2P protocol.

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
index 795bd8cd4104..58500529b90f 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
@@ -60,7 +60,7 @@ properties:
       Two identifiers of the inbound and outbound smem items used for this edge.
 
 patternProperties:
-  "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$":
+  "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$":
     type: object
     description:
       Each SMP2P pair contain a set of inbound and outbound entries, these are
-- 
2.38.0

[PATCH v3 2/2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750

[Manikanta Pubbisetty]

Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
WiFi hardware on SC7280 SoC.

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 212580316d3e..3f6a3f575339 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
+
+		wlan_smp2p_out: wlan-ap-to-wpss {
+			qcom,entry-name = "wlan";
+			#qcom,smem-state-cells = <1>;
+		};
+
+		wlan_smp2p_in: wlan-wpss-to-ap {
+			qcom,entry-name = "wlan";
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
 	};
 
 	pmu {
@@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
 			qcom,rproc = <&remoteproc_wpss>;
 			memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
 			status = "disabled";
+			qcom,smem-states = <&wlan_smp2p_out 0>;
+			qcom,smem-state-names = "wlan-smp2p-out";
 		};
 
 		pcie1: pci@1c08000 {
-- 
2.38.0

Re: [PATCH v3 1/2] dt-bindings: qcom: smp2p: Add WPSS node names to pattern property

[Krzysztof Kozlowski]

On 17/10/2022 08:53, Manikanta Pubbisetty wrote:
> WLAN firmware uses SMP2P protocol in order to talk to the application
> processor (AP) in certain cases like WoW (Wake on Wireless). WLAN
> firmware runs on the WPSS Q6 processor (Wireless Processor SubSystem).
> Therefore it is required to have sub nodes pertaining to the WPSS Q6
> processor and the application processor in the SMP2P node.
> 
> Add WPSS Q6 (Wireless Processor SubSystem) node names to the pattern
> property required for WPSS Q6 processor to communicate to the
> application processor and vice versa over SMP2P protocol.
> 
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: qcom: smp2p: Add WPSS node names to pattern property

[Krzysztof Kozlowski]

On 17/10/2022 22:06, Krzysztof Kozlowski wrote:
> On 17/10/2022 08:53, Manikanta Pubbisetty wrote:
>> WLAN firmware uses SMP2P protocol in order to talk to the application
>> processor (AP) in certain cases like WoW (Wake on Wireless). WLAN
>> firmware runs on the WPSS Q6 processor (Wireless Processor SubSystem).
>> Therefore it is required to have sub nodes pertaining to the WPSS Q6
>> processor and the application processor in the SMP2P node.
>>
>> Add WPSS Q6 (Wireless Processor SubSystem) node names to the pattern
>> property required for WPSS Q6 processor to communicate to the
>> application processor and vice versa over SMP2P protocol.
>>
>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Ah and I almost forgot: thank you for detailed explanation in the commit
msg. Much appreciated!

Best regards,
Krzysztof

Re: (subset) [PATCH v3 0/2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750

[Bjorn Andersson]

On Mon, 17 Oct 2022 18:23:44 +0530, Manikanta Pubbisetty wrote:
> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
> WiFi hardware on SC7280 SoC.
> 
> Manikanta Pubbisetty (2):
> 

Applied, thanks!

[2/2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
      commit: 42582b27dcb1cb60f3601ecac07d3564ce7dc378

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>