linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: audit@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	linux-audit@redhat.com,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] audit: add task history record
Date: Sat, 26 Aug 2023 10:47:45 -0400	[thread overview]
Message-ID: <18a3250b668.28a4.85c95baa4474aabc7814e68940a78392@paul-moore.com> (raw)
In-Reply-To: <6e4603ea-3ce8-5b9e-0ddf-9ec893ddd32e@I-love.SAKURA.ne.jp>

On August 26, 2023 2:38:55 AM Tetsuo Handa 
<penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> On 2023/08/25 12:36, Paul Moore wrote:
>>> It is unfortunate that you continue ignoring the
>>>
>>> How can auditd generate logs that are not triggered via syscalls?
>>>
>>> line. I know how to configure syscall rules using "-S" option. But I do
>>> not know how to configure non syscall rules (such as process creation via
>>> kthread_create(), process termination due to tty hangup or OOM killer).
>>
>> At this point you've exhausted my goodwill so I would suggest simply reading
>> the audit code, manages, and experimenting with a running system to understand
>> how things work, especially for non-syscall records.
>
> Are we on the same page that non-syscall records include process creation via
> kthread_create() and process termination via send_sig() ?

I'm not confident that we are in agreement on many of the issues in this 
thread, some of that is likely due to disagreements in what functionality 
is worthwhile, but I believe some of that is due to misunderstandings.  I'm 
not going to merge the patch you posted at the start of this thread, but as 
I've mentioned *several* times now, if you find a kernel code path that is 
missing an audit logging call submit a patch with an explanation of why the 
audit call is needed and we can discuss it.

My initial thinking is that we do not need, or want, an audit call in 
kthread_create(). I'm less sure about send_sig(), and as my network access 
is limited at the moment I don't have the ability to look into it further 
right now. If you feel we do need an additional audit call, create a patch, 
test it, write a good commit description explaining why it is necessary and 
we can review it.

--
paul-moore.com
>




--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2023-08-26 14:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 10:58 [PATCH] audit: add task history record Tetsuo Handa
2023-08-11 17:50 ` Richard Guy Briggs
2023-08-12 10:08   ` Tetsuo Handa
2023-08-15 18:44 ` Paul Moore
2023-08-16 10:10   ` Tetsuo Handa
2023-08-16 13:53     ` Paul Moore
2023-08-18 10:29       ` Tetsuo Handa
2023-08-18 14:59         ` Paul Moore
2023-08-19  7:09           ` Tetsuo Handa
2023-08-21 16:04             ` Serge E. Hallyn
2023-08-21 22:23               ` Tetsuo Handa
2023-08-21 16:35             ` Paul Moore
2023-08-23 14:18               ` Tetsuo Handa
2023-08-23 14:48                 ` Paul Moore
2023-08-24 13:21                   ` Tetsuo Handa
2023-08-24 13:30                     ` Paul Moore
2023-08-24 13:39                       ` Tetsuo Handa
2023-08-24 13:47                         ` Tetsuo Handa
2023-08-24 14:26                           ` Paul Moore
2023-08-24 22:24                             ` Tetsuo Handa
2023-08-25  3:36                               ` Paul Moore
2023-08-26  6:38                                 ` Tetsuo Handa
2023-08-26 14:47                                   ` Paul Moore [this message]
2023-08-24 14:24                         ` Paul Moore
2023-08-24 15:55                       ` Steve Grubb
2023-08-24 17:02                         ` Paul Moore
2023-08-22 16:29       ` Steve Grubb
2023-08-22 17:58         ` Paul Moore
2023-08-21 17:29 ` Serge Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18a3250b668.28a4.85c95baa4474aabc7814e68940a78392@paul-moore.com \
    --to=paul@paul-moore.com \
    --cc=audit@vger.kernel.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).