From: Richard Guy Briggs <rgb@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: nhorman@tuxdriver.com, linux-api@vger.kernel.org,
containers@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
dhowells@redhat.com,
Linux-Audit Mailing List <linux-audit@redhat.com>,
netfilter-devel@vger.kernel.org, ebiederm@xmission.com,
simo@redhat.com, netdev@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Eric Paris <eparis@parisplace.org>,
mpatel@redhat.com, Serge Hallyn <serge@hallyn.com>
Subject: Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls
Date: Fri, 2 Oct 2020 15:52:31 -0400 [thread overview]
Message-ID: <20201002195231.GH2882171@madcap2.tricolour.ca> (raw)
In-Reply-To: <CAHC9VhRUwCKBjffA_XNSjUwvUn8e6zfmy8WD203dK7R2KD0__g@mail.gmail.com>
On 2020-08-21 15:15, Paul Moore wrote:
> On Wed, Jul 29, 2020 at 3:41 PM Richard Guy Briggs <rgb@redhat.com> wrote:
> > On 2020-07-05 11:10, Paul Moore wrote:
> > > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs <rgb@redhat.com> wrote:
>
> ...
>
> > > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> > > > index f03d3eb0752c..9e79645e5c0e 100644
> > > > --- a/kernel/auditsc.c
> > > > +++ b/kernel/auditsc.c
> > > > @@ -1458,6 +1466,7 @@ static void audit_log_exit(void)
> > > > struct audit_buffer *ab;
> > > > struct audit_aux_data *aux;
> > > > struct audit_names *n;
> > > > + struct audit_contobj *cont;
> > > >
> > > > context->personality = current->personality;
> > > >
> > > > @@ -1541,7 +1550,7 @@ static void audit_log_exit(void)
> > > > for (aux = context->aux_pids; aux; aux = aux->next) {
> > > > struct audit_aux_data_pids *axs = (void *)aux;
> > > >
> > > > - for (i = 0; i < axs->pid_count; i++)
> > > > + for (i = 0; i < axs->pid_count; i++) {
> > > > if (audit_log_pid_context(context, axs->target_pid[i],
> > > > axs->target_auid[i],
> > > > axs->target_uid[i],
> > > > @@ -1549,14 +1558,20 @@ static void audit_log_exit(void)
> > > > axs->target_sid[i],
> > > > axs->target_comm[i]))
> > > > call_panic = 1;
> > > > + audit_log_container_id(context, axs->target_cid[i]);
> > > > + }
> > >
> > > It might be nice to see an audit event example including the
> > > ptrace/signal information. I'm concerned there may be some confusion
> > > about associating the different audit container IDs with the correct
> > > information in the event.
> >
> > This is the subject of ghat81, which is a test for ptrace and signal
> > records.
> >
> > This was the reason I had advocated for an op= field since there is a
> > possibility of multiple contid records per event.
>
> I think an "op=" field is the wrong way to link audit container ID to
> a particular record. It may be convenient, but I fear that it would
> be overloading the field too much.
Ok, after looking at the field dictionary how about item, rel, ref or rec?
Item perhaps could be added to the OBJ_PID records, but that might be
overloading a field that is already used in PATH records. "rel" for
relates-to, "ref" for reference to, "rec" for record... Perhaps pid=
would be enough to tie this record to the OBJ_PID record or the SYSCALL
record, but in the case of network events, the pid may refer to a kernel
thread.
> Like I said above, I think it would be good to see an audit event
> example including the ptrace/signal information. This way we can talk
> about it on-list and hash out the various solutions if it proves to be
> a problem.
See the list posting from 2020-09-29 "auditing signals" pointing to
ghat81 test case about testing ptrace and signals from 18 months ago.
I think I have a way to generate a signal to multiple targets in one
syscall... The added challenge is to also give those targets different
audit container identifiers.
> > > > @@ -1575,6 +1590,14 @@ static void audit_log_exit(void)
> > > >
> > > > audit_log_proctitle();
> > > >
> > > > + rcu_read_lock();
> > > > + cont = _audit_contobj_get(current);
> > > > + rcu_read_unlock();
> > > > + audit_log_container_id(context, cont);
> > > > + rcu_read_lock();
> > > > + _audit_contobj_put(cont);
> > > > + rcu_read_unlock();
> > >
> > > Do we need to grab an additional reference for the audit container
> > > object here? We don't create any additional references here that
> > > persist beyond the lifetime of this function, right?
> >
> > Why do we need another reference? There's one for each pointer pointing
> > to it and so far we have just one from this task. Or are you thinking
> > of the contid hash list, which is only added to when a task points to it
> > and gets removed from that list when the last task stops pointing to it.
> > Later that gets more complicated with network namespaces and nested
> > container objects. For now we just needed it while generating the
> > record, then it gets freed.
>
> I don't think we need to grab an additional reference here, that is
> why I asked the question. The code above grabs a reference for the
> audit container ID object associated with the current task and then
> drops it before returning; if the current task, and it's associated
> audit container ID object, disappears in the middle of the function
> we've got much bigger worries :)
I misunderstood your question previously thinking you wanted yet another
reference taken in this case, when in fact it was the opposite and you
thought the one taken here was superfluous.
I don't *need* to grab the additional references here, but those are the
accessor functions that exist, so I either create sub-accessor functions
without the refcount manipulations that called from the primary accessor
functions or open code a reduncancy... The locking has been updated to
protect the _put by a spin-lock. Now that I look at it, the 4th to 7th
lines could be bypassed by a cont == NULL check.
It is somewhat hidden now since this sequence of 7 commands has been
abstracted into another function that is called from a second location.
> paul moore
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2020-10-02 19:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 13:20 [PATCH ghak90 V9 00/13] audit: implement container identifier Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 01/13] audit: collect audit task parameters Richard Guy Briggs
2020-07-05 15:09 ` Paul Moore
2020-07-07 2:50 ` Richard Guy Briggs
2020-07-08 1:42 ` Paul Moore
2020-07-13 20:29 ` Richard Guy Briggs
2020-07-14 0:44 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 02/13] audit: add container id Richard Guy Briggs
2020-07-04 13:29 ` Paul Moore
2020-07-04 13:30 ` Paul Moore
2020-07-05 15:09 ` Paul Moore
2020-07-29 20:05 ` Richard Guy Briggs
2020-08-21 19:36 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 03/13] audit: read container ID of a process Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 04/13] audit: log drop of contid on exit of last task Richard Guy Briggs
2020-07-05 15:10 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 05/13] audit: log container info of syscalls Richard Guy Briggs
2020-07-05 15:10 ` Paul Moore
2020-07-29 19:40 ` Richard Guy Briggs
2020-08-21 19:15 ` Paul Moore
2020-10-02 19:52 ` Richard Guy Briggs [this message]
2020-10-21 16:39 ` Richard Guy Briggs
2020-10-21 16:49 ` Steve Grubb
2020-10-21 17:53 ` Richard Guy Briggs
2020-10-23 1:21 ` Paul Moore
2020-10-23 20:40 ` Richard Guy Briggs
2020-10-28 1:35 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 06/13] audit: add contid support for signalling the audit daemon Richard Guy Briggs
2020-07-05 15:10 ` Paul Moore
2020-07-29 19:00 ` Richard Guy Briggs
2020-08-21 18:48 ` Paul Moore
2020-10-02 19:25 ` Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 07/13] audit: add support for non-syscall auxiliary records Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 08/13] audit: add containerid support for user records Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-07-18 0:43 ` Richard Guy Briggs
2020-08-21 18:34 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 09/13] audit: add containerid filtering Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 10/13] audit: add support for containerid to network namespaces Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-07-21 22:05 ` Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 11/13] audit: contid check descendancy and nesting Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-08-07 17:10 ` Richard Guy Briggs
2020-08-21 20:13 ` Paul Moore
2020-10-06 20:03 ` Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 12/13] audit: track container nesting Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 13/13] audit: add capcontid to set contid outside init_user_ns Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002195231.GH2882171@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@parisplace.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatel@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).