From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: casey.schaufler@intel.com, linux-audit@redhat.com
Subject: Re: [PATCH v15 07/23] LSM: Use lsmblob in security_secid_to_secctx
Date: Fri, 6 Mar 2020 20:17:50 -0500 [thread overview]
Message-ID: <CAHC9VhS-m1xfszEuCS+DqZMU8WQJWaVnWpeqESHcXzwviFV03A@mail.gmail.com> (raw)
In-Reply-To: <20200222000407.110158-5-casey@schaufler-ca.com>
On Fri, Feb 21, 2020 at 7:05 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> Change security_secid_to_secctx() to take a lsmblob as input
> instead of a u32 secid. It will then call the LSM hooks
> using the lsmblob element allocated for that module. The
> callers have been updated as well. This allows for the
> possibility that more than one module may be called upon
> to translate a secid to a string, as can occur in the
> audit code.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: John Johansen <john.johansen@canonical.com>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> cc: netdev@vger.kernel.org
> ---
> drivers/android/binder.c | 4 +++-
> include/linux/security.h | 5 +++--
> include/net/scm.h | 5 ++---
> kernel/audit.c | 9 +++++++--
> kernel/auditsc.c | 14 ++++++++++----
> net/ipv4/ip_sockglue.c | 3 +--
> net/netfilter/nf_conntrack_netlink.c | 8 ++++++--
> net/netfilter/nf_conntrack_standalone.c | 4 +++-
> net/netfilter/nfnetlink_queue.c | 8 ++++++--
> net/netlabel/netlabel_unlabeled.c | 18 ++++++++++++++----
> net/netlabel/netlabel_user.c | 6 +++---
> security/security.c | 16 +++++++++++++---
> 12 files changed, 71 insertions(+), 29 deletions(-)
More of the lsmblob_init()/dosomething() pattern.
I'm sure this will all change later (and peeking ahead, it looks like
most of it does), but I think it needs to be better documented in
these commits about what is temporary and what is intended to stick
around. Imagine years later bisecting down to this patch and trying
to make sense of why it was done this way.
I realize that it is hard to make individual patches do something
meaningful when you are making such sweeping changes, but in these
cases you need to document it until there is no doubt about why this
patch exists.
--
paul moore
www.paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2020-03-07 1:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200222000407.110158-1-casey.ref@schaufler-ca.com>
2020-02-22 0:03 ` [PATCH v15 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-02-22 0:03 ` Casey Schaufler
2020-02-22 0:03 ` [PATCH v15 01/23] LSM: Infrastructure management of the sock security Casey Schaufler
2020-02-22 0:03 ` Casey Schaufler
2020-02-22 0:03 ` [PATCH v15 02/23] LSM: Create and manage the lsmblob data structure Casey Schaufler
2020-02-22 0:03 ` Casey Schaufler
2020-03-06 20:55 ` Paul Moore
2020-02-22 0:03 ` [PATCH v15 03/23] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2020-02-22 0:03 ` Casey Schaufler
2020-03-06 22:01 ` Paul Moore
2020-03-09 23:58 ` Casey Schaufler
2020-03-10 0:55 ` Paul Moore
2020-02-22 0:03 ` [PATCH v15 07/23] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2020-02-22 0:03 ` Casey Schaufler
2020-03-07 1:17 ` Paul Moore [this message]
2020-02-22 0:03 ` [PATCH v15 08/23] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2020-02-22 0:03 ` Casey Schaufler
2020-03-07 1:21 ` Paul Moore
2020-02-22 0:04 ` [PATCH v15 09/23] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-02-22 0:04 ` [PATCH v15 10/23] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-02-22 0:04 ` [PATCH v15 11/23] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-03-07 1:36 ` Paul Moore
2020-02-22 0:04 ` [PATCH v15 12/23] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-02-22 0:04 ` [PATCH v15 14/23] LSM: Ensure the correct LSM context releaser Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-02-22 0:04 ` [PATCH v15 15/23] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-03-07 2:01 ` Paul Moore
2020-02-22 0:04 ` [PATCH v15 20/23] Audit: Add subj_LSM fields when necessary Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-03-07 2:18 ` Paul Moore
2020-03-07 2:24 ` Paul Moore
2020-03-10 1:25 ` Casey Schaufler
2020-03-10 21:46 ` Paul Moore
2020-02-22 0:04 ` [PATCH v15 21/23] Audit: Include object data for all security modules Casey Schaufler
2020-02-22 0:04 ` Casey Schaufler
2020-03-07 2:31 ` Paul Moore
2020-03-09 17:45 ` Casey Schaufler
2020-03-09 17:59 ` Paul Moore
2020-03-09 23:01 ` Casey Schaufler
2020-03-10 21:42 ` Paul Moore
2020-02-27 17:29 ` [PATCH v15 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-03-03 17:22 ` Casey Schaufler
2020-03-03 17:54 ` Paul Moore
2020-03-03 17:58 ` Casey Schaufler
2020-03-06 17:14 ` Steve Grubb
2020-03-09 17:15 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhS-m1xfszEuCS+DqZMU8WQJWaVnWpeqESHcXzwviFV03A@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).