* [PATCH] MAINTAINERS: update audit files
@ 2021-03-11 16:39 Richard Guy Briggs
2021-03-12 21:38 ` Paul Moore
0 siblings, 1 reply; 3+ messages in thread
From: Richard Guy Briggs @ 2021-03-11 16:39 UTC (permalink / raw)
To: Linux-Audit Mailing List, LKML; +Cc: Richard Guy Briggs, Eric Paris
Add files maintaned by the audit subsystem.
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
MAINTAINERS | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6eff4f720c72..a17532559665 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3015,9 +3015,13 @@ L: linux-audit@redhat.com (moderated for non-subscribers)
S: Supported
W: https://github.com/linux-audit
T: git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
+F: arch/*/*/*audit*.[ch]
+F: arch/x86/include/asm/audit.h
+F: include/asm-generic/audit_*.h
F: include/linux/audit.h
F: include/uapi/linux/audit.h
F: kernel/audit*
+F: lib/*audit.c
AUXILIARY DISPLAY DRIVERS
M: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
--
2.27.0
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MAINTAINERS: update audit files
2021-03-11 16:39 [PATCH] MAINTAINERS: update audit files Richard Guy Briggs
@ 2021-03-12 21:38 ` Paul Moore
2021-03-13 4:04 ` Richard Guy Briggs
0 siblings, 1 reply; 3+ messages in thread
From: Paul Moore @ 2021-03-12 21:38 UTC (permalink / raw)
To: Richard Guy Briggs; +Cc: Eric Paris, Linux-Audit Mailing List, LKML
On Thu, Mar 11, 2021 at 11:41 AM Richard Guy Briggs <rgb@redhat.com> wrote:
>
> Add files maintaned by the audit subsystem.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6eff4f720c72..a17532559665 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3015,9 +3015,13 @@ L: linux-audit@redhat.com (moderated for non-subscribers)
> S: Supported
> W: https://github.com/linux-audit
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
> +F: arch/*/*/*audit*.[ch]
That looks like it has about two too many wildcards to hold up over time :)
I understand what you're trying to do here, and while I don't disagree
in principle, I worry that the arch specific paths vary enough that
trying to handle it here is going to be a bit of a mess.
> +F: arch/x86/include/asm/audit.h
The fact that we need a special entry for the single header under x86
tends to reinforce that. The other additions make sense, but I think
it may be best to leave the arch specific areas alone for now.
> +F: include/asm-generic/audit_*.h
> F: include/linux/audit.h
> F: include/uapi/linux/audit.h
> F: kernel/audit*
> +F: lib/*audit.c
>
> AUXILIARY DISPLAY DRIVERS
> M: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> --
> 2.27.0
--
paul moore
www.paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MAINTAINERS: update audit files
2021-03-12 21:38 ` Paul Moore
@ 2021-03-13 4:04 ` Richard Guy Briggs
0 siblings, 0 replies; 3+ messages in thread
From: Richard Guy Briggs @ 2021-03-13 4:04 UTC (permalink / raw)
To: Paul Moore; +Cc: Eric Paris, Linux-Audit Mailing List, LKML
On 2021-03-12 16:38, Paul Moore wrote:
> On Thu, Mar 11, 2021 at 11:41 AM Richard Guy Briggs <rgb@redhat.com> wrote:
> > Add files maintaned by the audit subsystem.
> >
> > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > ---
> > MAINTAINERS | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6eff4f720c72..a17532559665 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3015,9 +3015,13 @@ L: linux-audit@redhat.com (moderated for non-subscribers)
> > S: Supported
> > W: https://github.com/linux-audit
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
> > +F: arch/*/*/*audit*.[ch]
>
> That looks like it has about two too many wildcards to hold up over time :)
>
> I understand what you're trying to do here, and while I don't disagree
> in principle, I worry that the arch specific paths vary enough that
> trying to handle it here is going to be a bit of a mess.
>
> > +F: arch/x86/include/asm/audit.h
>
> The fact that we need a special entry for the single header under x86
> tends to reinforce that. The other additions make sense, but I think
> it may be best to leave the arch specific areas alone for now.
Ok, I should have labelled this "RFC". :-)
> > +F: include/asm-generic/audit_*.h
> > F: include/linux/audit.h
> > F: include/uapi/linux/audit.h
> > F: kernel/audit*
> > +F: lib/*audit.c
> >
> > AUXILIARY DISPLAY DRIVERS
> > M: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> > --
> > 2.27.0
>
> paul moore
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-13 4:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 16:39 [PATCH] MAINTAINERS: update audit files Richard Guy Briggs
2021-03-12 21:38 ` Paul Moore
2021-03-13 4:04 ` Richard Guy Briggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).