* [PATCH v2 -next] md: bcache: use DEFINE_MUTEX() for mutex lock
@ 2020-12-24 13:24 Zheng Yongjun
2020-12-24 14:47 ` Coly Li
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-24 13:24 UTC (permalink / raw)
To: colyli, kent.overstreet, linux-bcache, linux-kernel; +Cc: Zheng Yongjun
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/md/bcache/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 46a00134a36a..963d62a15f37 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
};
static struct kobject *bcache_kobj;
-struct mutex bch_register_lock;
+DEFINE_MUTEX(bch_register_lock);
bool bcache_is_reboot;
LIST_HEAD(bch_cache_sets);
static LIST_HEAD(uncached_devices);
@@ -2832,7 +2832,6 @@ static int __init bcache_init(void)
check_module_parameters();
- mutex_init(&bch_register_lock);
init_waitqueue_head(&unregister_wait);
register_reboot_notifier(&reboot);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 -next] md: bcache: use DEFINE_MUTEX() for mutex lock
2020-12-24 13:24 [PATCH v2 -next] md: bcache: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
@ 2020-12-24 14:47 ` Coly Li
0 siblings, 0 replies; 2+ messages in thread
From: Coly Li @ 2020-12-24 14:47 UTC (permalink / raw)
To: Zheng Yongjun, kent.overstreet, linux-bcache, linux-kernel
On 12/24/20 9:24 PM, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
NACK. For this case, it is unnecessary to initialize a global variable
so early in declaration, this change makes bcache.ko bigger and I don't
see any benefit.
Coly Li
> ---
> drivers/md/bcache/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 46a00134a36a..963d62a15f37 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
> };
>
> static struct kobject *bcache_kobj;
> -struct mutex bch_register_lock;
> +DEFINE_MUTEX(bch_register_lock);
> bool bcache_is_reboot;
> LIST_HEAD(bch_cache_sets);
> static LIST_HEAD(uncached_devices);
> @@ -2832,7 +2832,6 @@ static int __init bcache_init(void)
>
> check_module_parameters();
>
> - mutex_init(&bch_register_lock);
> init_waitqueue_head(&unregister_wait);
> register_reboot_notifier(&reboot);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-24 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24 13:24 [PATCH v2 -next] md: bcache: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2020-12-24 14:47 ` Coly Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).