From: Coly Li <colyli@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-bcache@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 7/7] bcache: fix a regression of code compiling failure in debug.c
Date: Mon, 12 Apr 2021 17:53:50 +0800 [thread overview]
Message-ID: <902e1ba6-cd73-b0e8-6c17-75fccbaeb9b4@suse.de> (raw)
In-Reply-To: <20210412090600.GA8026@lst.de>
On 4/12/21 5:06 PM, Christoph Hellwig wrote:
> On Sun, Apr 11, 2021 at 09:43:16PM +0800, Coly Li wrote:
>> The patch "bcache: remove PTR_CACHE" introduces a compiling failure in
>> debug.c with following error message,
>> In file included from drivers/md/bcache/bcache.h:182:0,
>> from drivers/md/bcache/debug.c:9:
>> drivers/md/bcache/debug.c: In function 'bch_btree_verify':
>> drivers/md/bcache/debug.c:53:19: error: 'c' undeclared (first use in
>> this function)
>> bio_set_dev(bio, c->cache->bdev);
>> ^
>> This patch fixes the regression by replacing c->cache->bdev by b->c->
>> cache->bdev.
>
> Why not fold this into the offending patch?
>
I don't know whether I can do it without authorization or agreement from
original author. And I see other maintainers handling similar situation
by either re-write whole patch or appending an extra fix.
If you have a suggested process, I can try it out next time for similar
situation.
Coly Li
next prev parent reply other threads:[~2021-04-12 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 13:43 [PATCH 0/7] bcache patches for Linux 5.13 -- 1st wave Coly Li
2021-04-11 13:43 ` [PATCH 1/7] bcache: reduce redundant code in bch_cached_dev_run() Coly Li
2021-04-11 13:43 ` [PATCH 2/7] bcache: remove PTR_CACHE Coly Li
2021-04-11 13:43 ` [PATCH 3/7] bcache: use NULL instead of using plain integer as pointer Coly Li
2021-04-11 13:43 ` [PATCH 4/7] md: bcache: avoid -Wempty-body warnings Coly Li
2021-04-11 13:43 ` [PATCH 5/7] md: bcache: Trivial typo fixes in the file journal.c Coly Li
2021-04-11 13:43 ` [PATCH 6/7] bcache: Use 64-bit arithmetic instead of 32-bit Coly Li
2021-04-11 13:43 ` [PATCH 7/7] bcache: fix a regression of code compiling failure in debug.c Coly Li
2021-04-12 9:06 ` Christoph Hellwig
2021-04-12 9:53 ` Coly Li [this message]
2021-04-12 12:50 ` Jens Axboe
2021-04-12 13:13 ` Coly Li
2021-04-11 14:40 ` [PATCH 0/7] bcache patches for Linux 5.13 -- 1st wave Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=902e1ba6-cd73-b0e8-6c17-75fccbaeb9b4@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).