From: Christoph Hellwig <hch@lst.de>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>,
bfoster@redhat.com, linux-bcachefs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH
Date: Mon, 22 Jan 2024 07:30:07 +0100 [thread overview]
Message-ID: <20240122063007.GA23991@lst.de> (raw)
In-Reply-To: <ueeqal442uw77vrmonr5crix5jehetzg266725shaqi2oim6h7@4q4tlcm2y6k7>
On Fri, Jan 19, 2024 at 04:32:44PM -0500, Kent Overstreet wrote:
>
> I've got a new bug report with this patch:
> https://www.reddit.com/r/bcachefs/comments/19a2u3c/error_writing_journal_entry/
>
> We seem to be geting -EOPNOTSUPP back from REQ_OP_FLUSH?
With the patch you are replying to you will not get -EOPNOTSUPP
for REQ_OP_FLUSH?, because bcachefs won't send it as it's supposed to.
Without this patch as in current mainline you will get -EOPNOTSUPP
because sending REQ_OP_FLUSH and finally check for that to catch bugs
like the one fixed with this patch.
next prev parent reply other threads:[~2024-01-22 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 7:36 [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH Christoph Hellwig
2024-01-11 16:37 ` Kent Overstreet
2024-01-19 21:32 ` Kent Overstreet
2024-01-22 6:30 ` Christoph Hellwig [this message]
2024-01-22 6:37 ` Kent Overstreet
2024-01-22 6:50 ` Christoph Hellwig
2024-01-22 17:37 ` Kent Overstreet
2024-01-22 17:38 ` Christoph Hellwig
2024-01-22 17:42 ` Kent Overstreet
2024-01-22 18:41 ` Christoph Hellwig
2024-01-23 0:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122063007.GA23991@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).