* [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl()
@ 2024-04-30 3:27 Youling Tang
2024-04-30 3:29 ` Kent Overstreet
0 siblings, 1 reply; 3+ messages in thread
From: Youling Tang @ 2024-04-30 3:27 UTC (permalink / raw)
To: Kent Overstreet; +Cc: linux-bcachefs, linux-kernel, Youling Tang
From: Youling Tang <tangyouling@kylinos.cn>
It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in
compat ioctl.
Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
---
fs/bcachefs/fs-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
index 3dc8630ff9fe..205a323ffc6d 100644
--- a/fs/bcachefs/fs-ioctl.c
+++ b/fs/bcachefs/fs-ioctl.c
@@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
{
/* These are just misnamed, they actually get/put from/to user an int */
switch (cmd) {
- case FS_IOC_GETFLAGS:
+ case FS_IOC32_GETFLAGS:
cmd = FS_IOC_GETFLAGS;
break;
case FS_IOC32_SETFLAGS:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl()
2024-04-30 3:27 [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl() Youling Tang
@ 2024-04-30 3:29 ` Kent Overstreet
2024-04-30 4:13 ` Youling Tang
0 siblings, 1 reply; 3+ messages in thread
From: Kent Overstreet @ 2024-04-30 3:29 UTC (permalink / raw)
To: Youling Tang; +Cc: linux-bcachefs, linux-kernel, Youling Tang
On Tue, Apr 30, 2024 at 11:27:44AM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in
> compat ioctl.
Do we by chance have a test for this?
>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> ---
> fs/bcachefs/fs-ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
> index 3dc8630ff9fe..205a323ffc6d 100644
> --- a/fs/bcachefs/fs-ioctl.c
> +++ b/fs/bcachefs/fs-ioctl.c
> @@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> {
> /* These are just misnamed, they actually get/put from/to user an int */
> switch (cmd) {
> - case FS_IOC_GETFLAGS:
> + case FS_IOC32_GETFLAGS:
> cmd = FS_IOC_GETFLAGS;
> break;
> case FS_IOC32_SETFLAGS:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl()
2024-04-30 3:29 ` Kent Overstreet
@ 2024-04-30 4:13 ` Youling Tang
0 siblings, 0 replies; 3+ messages in thread
From: Youling Tang @ 2024-04-30 4:13 UTC (permalink / raw)
To: Kent Overstreet; +Cc: linux-bcachefs, linux-kernel, Youling Tang
On 30/04/2024 11:29, Kent Overstreet wrote:
> On Tue, Apr 30, 2024 at 11:27:44AM +0800, Youling Tang wrote:
>> From: Youling Tang <tangyouling@kylinos.cn>
>>
>> It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in
>> compat ioctl.
> Do we by chance have a test for this?
Just reading the code found this out.
>
>> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
>> ---
>> fs/bcachefs/fs-ioctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
>> index 3dc8630ff9fe..205a323ffc6d 100644
>> --- a/fs/bcachefs/fs-ioctl.c
>> +++ b/fs/bcachefs/fs-ioctl.c
>> @@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
>> {
>> /* These are just misnamed, they actually get/put from/to user an int */
>> switch (cmd) {
>> - case FS_IOC_GETFLAGS:
>> + case FS_IOC32_GETFLAGS:
>> cmd = FS_IOC_GETFLAGS;
>> break;
>> case FS_IOC32_SETFLAGS:
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-30 4:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30 3:27 [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl() Youling Tang
2024-04-30 3:29 ` Kent Overstreet
2024-04-30 4:13 ` Youling Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).