[PATCH] A small compile fix

[PATCH] A small compile fix

[Mikulas Patocka]

Hi

Here I'm sending a small compile fix for bcachefs-tools.

Without this patch, I get this error:

cargo  build --release --manifest-path rust-src/Cargo.toml
   Compiling bch_bindgen v0.1.0 
(/usr/src/git/bcachefs-tools/rust-src/bch_bindgen)
error: failed to run custom build command for `bch_bindgen v0.1.0 
(/usr/src/git/bcachefs-tools/rust-src/bch_bindgen)`

Caused by:
  process didn't exit successfully: 
`/usr/src/git/bcachefs-tools/rust-src/target/release/build/bch_bindgen-733e88995ce9eab7/build-script-build` 
(exit status: 101)
  --- stderr
  warning: optimization flag '-fkeep-inline-functions' is not supported 
[-Wignored-optimization-argument]
  ../../include/linux/bit_spinlock.h:20:3: error: call to undeclared 
function 'futex'; ISO C99 and later do not support implicit function 
declarations [-Wimplicit-function-declaration]
  ../../include/linux/bit_spinlock.h:28:2: error: call to undeclared 
function 'futex'; ISO C99 and later do not support implicit function 
declarations [-Wimplicit-function-declaration]
  ../../include/linux/bit_spinlock.h:39:2: error: call to undeclared 
function 'futex'; ISO C99 and later do not support implicit function 
declarations [-Wimplicit-function-declaration]


The futex() function is declared in 
	/usr/include/x86_64-linux-gnu/urcu/futex.h
It is not declared in linux/futex.h, so we need to include urcu/futex.h

Mikulas


---
 include/linux/bit_spinlock.h |    1 +
 1 file changed, 1 insertion(+)

Index: bcachefs-tools/include/linux/bit_spinlock.h
===================================================================
--- bcachefs-tools.orig/include/linux/bit_spinlock.h
+++ bcachefs-tools/include/linux/bit_spinlock.h
@@ -4,6 +4,7 @@
 #include <linux/kernel.h>
 #include <linux/preempt.h>
 #include <linux/futex.h>
+#include <urcu/futex.h>
 
 static inline void bit_spin_lock(int nr, unsigned long *_addr)
 {

Re: [PATCH] A small compile fix

[Kent Overstreet]

On Wed, Apr 26, 2023 at 08:31:10AM -0400, Mikulas Patocka wrote:
> Hi
> 
> Here I'm sending a small compile fix for bcachefs-tools.

Signed-off-by?

Re: [PATCH] A small compile fix

[Mikulas Patocka]

On Wed, 26 Apr 2023, Kent Overstreet wrote:

> On Wed, Apr 26, 2023 at 08:31:10AM -0400, Mikulas Patocka wrote:
> > Hi
> > 
> > Here I'm sending a small compile fix for bcachefs-tools.
> 
> Signed-off-by?

Yes, you can add

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Mikulas

Re: [PATCH] A small compile fix

[Kent Overstreet]

On Wed, Apr 26, 2023 at 10:40:27AM -0400, Mikulas Patocka wrote:
> 
> 
> On Wed, 26 Apr 2023, Kent Overstreet wrote:
> 
> > On Wed, Apr 26, 2023 at 08:31:10AM -0400, Mikulas Patocka wrote:
> > > Hi
> > > 
> > > Here I'm sending a small compile fix for bcachefs-tools.
> > 
> > Signed-off-by?
> 
> Yes, you can add
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> 
> Mikulas

Thanks!