From: Hannes Reinecke <hare@suse.de>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Kashyap Desai <kashyap.desai@broadcom.com>,
Qian Cai <cai@redhat.com>, Christoph Hellwig <hch@lst.de>,
Sumit Saxena <sumit.saxena@broadcom.com>,
John Garry <john.garry@huawei.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V2 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing"
Date: Thu, 3 Dec 2020 07:44:29 +0100 [thread overview]
Message-ID: <000de78f-a0b5-bec9-9b1c-7032dd930ac4@suse.de> (raw)
In-Reply-To: <20201203012638.543321-4-ming.lei@redhat.com>
On 12/3/20 2:26 AM, Ming Lei wrote:
> This reverts commit b3c6a59975415bde29cfd76ff1ab008edbf614a9.
>
> Now we can avoid nvme-loop lockdep warning of 'lockdep possible recursive locking'
> by nvme-loop's lock class, no need to apply dynamically allocated lock class key,
> so revert commit b3c6a5997541("block: Fix a lockdep complaint triggered by request
> queue flushing").
>
> This way fixes horrible SCSI probe delay issue on megaraid_sas, and it is reported
> the whole probe may take more than half an hour.
>
> Tested-by: Kashyap Desai <kashyap.desai@broadcom.com>
> Reported-by: Qian Cai <cai@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Sumit Saxena <sumit.saxena@broadcom.com>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> block/blk-flush.c | 5 -----
> block/blk.h | 1 -
> 2 files changed, 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-12-03 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 1:26 [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Ming Lei
2020-12-03 1:26 ` [PATCH V2 1/3] blk-mq: add new API of blk_mq_hctx_set_fq_lock_class Ming Lei
2020-12-03 6:42 ` Hannes Reinecke
2020-12-03 1:26 ` [PATCH V2 2/3] nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class Ming Lei
2020-12-03 6:43 ` Hannes Reinecke
2020-12-03 1:26 ` [PATCH V2 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing" Ming Lei
2020-12-03 6:44 ` Hannes Reinecke [this message]
2020-12-08 1:40 ` [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Ming Lei
2020-12-08 3:30 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-11-12 7:55 [PATCH " Ming Lei
2020-11-12 7:55 ` [PATCH 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing" Ming Lei
2020-11-13 1:27 ` [PATCH V2 " Ming Lei
2020-11-16 17:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=000de78f-a0b5-bec9-9b1c-7032dd930ac4@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cai@redhat.com \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).