From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Qian Cai <cai@redhat.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
John Garry <john.garry@huawei.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning
Date: Tue, 8 Dec 2020 09:40:19 +0800 [thread overview]
Message-ID: <20201208014019.GB1059392@T590> (raw)
In-Reply-To: <20201203012638.543321-1-ming.lei@redhat.com>
On Thu, Dec 03, 2020 at 09:26:35AM +0800, Ming Lei wrote:
> Hi,
>
> Qian reported there is hang during booting when shared host tagset is
> introduced on megaraid sas. Sumit reported the whole SCSI probe takes
> about ~45min in his test.
>
> Turns out it is caused by nr_hw_queues increased, especially commit
> b3c6a5997541("block: Fix a lockdep complaint triggered by request queue flushing")
> adds synchronize_rcu() for each hctx's release handler.
>
> Address the original lockdep false positive warning by simpler way, then
> long scsi probe can be avoided with lockdep enabled.
>
> V2:
> - add reviewed-by
> - adjust commit log of patch 3
>
> Ming Lei (3):
> blk-mq: add new API of blk_mq_hctx_set_fq_lock_class
> nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class
> Revert "block: Fix a lockdep complaint triggered by request queue
> flushing"
>
> block/blk-flush.c | 30 +++++++++++++++++++++++++-----
> block/blk.h | 1 -
> drivers/nvme/target/loop.c | 10 ++++++++++
> include/linux/blk-mq.h | 3 +++
> 4 files changed, 38 insertions(+), 6 deletions(-)
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Qian Cai <cai@redhat.com>
> Cc: Sumit Saxena <sumit.saxena@broadcom.com>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Hannes Reinecke <hare@suse.de>
> --
> 2.28.0
>
Hello Jens,
Ping...
--
Ming
next prev parent reply other threads:[~2020-12-08 1:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 1:26 [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Ming Lei
2020-12-03 1:26 ` [PATCH V2 1/3] blk-mq: add new API of blk_mq_hctx_set_fq_lock_class Ming Lei
2020-12-03 6:42 ` Hannes Reinecke
2020-12-03 1:26 ` [PATCH V2 2/3] nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class Ming Lei
2020-12-03 6:43 ` Hannes Reinecke
2020-12-03 1:26 ` [PATCH V2 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing" Ming Lei
2020-12-03 6:44 ` Hannes Reinecke
2020-12-08 1:40 ` Ming Lei [this message]
2020-12-08 3:30 ` [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208014019.GB1059392@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cai@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).