From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blk-sysfs: Rework documention of __blk_release_queue
Date: Sat, 9 Feb 2019 16:34:01 -0200 [thread overview]
Message-ID: <02fcaaa4-3667-7144-5ca2-4e5346380439@gmail.com> (raw)
In-Reply-To: <20190131011139.2264742-1-marcos.souza.org@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2382 bytes --]
Ping :)
On 1/30/19 11:11 PM, Marcos Paulo de Souza wrote:
> The Notes section of the comment was removed, because now
> blk_release_queue can only be executed from blk_cleanup_queue (being
> called when the q->kobj reaches zero), and also blk_init_queue was removed
> in a1ce35fa4985.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
> This is basically a v2 of https://lkml.org/lkml/2019/1/14/1098
>
> But, I tried to describe when this function is called, removing redundancies.
> Maybe it would be better placed in blk-core.c, where the q->kobj is initialized
> with blk_queue_ktype (which .release pointer points to blk_release_queue)?
>
> block/blk-sysfs.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index 590d1ef2f961..d4dea9179fa6 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -817,21 +817,16 @@ static void blk_free_queue_rcu(struct rcu_head *rcu_head)
> }
>
> /**
> - * __blk_release_queue - release a request queue when it is no longer needed
> + * __blk_release_queue - release a request queue
> * @work: pointer to the release_work member of the request queue to be released
> *
> * Description:
> - * blk_release_queue is the counterpart of blk_init_queue(). It should be
> - * called when a request queue is being released; typically when a block
> - * device is being de-registered. Its primary task it to free the queue
> - * itself.
> - *
> - * Notes:
> - * The low level driver must have finished any outstanding requests first
> - * via blk_cleanup_queue().
> - *
> - * Although blk_release_queue() may be called with preemption disabled,
> - * __blk_release_queue() may sleep.
> + * This function is called when a block device is being de-registered. The
> + * process of releasing a request queue starts with blk_cleanup_queue, which
> + * set the appropriate flags and the calls blk_put_queue, that decrements
> + * the reference counter of the request queue. Once the reference counter
> + * of the request queue reaches zero, blk_release_queue is called to release
> + * all allocated resources of the request queue.
> */
> static void __blk_release_queue(struct work_struct *work)
> {
>
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1817 bytes --]
next prev parent reply other threads:[~2019-02-09 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 1:11 [PATCH] blk-sysfs: Rework documention of __blk_release_queue Marcos Paulo de Souza
2019-02-09 18:34 ` Marcos Paulo de Souza [this message]
2019-02-10 15:23 ` Jens Axboe
[not found] ` <CAH0vN5JF6p0B+uO2CQ-+Bv_cEtBRtWdpLJHD9mYAf3Ht2GncdA@mail.gmail.com>
2019-02-10 15:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02fcaaa4-3667-7144-5ca2-4e5346380439@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).