linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] loop: remove unused variable in loop_set_status()
@ 2021-07-02 15:27 Tetsuo Handa
  2021-07-02 15:29 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Tetsuo Handa @ 2021-07-02 15:27 UTC (permalink / raw)
  To: Christoph Hellwig, Jan Kara; +Cc: Jens Axboe, linux-block, Tetsuo Handa

Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
changed to pass lo->lo_disk instead of lo->lo_device.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
 drivers/block/loop.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index cc0e8c39a48b..9f5a93688164 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1434,7 +1434,6 @@ static int
 loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 {
 	int err;
-	struct block_device *bdev;
 	kuid_t uid = current_uid();
 	int prev_lo_flags;
 	bool partscan = false;
@@ -1503,7 +1502,6 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	if (!err && (lo->lo_flags & LO_FLAGS_PARTSCAN) &&
 	     !(prev_lo_flags & LO_FLAGS_PARTSCAN)) {
 		lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN;
-		bdev = lo->lo_device;
 		partscan = true;
 	}
 out_unlock:
-- 
2.18.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] loop: remove unused variable in loop_set_status()
  2021-07-02 15:27 [PATCH] loop: remove unused variable in loop_set_status() Tetsuo Handa
@ 2021-07-02 15:29 ` Jens Axboe
  2021-07-02 15:31   ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2021-07-02 15:29 UTC (permalink / raw)
  To: Tetsuo Handa, Christoph Hellwig, Jan Kara; +Cc: linux-block

On 7/2/21 9:27 AM, Tetsuo Handa wrote:
> Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
> changed to pass lo->lo_disk instead of lo->lo_device.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] loop: remove unused variable in loop_set_status()
  2021-07-02 15:29 ` Jens Axboe
@ 2021-07-02 15:31   ` Christoph Hellwig
  2021-07-02 15:32     ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2021-07-02 15:31 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Tetsuo Handa, Christoph Hellwig, Jan Kara, linux-block

On Fri, Jul 02, 2021 at 09:29:26AM -0600, Jens Axboe wrote:
> On 7/2/21 9:27 AM, Tetsuo Handa wrote:
> > Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
> > changed to pass lo->lo_disk instead of lo->lo_device.
> 
> Applied, thanks.

FYI, I also sent a patch on June 25th for this..

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] loop: remove unused variable in loop_set_status()
  2021-07-02 15:31   ` Christoph Hellwig
@ 2021-07-02 15:32     ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-07-02 15:32 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Tetsuo Handa, Jan Kara, linux-block

On 7/2/21 9:31 AM, Christoph Hellwig wrote:
> On Fri, Jul 02, 2021 at 09:29:26AM -0600, Jens Axboe wrote:
>> On 7/2/21 9:27 AM, Tetsuo Handa wrote:
>>> Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
>>> changed to pass lo->lo_disk instead of lo->lo_device.
>>
>> Applied, thanks.
> 
> FYI, I also sent a patch on June 25th for this..

Oops, looks like I missed that one.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-02 15:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 15:27 [PATCH] loop: remove unused variable in loop_set_status() Tetsuo Handa
2021-07-02 15:29 ` Jens Axboe
2021-07-02 15:31   ` Christoph Hellwig
2021-07-02 15:32     ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).